From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 45B69C52D7B for ; Wed, 14 Aug 2024 14:09:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=N82Nc2+gY4/+lTNM9bo2pmanPWXfOJy6ZWbbOExaRpU=; b=BWpzWX7H7QoUpaju6Ld3+72yDw 4+Xnot4WE25OHLHONT369EJbrJIizjf0QqTQyelFLWXNVM0ZGzVzh9SLcvN2xQ+wYjdnf5HTC/3gR mO2J7ZIq5NG3iIOzjx1mR2ziNYjjRCR0TyX/77AqZWNR/zj6z7efV5ZHhwdMNvw/jMN82M8Pzf5kk liBo6QsMdkBA5QqwWSJMcchvsuKq1tqSSHQdLViW9xPh325fVed7EzU6R7GserovuCbqbGbrOKA4k us80EfoPZpxK69lG5qiR2o7emmU4yh0x8sV4kTrLFy4ZGrMn27Vm2xylHWPm0sNQG/Rl0MqpQ3a6z alz7c+Ow==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1seEgv-00000007DWc-0GID; Wed, 14 Aug 2024 14:09:33 +0000 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1seEgI-00000007DQv-0pQp for linux-arm-kernel@lists.infradead.org; Wed, 14 Aug 2024 14:08:55 +0000 Received: by mail-wr1-x433.google.com with SMTP id ffacd0b85a97d-368313809a4so559970f8f.0 for ; Wed, 14 Aug 2024 07:08:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1723644532; x=1724249332; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=N82Nc2+gY4/+lTNM9bo2pmanPWXfOJy6ZWbbOExaRpU=; b=BGY1B1nAxcRWOGggmmR3f6P5o6JzK87u/tsunIwyGE3G9w0u789LnPBtNA0681cyZP fTdXPVXoDDI7CrSNyasBdyyR+xVrYO46SZKr0duZsvScbOd6RFmLCgV29jDdOhyX0QrG VLiNMICu7uK8ujQYQmt+jf6ZwZNwhXim2gSD8YglSZm2debNiGi9bim1ZwDcIq7JKRxY OoQ2kMJHm6BHOycnXMOmnlvOGM99WeRzI7pWtFUykcyD6yxoyX0vdBVK9CbFKurVJl2o SyaJuNAqMiFbJGFXhX+977Nn2d/H+YbMK4QKmmCB6A+cgaAVKhkldnFeCC3Om3k4ERjm LL6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723644532; x=1724249332; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=N82Nc2+gY4/+lTNM9bo2pmanPWXfOJy6ZWbbOExaRpU=; b=VWPZlt835G5bpmaRqdWyvyoL1EVJMd5gxstKrCxuvij3+e9SSSa/PRGcIoTxtGG3eG gjb5/Knj0eqQ9Ud07Cn+q03Tap9vi2za5pVi6ugJOjkYc6i7Sz663Yd1udkND8OlXlVm 5Q0uicpppmgp6Mf/lI0VHZlbDnzzPOf9ca56Y5ggJmkRbXBh7qWl+o/Upcbna7lJISMo uYDmQEmqAYIy3AQaSKlHrfTmHW+W7Uia8SDxwQcpWZENH6v9z2F3FXFk+CrSE+PApbns MCnhxxfsrVKYcDKwHtlT7nPuOlj5mX2iLoWFcfOp2AsXMKJBRudAytl/RTEjoSah1vU9 dEnA== X-Forwarded-Encrypted: i=1; AJvYcCW0TvpiM3vSUwRoRait536n/4OaUPuXl3WTiZOUxTPdGgGH0B/1BJP1PsAA99zQyR/gCGBNuLQwWDA/UGunjV0Lkmd4m58LkvyITgWdedGNK76oaRY= X-Gm-Message-State: AOJu0YwoE00hv+JEth0JOCrL4Jn+XPS2LOTXnmSonfKjosALIaCJZyIl iTpfcK2uJ/VNa0vz5BIKFVLzkNLJqLYHuw3NTDi7uYIrEDvOuhhKwlgaqYKVmY0= X-Google-Smtp-Source: AGHT+IGDqgiodX5asQzw8Eqc0zS1NjySybHtSTj+w8HqPC6KzCZ1oRb7Ab3PGuHo2p4wURp/PaZg9Q== X-Received: by 2002:a5d:4530:0:b0:360:8c88:ab82 with SMTP id ffacd0b85a97d-371796a10b9mr1591919f8f.30.1723644532127; Wed, 14 Aug 2024 07:08:52 -0700 (PDT) Received: from [192.168.1.20] ([178.197.215.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36e4cfefa29sm12945847f8f.61.2024.08.14.07.08.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Aug 2024 07:08:51 -0700 (PDT) Message-ID: Date: Wed, 14 Aug 2024 16:08:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v10 1/5] dt-bindings: net: wireless: brcm4329-fmac: add pci14e4,449d To: Arend van Spriel , Krzysztof Kozlowski , Jacobe Zang , robh@kernel.org, krzk+dt@kernel.org, heiko@sntech.de, kvalo@kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, conor+dt@kernel.org Cc: efectn@protonmail.com, dsimic@manjaro.org, jagan@edgeble.ai, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, arend@broadcom.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, megi@xff.cz, duoming@zju.edu.cn, bhelgaas@google.com, minipli@grsecurity.net, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, nick@khadas.com References: <20240813082007.2625841-1-jacobe.zang@wesion.com> <20240813082007.2625841-2-jacobe.zang@wesion.com> <1914cb2b1a8.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com> <062d8d4e-6d61-4f11-a9c0-1bbe1bfe0542@broadcom.com> <1e442710-a233-4ab2-a551-f28ba6394b5b@linaro.org> <180f7459-39fa-4e96-83d6-504e7802dc94@broadcom.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240814_070854_283716_A4D02933 X-CRM114-Status: GOOD ( 25.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 14/08/2024 13:15, Krzysztof Kozlowski wrote: > On 14/08/2024 12:59, Arend van Spriel wrote: >> On 8/14/2024 12:39 PM, Krzysztof Kozlowski wrote: >>> On 14/08/2024 12:08, Arend van Spriel wrote: >>>> On 8/14/2024 10:53 AM, Krzysztof Kozlowski wrote: >>>>> On 13/08/2024 19:04, Arend Van Spriel wrote: >>>>>> On August 13, 2024 10:20:24 AM Jacobe Zang wrote: >>>>>> >>>>>>> It's the device id used by AP6275P which is the Wi-Fi module >>>>>>> used by Rockchip's RK3588 evaluation board and also used in >>>>>>> some other RK3588 boards. >>>>>> >>>>>> Hi Kalle, >>>>>> >>>>>> There probably will be a v11, but wanted to know how this series will be >>>>>> handled as it involves device tree bindings, arm arch device tree spec, and >>>>>> brcmfmac driver code. Can it all go through wireless-next? >>>>> >>>>> No, DTS must not go via wireless-next. Please split it from the series >>>>> and provide lore link in changelog for bindings. >>>> >>>> Hi Krzysztof, >>>> >>>> Is it really important how the patches travel upstream to Linus. This >>>> binding is specific to Broadcom wifi devices so there are no >>>> dependencies(?). To clarify what you are asking I assume two separate >>>> series: >>>> >>>> 1) DT binding + Khadas Edge2 DTS -> devicetree@vger.kernel.org >>>> reference to: >>>> https://patch.msgid.link/20240813082007.2625841-1-jacobe.zang@wesion.com >>>> >>>> 2) brcmfmac driver changes -> linux-wireless@vger.kernel.org >>> >>> No. I said only DTS is separate. This was always the rule, since forever. >>> >>> Documentation/devicetree/bindings/submitting-patches.rst >> >> I am going slightly mad (by Queen). That documents says: >> >> 1) The Documentation/ and include/dt-bindings/ portion of the patch >> should >> be a separate patch. >> >> and >> >> 4) Submit the entire series to the devicetree mailinglist at >> >> devicetree@vger.kernel.org >> >> Above I mentioned "series", not "patch". So 1) is a series of 3 patches >> (2 changes to the DT binding file and 1 patch for the Khadas Edge2 DTS. >> Is that correct? >> > > My bookmark to elixir.bootling does not work, so could not paste > specific line. Now it works, so: > > https://elixir.bootlin.com/linux/v6.11-rc3/source/Documentation/devicetree/bindings/submitting-patches.rst#L79 > > The rule was/is: > 1. Binding for typical devices always go via subsystem tree, with the > driver changes. > There can be exceptions from above, e.g. some subsystems do not pick up > bindings, so Rob does. But how patches are organized is not an exception > - it is completely normal workflow. > > 2. DTS *always* goes via SoC maintainer. DTS cannot go via any other > driver subsystem tree. There is no exception here. There cannot be an > exception, because it would mean the hardware depends on driver, which > is obviously false. In case my message was not clear: we talk here about organizing patchsets, not individual patches. If you ask about patches, then DTS, bindings and driver are all separate patches. This set already is split like that, so this was fine and I did not comment on it. Only through whom the DTS patch goes - separate tree. And just in case: this is neither specific to wireless nor to Broadcom. This is for entire Linux kernel. Best regards, Krzysztof