From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ED400C52D6F for ; Sat, 24 Aug 2024 15:53:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jCg5OorKlBAHROrYO2ZfTtcwqgG7V3PagN8azZBb/l8=; b=pFP800hQB/AYwGeLjzk3R49G9S vIjqS7zHpnXjm0bZ2y8bzud4fkhLpEZA0A9dnzgOUo0Td1/O1CEW4LC2c0qnM1TqQ0bAX3Xt0JcsN pQiP62vQvT0p8hi/k+XU1MVVzU0EW1xbBCkcLJL+HBG7q579Zv3GE9z+Vu5BvgS0GyScNvZgnazV7 O8SIk2L9ASu2oxB05nCRtGoP8V/mCaAGV6f5YZ7eYjAVM9+b+ss/TWpDvnNXWZV3Duc2aoFTP2nNG KmUfCBAY5AQTCLmLqbOmA+AUC24Wljd6tBIj0/vjVRL0ZeEIZwkN/yJnyY8z6iHG+CGBHA+BY98hl NSkY5HbA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sht4s-00000002TpL-171l; Sat, 24 Aug 2024 15:53:22 +0000 Received: from mail-ed1-x52e.google.com ([2a00:1450:4864:20::52e]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sht3a-00000002TaG-0eu6 for linux-arm-kernel@lists.infradead.org; Sat, 24 Aug 2024 15:52:04 +0000 Received: by mail-ed1-x52e.google.com with SMTP id 4fb4d7f45d1cf-5bf068aebe5so4044149a12.0 for ; Sat, 24 Aug 2024 08:52:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1724514720; x=1725119520; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jCg5OorKlBAHROrYO2ZfTtcwqgG7V3PagN8azZBb/l8=; b=geMCqdK8wHaJERCjEzNCpmALQakRQV/PSZzm9hiOPNFep6FdZuWwL9Rh7v2c64HQje vVTcGeK9d9IJ8C1flsKfOyuo8cXuUS4eWDZmt7xyYTrGqkRTuimnQb9ct0YrR0LoBq9r zwuNm4IGIFomhztAoNl5YZymN4ybjh5+cy0dG/o++dzsz+vJRrXc7pozONZJ6guopfhD nANs4ET4EbL+aIihS6uhRabkMX4p4nmoJ40ZwZ//A6L5IK/BP02pKCLnSRiQX68YTh13 gfvC08gfGcPt9R7JDmDToIIiAP8zRZp9o54OQSJdeKijID3k8ipBsP3GrPcRKSTBClby Zmpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724514720; x=1725119520; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jCg5OorKlBAHROrYO2ZfTtcwqgG7V3PagN8azZBb/l8=; b=Si3SvXDB/DFet7Gzc3Ch/HIBPcnK1aUQxpVIM4V2JoivMwdmGOPa5ZKaSb0zqrUxJk o2K6Wk8GOPFTumLJ2mEGUjmCLyX294KAejH+ejE90pRLsEcGo0RvnBJMGrSuxlLep8W0 1v/md1TK51kA4LaJ+3Ws4AipkvNyAoRfVJYiUUxYwm50S9QEcHDOWFvH9rxtzCnIzMnK o3FHFaVqNWoOC3XFPTDg1jua5LU2D7a5b5sj0JlzmFSgj65/eWHK89S+yYl7ElPOIrYY ZRDLWDlw4JCAvrJKpmLM5xKzFcE7uEQbuWSE9qbZnYttXd4S0/whoEVAk4YzV2InjAo4 fhGg== X-Forwarded-Encrypted: i=1; AJvYcCUlQre4d4QeaCODPexFcCAYLNkX9TEfxjuPmHAq6iinK5tx6lxmrG0RvH4V8zx0HtI5q8YhD9uwi3Rp6k6ycKRZ@lists.infradead.org X-Gm-Message-State: AOJu0YxS+bVARWrOaowQD3yF2u+K7CB32HF5IiBWgJUZjgdUlIylTwDC bbnf1vBG0m9uB1LuOEzmx2dc0kle3bQ926ZspHx7pPxYJ0TJnxp+NmIJOay1lbc= X-Google-Smtp-Source: AGHT+IGnvRBB5iGZS5/47q/ZS2oxbBkiapkk3Yc+2ESx8jIhguHHbIais5ImAUOFMgYiDWGTcFwQyg== X-Received: by 2002:a05:6402:280d:b0:5bf:38:f648 with SMTP id 4fb4d7f45d1cf-5c08915d123mr2731396a12.2.1724514720369; Sat, 24 Aug 2024 08:52:00 -0700 (PDT) Received: from [192.168.50.4] ([82.78.167.94]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c04a3ca4d2sm3434336a12.36.2024.08.24.08.51.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 24 Aug 2024 08:51:59 -0700 (PDT) Message-ID: Date: Sat, 24 Aug 2024 18:51:59 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 01/12] nvmem: microchip-otpc: Avoid writing a write-only register Content-Language: en-US To: Alexander Dahl Cc: Christian Melki , Srinivas Kandagatla , "moderated list:MICROCHIP OTPC DRIVER" , open list References: <20240821105943.230281-1-ada@thorsis.com> <20240821105943.230281-2-ada@thorsis.com> From: claudiu beznea In-Reply-To: <20240821105943.230281-2-ada@thorsis.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240824_085202_365470_05E265E8 X-CRM114-Status: GOOD ( 15.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, ALexander, On 21.08.2024 13:59, Alexander Dahl wrote: > The OTPC Control Register (OTPC_CR) has just write-only members. > Reading from that register leads to a warning in OTPC Write Protection > Status Register (OTPC_WPSR) in field Software Error Type (SWETYP) of > type READ_WO (A write-only register has been read (warning).) > > Just create the register write content from scratch is sufficient here. > > Signed-off-by: Alexander Dahl Maybe worth a Fixes tag here. > --- > drivers/nvmem/microchip-otpc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/nvmem/microchip-otpc.c b/drivers/nvmem/microchip-otpc.c > index 7cf81738a3e0..03e60b99f2c9 100644 > --- a/drivers/nvmem/microchip-otpc.c > +++ b/drivers/nvmem/microchip-otpc.c > @@ -82,7 +82,7 @@ static int mchp_otpc_prepare_read(struct mchp_otpc *otpc, > writel_relaxed(tmp, otpc->base + MCHP_OTPC_MR); > > /* Set read. */ > - tmp = readl_relaxed(otpc->base + MCHP_OTPC_CR); > + tmp = 0; > tmp |= MCHP_OTPC_CR_READ; > writel_relaxed(tmp, otpc->base + MCHP_OTPC_CR); writel_relaxed(MCHP_OTPC_CR_READ, otpc->base + MCHP_OTPC_CR); should be enough here. Thank you, Claudiu Beznea >