From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A78D4C433DB for ; Tue, 2 Feb 2021 23:31:20 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 60D2964E4D for ; Tue, 2 Feb 2021 23:31:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 60D2964E4D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=nddeh6oxiy0nZ/WmR+7FglzOL85/J5Gm8TWKBRuReRU=; b=xuVbHSpi1560Zy80wHBvzzOUo X2LEEwO0id1XHCIVYyzbfvsOE/UOHi3PmKIxeR/6RFG8pSlaVGaC6HiqgxTi3p7QUzpvEQagadLkP idw4DTwMyHAH6jp/EvjC/NrIVdnM7+9p8/dA2QOk2m9meccz4+cBHcLjJwZ6UAwHJyM6DRMVx3wII c2yJc7QXV61ACd552u5IYjPyiX/Tgfx/ZzxJfBgms/rDm+agdhfqtMxW96+yG5WaBAr1sKxc3gjBX xHH3as97X8QuX5ri3441OiByoWSw0HUS9ulyLCDjlUCglPWyTgRdtRnj5t/CbTPAw7T+Bl2BvbNyZ KBo+vlY9g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l757Y-0004GU-Cr; Tue, 02 Feb 2021 23:30:08 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l757V-0004Fo-My for linux-arm-kernel@lists.infradead.org; Tue, 02 Feb 2021 23:30:06 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3556631B; Tue, 2 Feb 2021 15:30:04 -0800 (PST) Received: from [10.57.35.108] (unknown [10.57.35.108]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4358D3F694; Tue, 2 Feb 2021 15:30:00 -0800 (PST) Subject: Re: [PATCH v2 6/7] perf cs-etm: Detect pid in VMID for kernel running at EL2 To: Leo Yan , Arnaldo Carvalho de Melo , Mathieu Poirier , Mike Leach , Jonathan Corbet , Alexander Shishkin , John Garry , Will Deacon , Peter Zijlstra , Ingo Molnar , Mark Rutland , Jiri Olsa , Namhyung Kim , Daniel Kiss , Denis Nikitin , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210202163842.134734-1-leo.yan@linaro.org> <20210202163842.134734-7-leo.yan@linaro.org> From: Suzuki K Poulose Message-ID: Date: Tue, 2 Feb 2021 23:29:47 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210202163842.134734-7-leo.yan@linaro.org> Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210202_183005_977837_B66A6143 X-CRM114-Status: GOOD ( 25.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Al Grant Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2/2/21 4:38 PM, Leo Yan wrote: > From: Suzuki K Poulose > > The PID of the task could be traced as VMID when the kernel is running > at EL2. Teach the decoder to look for VMID when the CONTEXTIDR (Arm32) > or CONTEXTIDR_EL1 (Arm64) is invalid but we have a valid VMID. > > Cc: Mike Leach > Cc: Mathieu Poirier > Cc: Al Grant > Co-developed-by: Leo Yan > Signed-off-by: Suzuki K Poulose > Signed-off-by: Leo Yan > --- > .../perf/util/cs-etm-decoder/cs-etm-decoder.c | 32 ++++++++++++++++--- > 1 file changed, 28 insertions(+), 4 deletions(-) > > diff --git a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c > index 3f4bc4050477..fb2a163ff74e 100644 > --- a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c > +++ b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c > @@ -6,6 +6,7 @@ > * Author: Mathieu Poirier > */ > > +#include > #include > #include > #include > @@ -491,13 +492,36 @@ cs_etm_decoder__set_tid(struct cs_etm_queue *etmq, > const ocsd_generic_trace_elem *elem, > const uint8_t trace_chan_id) > { > - pid_t tid; > + pid_t tid = -1; > + u64 pid_fmt; > + int ret; > > - /* Ignore PE_CONTEXT packets that don't have a valid contextID */ > - if (!elem->context.ctxt_id_valid) > + ret = cs_etm__get_pid_fmt(trace_chan_id, &pid_fmt); > + if (ret) Is this something we can cache in this function ? e.g, static u64 pid_fmt; if (!pid_pfmt) ret = cs_etm__get_pid_fmt(trace_chan_id, &pid_fmt); As all the ETMs will be running at the same exception level. > + return OCSD_RESP_FATAL_SYS_ERR; > + > + /* > + * Process the PE_CONTEXT packets if we have a valid contextID or VMID. > + * If the kernel is running at EL2, the PID is traced in CONTEXTIDR_EL2 > + * as VMID, Bit ETM_OPT_CTXTID2 is set in this case. > + */ > + switch (pid_fmt) { > + case BIT(ETM_OPT_CTXTID): > + if (elem->context.ctxt_id_valid) > + tid = elem->context.context_id; > + break; > + case BIT(ETM_OPT_CTXTID2) | BIT(ETM_OPT_CTXTID): I would rather fix the cs_etm__get_pid_fmt() to return either of these as commented. i.e, ETM_OPT_CTXTID or ETM_OPT_CTXTID2. Thus we don't need the this case. With the above two addressed: Reviewed-by: Suzuki K Poulose _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel