From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EEBFEC25B78 for ; Tue, 28 May 2024 12:16:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GS4wl5Hp6O9/uKYTg0rzYMiW9EKDey1bDPRM6EQDdQs=; b=hKcVmjb5w596S6 kZflpjNQveTXABETNoemUV1faekqyoF4M72udbjlSnxleZ10VSvtzp4/N/ao5h3x0kgHi04eHMdui zA7xNkwXq9GPAtx2z8LrhiLKxpCX5ItbwgXCfd8HR39pyXNS3KYSc3/VyylOgl7BdZL53bBN0mOGB nz0TPUwYZaE1wZ2bA3IpbveGJL5Xvdw8wIiWgqow/kJdj9bG6UH8fRZy6SgUZ0yV4DG+bK6zgYSG/ iskntX3IbdZY0ai/wglNyxDah+G1rSXR7r0H9KLIZHdMv2FPfvGFN4HCEhNJOVvqNiFaJ+cWmIajW lBjI9bfdAl6x7E5+p2zQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sBvkI-00000000XDv-3cBP; Tue, 28 May 2024 12:16:02 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sBvkG-00000000XDX-2Om7 for linux-arm-kernel@lists.infradead.org; Tue, 28 May 2024 12:16:01 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id C739261DA5; Tue, 28 May 2024 12:15:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 07666C3277B; Tue, 28 May 2024 12:15:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1716898559; bh=B6ImZzl1ymUfsSip34+ZJslfy/Att2gpk1uY569vkH4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=TW0193bRaPdrJP/Eacghq8tKLTCyAbhkH0PnIzfuzXwdgPrhw0j6/1E98jLtGAKc7 fXr77u70bdveNDlvhlu2+QB0+DyrR6X3mHwyYBD3/HObINsXFxAWk4VnBSPmHM0XyW ltdOI4iOvBgtdPZlLW8KyH07H+DiGIynREUI7aeLIlldyXRtu2ESWogfWdntxNKI19 ZrnMfdsNNGNzNNpfN8p2gECsV7Wfon3Mr6Xl1KNJYk/Fmih6FdG5BnIi/VmMsXEY7p i4NFCdDGT/zFyQqak3bIrPHPj44rVaQC6Hor22LvfOnqBFJPIojYpH9PVvAZATeJTz xGJ9HeBLxqoSQ== Message-ID: Date: Tue, 28 May 2024 15:15:53 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/7] arm64: dts: ti: k3-j722s-main: Redefine USB1 node description To: Siddharth Vadapalli , nm@ti.com, vigneshr@ti.com, afd@ti.com, kristo@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, u-kumar1@ti.com, danishanwar@ti.com, srk@ti.com References: <20240524090514.152727-1-s-vadapalli@ti.com> <20240524090514.152727-3-s-vadapalli@ti.com> Content-Language: en-US From: Roger Quadros In-Reply-To: <20240524090514.152727-3-s-vadapalli@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240528_051600_735257_B7F23EF6 X-CRM114-Status: GOOD ( 18.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 24/05/2024 12:05, Siddharth Vadapalli wrote: > From: Ravi Gunasekaran > > USB1 controller on J722S and AM62P are from different vendors. > Redefine the USB1 node description for J722S by deleting the > node inherited from AM62P dtsi. > > Signed-off-by: Ravi Gunasekaran > Signed-off-by: Siddharth Vadapalli > --- > v2: > https://lore.kernel.org/r/20240513114443.16350-3-r-gunasekaran@ti.com/ > No changes since v2. > > v1: > https://lore.kernel.org/r/20240429120932.11456-3-r-gunasekaran@ti.com/ > Changes since v1: > - The entire node which was added in k3-j722s.dtsi in v1 in now moved to > k3-j722s-main.dtsi as USB is a main domain peripheral. > - Used generic node names - renamed "cdns-usb@f920000" to "usb@f920000". > > arch/arm64/boot/dts/ti/k3-j722s-main.dtsi | 39 +++++++++++++++++++++++ > 1 file changed, 39 insertions(+) > > diff --git a/arch/arm64/boot/dts/ti/k3-j722s-main.dtsi b/arch/arm64/boot/dts/ti/k3-j722s-main.dtsi > index 0dac8f1e1291..b069cecebfd9 100644 > --- a/arch/arm64/boot/dts/ti/k3-j722s-main.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-j722s-main.dtsi > @@ -6,6 +6,13 @@ > > #include > > +/* > + * USB1 controller on AM62P and J722S are of different IP. > + * Delete AM62P's USBSS1 node definition and redefine it for J722S. > + */ > + > +/delete-node/ &usbss1; > + This is odd and indicates issues with current DT file inclusion. We need to split out the non common IPs (e.g. USB) out of the common k3-am62p-main.dtsi file Maybe call it k3-am62-main-common.dtsi. Only keep am62p specific stuff in k3-am62p-main.dtsi. Include k3-am62-main-common.dtsi and k3-am62p-main.dtsi for AM62P Include k3-am62-main-common.dtsi and k3-j722s-main.dtsi for J722S This way you don't need to call /delete-node/ > / { > serdes_refclk: clk-0 { > compatible = "fixed-clock"; > @@ -52,6 +59,38 @@ serdes0: serdes@f000000 { > status = "disabled"; /* Needs lane config */ > }; > }; > + > + usbss1: usb@f920000 { > + compatible = "ti,j721e-usb"; > + reg = <0x00 0x0f920000 0x00 0x100>; > + power-domains = <&k3_pds 278 TI_SCI_PD_EXCLUSIVE>; > + clocks = <&k3_clks 278 3>, <&k3_clks 278 1>; > + clock-names = "ref", "lpm"; > + assigned-clocks = <&k3_clks 278 3>; /* USB2_REFCLK */ > + assigned-clock-parents = <&k3_clks 278 4>; /* HF0SC0 */ > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; > + status = "disabled"; > + > + usb1: usb@31200000{ > + compatible = "cdns,usb3"; > + reg = <0x00 0x31200000 0x00 0x10000>, > + <0x00 0x31210000 0x00 0x10000>, > + <0x00 0x31220000 0x00 0x10000>; > + reg-names = "otg", > + "xhci", > + "dev"; > + interrupts = , /* irq.0 */ > + , /* irq.6 */ > + ; /* otgirq */ > + interrupt-names = "host", > + "peripheral", > + "otg"; > + maximum-speed = "super-speed"; > + dr_mode = "otg"; > + }; > + }; > }; > > &main_conf { -- cheers, -roger _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel