From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1519C004C9 for ; Tue, 7 May 2019 07:51:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A9BDC20989 for ; Tue, 7 May 2019 07:51:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZwcJd/Bl"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="o0JRNPqY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A9BDC20989 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:References: To:From:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WB0k2aaAbg6sDtwpe4fycZOdH42hhXg+JRYxTytT+6Y=; b=ZwcJd/BlfmkWiJgvMjFCyGznC MEMge1GE7E8t6ERcHX1ezpg4kPln/3PckarNuHCpSfMn7rjOl0MceqpT7U+NNlJYmztruzEWpUdsk ZmJrMpcaDDHmIcLWlKBckce1WT1BBOzkS+fOOK4DZCtD56xUOJpfYWBn5jiP89H/uctLHYXkmfyw/ 6EUCGPyRRFoUPVqDcRJv5diUCe5u2TGcXsoRHC1sz+oGIq/foT91uLY/jejVDysM+hfOvJRg1CORX mXi39zsnt8L4p8eWRaLDmySL5Hzr6vaYvBxV6yZutlk+kGZYwiED2PjFrTUB3949Zahebpr9XeE2h Iza1pOetQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hNusn-0007O9-HS; Tue, 07 May 2019 07:51:25 +0000 Received: from hqemgate16.nvidia.com ([216.228.121.65]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hNusk-0007Nq-Pa for linux-arm-kernel@lists.infradead.org; Tue, 07 May 2019 07:51:24 +0000 Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqemgate16.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Tue, 07 May 2019 00:51:18 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate102.nvidia.com (PGP Universal service); Tue, 07 May 2019 00:51:22 -0700 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Tue, 07 May 2019 00:51:22 -0700 Received: from [10.25.73.250] (172.20.13.39) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 7 May 2019 07:51:15 +0000 Subject: Re: [PATCH V5 02/16] PCI/PME: Export pcie_pme_disable_msi() & pcie_pme_no_msi() APIs From: Vidya Sagar To: Thierry Reding References: <20190424052004.6270-1-vidyas@nvidia.com> <20190424052004.6270-3-vidyas@nvidia.com> <20190503110159.GB32400@ulmo> X-Nvconfidentiality: public Message-ID: Date: Tue, 7 May 2019 13:21:11 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [172.20.13.39] X-ClientProxiedBy: HQMAIL106.nvidia.com (172.18.146.12) To HQMAIL101.nvidia.com (172.20.187.10) Content-Language: en-US DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1557215478; bh=9MM2Job8LFhpLfYfcy/viLo+D6a9yn3lQWyaaUwWEG4=; h=X-PGP-Universal:Subject:From:To:CC:References:X-Nvconfidentiality: Message-ID:Date:User-Agent:MIME-Version:In-Reply-To: X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=o0JRNPqYfaCtg1oCXPE4tDy0BvTxjjKUHDRoJ36ll2ac2Tqa56V4pnsNTpCF7TTgc hobKxRYWdZMQt2/V5jzADR5cC4I0TLI/gQ8FDAxNqZ02CoxGqx39N+GOflwX9hPkfD pFK3IWx2aLZmk+lMSDMqyxUHg+T7U3XXN57Z+j7bL1xxqlREQhqPVU8rhq66NVNTfi KRYakrWeVQ5M6XFvZqGg/wjSrZIhG8PcGmF/gmIVppWNcGUH6oh+taEbX4RHSHmVK3 BFrlgliw26g3JlwrbwBJfLbGA0SgVaNcu1vo8pgYGM2Kiujk9ybT3ZnRW0dBrPOxd5 VVAI5B4smOhPg== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190507_005122_840340_1507FE58 X-CRM114-Status: GOOD ( 11.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, lorenzo.pieralisi@arm.com, mperttunen@nvidia.com, mmaddireddy@nvidia.com, linux-pci@vger.kernel.org, catalin.marinas@arm.com, will.deacon@arm.com, linux-kernel@vger.kernel.org, kthota@nvidia.com, kishon@ti.com, linux-tegra@vger.kernel.org, robh+dt@kernel.org, gustavo.pimentel@synopsys.com, jingoohan1@gmail.com, bhelgaas@google.com, jonathanh@nvidia.com, linux-arm-kernel@lists.infradead.org, sagar.tv@gmail.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="windows-1252"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 5/7/2019 12:40 PM, Vidya Sagar wrote: > On 5/3/2019 4:31 PM, Thierry Reding wrote: >> On Wed, Apr 24, 2019 at 10:49:50AM +0530, Vidya Sagar wrote: >>> Export pcie_pme_disable_msi() & pcie_pme_no_msi() APIs to enable drivers >>> using this API be able to build as loadable modules. >>> >>> Signed-off-by: Vidya Sagar >>> --- >>> Changes from [v4]: >>> * None >>> >>> Changes from [v3]: >>> * None >>> >>> Changes from [v2]: >>> * Exported pcie_pme_no_msi() API after making pcie_pme_msi_disabled a s= tatic >>> >>> Changes from [v1]: >>> * This is a new patch in v2 series >>> >>> =A0 drivers/pci/pcie/pme.c=A0=A0=A0=A0 | 14 +++++++++++++- >>> =A0 drivers/pci/pcie/portdrv.h | 16 +++------------- >>> =A0 2 files changed, 16 insertions(+), 14 deletions(-) >>> >>> diff --git a/drivers/pci/pcie/pme.c b/drivers/pci/pcie/pme.c >>> index 54d593d10396..d5e0ea4a62fc 100644 >>> --- a/drivers/pci/pcie/pme.c >>> +++ b/drivers/pci/pcie/pme.c >>> @@ -25,7 +25,19 @@ >>> =A0=A0 * that using MSI for PCIe PME signaling doesn't play well with P= CIe PME-based >>> =A0=A0 * wake-up from system sleep states. >>> =A0=A0 */ >>> -bool pcie_pme_msi_disabled; >>> +static bool pcie_pme_msi_disabled; >>> + >>> +void pcie_pme_disable_msi(void) >>> +{ >>> +=A0=A0=A0 pcie_pme_msi_disabled =3D true; >>> +} >>> +EXPORT_SYMBOL_GPL(pcie_pme_disable_msi); >>> + >>> +bool pcie_pme_no_msi(void) >>> +{ >>> +=A0=A0=A0 return pcie_pme_msi_disabled; >>> +} >>> +EXPORT_SYMBOL_GPL(pcie_pme_no_msi); >>> =A0 static int __init pcie_pme_setup(char *str) >>> =A0 { >>> diff --git a/drivers/pci/pcie/portdrv.h b/drivers/pci/pcie/portdrv.h >>> index 1d50dc58ac40..7c8c3da4bd58 100644 >>> --- a/drivers/pci/pcie/portdrv.h >>> +++ b/drivers/pci/pcie/portdrv.h >>> @@ -125,22 +125,12 @@ void pcie_port_bus_unregister(void); >>> =A0 struct pci_dev; >>> =A0 #ifdef CONFIG_PCIE_PME >>> -extern bool pcie_pme_msi_disabled; >>> - >>> -static inline void pcie_pme_disable_msi(void) >>> -{ >>> -=A0=A0=A0 pcie_pme_msi_disabled =3D true; >>> -} >>> - >>> -static inline bool pcie_pme_no_msi(void) >>> -{ >>> -=A0=A0=A0 return pcie_pme_msi_disabled; >>> -} >>> - >>> +void pcie_pme_disable_msi(void); >>> +bool pcie_pme_no_msi(void); >>> =A0 void pcie_pme_interrupt_enable(struct pci_dev *dev, bool enable); >>> =A0 #else /* !CONFIG_PCIE_PME */ >>> =A0 static inline void pcie_pme_disable_msi(void) {} >>> -static inline bool pcie_pme_no_msi(void) { return false; } >>> +static inline bool pcie_pme_no_msi(void) {} >> >> This looks wrong. > Can you please give more info on what is wrong in this? Is missing "return false;" the wrong here or there is more than just this? > = >> >> Thierry >> > = _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel