From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Biao Huang <biao.huang@mediatek.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
macpaul.lin@mediatek.com
Subject: Re: [RESEND PATCH v4] arm64: dts: mt8195: Add Ethernet controller
Date: Wed, 21 Dec 2022 11:13:07 +0100 [thread overview]
Message-ID: <f591f169-acd8-d408-970b-8afc66eda8cf@collabora.com> (raw)
In-Reply-To: <20221221022523.8458-2-biao.huang@mediatek.com>
Il 21/12/22 03:25, Biao Huang ha scritto:
> Add Ethernet controller node for mt8195.
>
> Signed-off-by: Biao Huang <biao.huang@mediatek.com>
> ---
> arch/arm64/boot/dts/mediatek/mt8195-demo.dts | 88 ++++++++++++++++++++
> arch/arm64/boot/dts/mediatek/mt8195.dtsi | 86 +++++++++++++++++++
> 2 files changed, 174 insertions(+)
>
..snip..
> diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> index 5d31536f4c48..02112bbf2bdf 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> @@ -1046,6 +1046,92 @@ spis1: spi@1101e000 {
> status = "disabled";
> };
>
> + eth: ethernet@11021000 {
> + compatible = "mediatek,mt8195-gmac", "snps,dwmac-5.10a";
> + reg = <0 0x11021000 0 0x4000>;
> + interrupts = <GIC_SPI 716 IRQ_TYPE_LEVEL_HIGH 0>;
> + interrupt-names = "macirq";
> + clock-names = "axi",
> + "apb",
> + "mac_cg",
mac_cg goes as last clock, as specified in the binding.
Order: axi, apb, mac_main, ptp_ref, rmii_internal, mac_cg.
Please fix.
Regards,
Angelo
> + "mac_main",
> + "ptp_ref",
> + "rmii_internal";
> + clocks = <&pericfg_ao CLK_PERI_AO_ETHERNET>,
> + <&pericfg_ao CLK_PERI_AO_ETHERNET_BUS>,
> + <&pericfg_ao CLK_PERI_AO_ETHERNET_MAC>,
> + <&topckgen CLK_TOP_SNPS_ETH_250M>,
> + <&topckgen CLK_TOP_SNPS_ETH_62P4M_PTP>,
> + <&topckgen CLK_TOP_SNPS_ETH_50M_RMII>;
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-12-21 10:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-21 2:25 [RESEND v4 PATCH 0/1] arm64: dts: mt8195: Add Ethernet controller Biao Huang
2022-12-21 2:25 ` [RESEND PATCH v4] " Biao Huang
2022-12-21 10:13 ` AngeloGioacchino Del Regno [this message]
2022-12-22 1:43 ` Biao Huang (黄彪)
2022-12-21 13:16 ` Andrew Lunn
2022-12-22 1:56 ` Biao Huang (黄彪)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f591f169-acd8-d408-970b-8afc66eda8cf@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=biao.huang@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=macpaul.lin@mediatek.com \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).