From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5866C43381 for ; Tue, 26 Mar 2019 21:44:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 84D6A20700 for ; Tue, 26 Mar 2019 21:44:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="SbBfhBZZ"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=akkea.ca header.i=@akkea.ca header.b="i4Y+rp9h" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 84D6A20700 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=akkea.ca Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:From:Date: MIME-Version:Subject:To:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=AFtpLdvKrX+tSNQ742WuleOssn9wm0S1MOZURhLLt4k=; b=SbBfhBZZU3YZJB6BbCMrsk2Oa PA9HqJ7nQcoTu6sKCp+X8hVZb9C7FZwiNlNH9xfyA3WW9PZwNXSP6wIf+Dih9Zaqsp2cjKgquyBxw 7V0UjVOV8Wv5ucr6buJ9DBxZDueOK2D5FpLc/wXrHKilqbRWU3ksPVFYBa3ftzfhXAD7oFgSaxEeE c+wWqvpgxeU22iSUZTEXHg/YZylWL4fO4QII2OuVMZQESZHHuuUWYrjPNwfcr2XohJYkLQIHwOnvy T1DLfwq56MckMyTp0YjpG1p9FSZHKM+vosu2lL1grzb/+WSmden22GnkMVrP+Oije5VsuieSTF5BG XWrBbAcLQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8tsK-0007eG-EK; Tue, 26 Mar 2019 21:44:52 +0000 Received: from node.akkea.ca ([192.155.83.177]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8ts9-0007cj-26 for linux-arm-kernel@lists.infradead.org; Tue, 26 Mar 2019 21:44:47 +0000 Received: by node.akkea.ca (Postfix, from userid 33) id 1FA694E204B; Tue, 26 Mar 2019 21:44:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akkea.ca; s=mail; t=1553636661; bh=KKoYdTVdUXvuKq91LUmwwoE1yrvgMBNIxA7EFGxz+oA=; h=To:Subject:Date:From:Cc:In-Reply-To:References; b=i4Y+rp9hitcfdHCpnhMw4SDaTAlqNTrXR6p6LqeYWpkXy+pJWH5KSoN9WbHGd5yDS JwKzYLXSCgf/CrtiGxujqTi4lj3sDfa/VprfRDUEAgcCwZLIJ7givyuj464OvJQY7O 4wR2qZ78BdxPeHI3P5Ot1KygU3NA911VFo1Nswoo= To: Shawn Guo Subject: Re: [PATCH v6 1/4] arm64: dts: imx8mq: Add SDMA nodes X-PHP-Originating-Script: 1000:rcube.php MIME-Version: 1.0 Date: Tue, 26 Mar 2019 14:44:21 -0700 From: Angus Ainslie In-Reply-To: <20190319143139.GA24315@dragon> References: <20190308120141.3698-1-daniel.baluta@nxp.com> <20190308120141.3698-2-daniel.baluta@nxp.com> <20190319143139.GA24315@dragon> Message-ID: X-Sender: angus@akkea.ca User-Agent: Roundcube Webmail/1.1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190326_144441_112849_8BD09E2B X-CRM114-Status: GOOD ( 10.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, baruch@tkos.co.il, festevam@gmail.com, s.hauer@pengutronix.de, Abel Vesa , Anson Huang , ccaione@baylibre.com, spencercw@gmail.com, "S.j. Wang" , linux-kernel@vger.kernel.org, kuninori.morimoto.gx@renesas.com, robh+dt@kernel.org, dl-linux-imx , kernel@pengutronix.de, agx@sigxcpu.org, Daniel Baluta , Aisheng Dong , linux-arm-kernel@lists.infradead.org, l.stach@pengutronix.de Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2019-03-19 07:31, Shawn Guo wrote: > On Fri, Mar 08, 2019 at 12:02:22PM +0000, Daniel Baluta wrote: >> SDMA1 is part of AIPS-3 region and SDMA2 is part >> of AIPS-1 region. >> >> Reviewed-by: Fabio Estevam > > Reviewed-by tag should go after your SoB, since that's the sequence of > how they come. > >> Signed-off-by: Anson Huang >> [initial submit in i.MX internal tree] >> Signed-off-by: Daniel Baluta >> [adaptation for linux-next] > > I would see these notes in commit log or even just cover letter. > > Shawn > >> --- >> arch/arm64/boot/dts/freescale/imx8mq.dtsi | 22 ++++++++++++++++++++++ >> 1 file changed, 22 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi >> b/arch/arm64/boot/dts/freescale/imx8mq.dtsi >> index 9155bd4784eb..9d48450453fb 100644 >> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi >> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi >> @@ -234,6 +234,17 @@ >> status = "disabled"; >> }; >> >> + sdma2: sdma@302c0000 { >> + compatible = "fsl,imx8mq-sdma","fsl,imx7d-sdma"; >> + reg = <0x302c0000 0x10000>; >> + interrupts = ; >> + clocks = <&clk IMX8MQ_CLK_SDMA2_ROOT>, >> + <&clk IMX8MQ_CLK_SDMA2_ROOT>; >> + clock-names = "ipg", "ahb"; >> + #dma-cells = <3>; >> + fsl,sdma-ram-script-name = "imx/sdma/sdma-imx7d.bin"; >> + }; >> + >> iomuxc: iomuxc@30330000 { >> compatible = "fsl,imx8mq-iomuxc"; >> reg = <0x30330000 0x10000>; >> @@ -575,6 +586,17 @@ >> status = "disabled"; >> }; >> >> + sdma1: sdma@30bd0000 { >> + compatible = "fsl, imx8mq-sdma","fsl,imx7d-sdma"; There shouldn't be a space in the imx8mq compatible string. Angus >> + reg = <0x30bd0000 0x10000>; >> + interrupts = ; >> + clocks = <&clk IMX8MQ_CLK_SDMA1_ROOT>, >> + <&clk IMX8MQ_CLK_SDMA1_ROOT>; >> + clock-names = "ipg", "ahb"; >> + #dma-cells = <3>; >> + fsl,sdma-ram-script-name = "imx/sdma/sdma-imx7d.bin"; >> + }; >> + >> fec1: ethernet@30be0000 { >> compatible = "fsl,imx8mq-fec", "fsl,imx6sx-fec"; >> reg = <0x30be0000 0x10000>; >> -- >> 2.17.1 >> >> >> _______________________________________________ >> linux-arm-kernel mailing list >> linux-arm-kernel@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel