From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 039CFCD1283 for ; Mon, 1 Apr 2024 03:35:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bxcKWErdcIbfVIVzt4oNvJj1PiThq8nPpHe3ZvfWKL4=; b=sRUqTRggyRULNJ iDPbGZEDx9bs1Ki47RFosEcVnzaAZyqtV30KRtjO5C0JdcqdTnkAcCCUlFW3SgC27YctDd66Kkn7m 0wug/jDby9vyK2qk/upuHMcZaWmRPunFPc0YGEFml+QW4VCB3zhBPambFiR2JVuK/bH4L6Ry1S8ys rfr0UVeFSz/WiFmpsIboLuHNmqTR3xksDawPUJUy2utrqOkzfJcQMXDDfYIE5Lw5vynTH2JAR4U4g 1qQKTNSjnOs2h8K7kD5xw6na7Fja2MRbsT3ReOhVrhnynxKmIb2t3Mf+Hzj6XbxvFda+ipue+Y5HD THuMez6y/gNBoBd4zLrw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rr8Rb-00000006nhQ-2yAf; Mon, 01 Apr 2024 03:34:47 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rr8RX-00000006ngZ-3wfe; Mon, 01 Apr 2024 03:34:45 +0000 X-UUID: c2097d58efd811eeac1957ae9f99f617-20240331 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=MIME-Version:Content-Transfer-Encoding:Content-ID:Content-Type:In-Reply-To:References:Message-ID:Date:Subject:CC:To:From; bh=Whtb21+3zyjII9cnnylrL7ieDPHRI5l8dx2WAVkxkPs=; b=XP3jYYNkYFHZ9wtcUngDGWjba3PTigdjixk4HJjsAhndncVmi7g/Cx/9zxUy/TjsvgwmJ2dWXYJu3mwwsDgvLN2LALwfUUObISGmr46sJl/y6M8Nok8C3d4f0/6KOczHX5nkNSeKYgA9XS2RMIr41SoxZIBkKJF2+dr860Pb788=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.37,REQID:b639d5f0-3831-40df-b54b-f08b7c81d6c8,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:6f543d0,CLOUDID:dccfa885-8d4f-477b-89d2-1e3bdbef96d1,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:11|1,File:nil,RT:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES :1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR,TF_CID_SPAM_ULN X-UUID: c2097d58efd811eeac1957ae9f99f617-20240331 Received: from mtkmbs11n2.mediatek.inc [(172.21.101.187)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 708907997; Sun, 31 Mar 2024 20:34:34 -0700 Received: from mtkmbs10n2.mediatek.inc (172.21.101.183) by mtkmbs13n2.mediatek.inc (172.21.101.108) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Mon, 1 Apr 2024 11:34:00 +0800 Received: from SINPR02CU002.outbound.protection.outlook.com (172.21.101.237) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Mon, 1 Apr 2024 11:34:00 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RA+8dlQLKAjNlU09rJmKMRt/U50fDAnNv5Ef0zCPLC3hgWmeZKkr2sDN7GIhv/JjlaoSjEv4Wyd4Ueo21Sohjh0N58h4G95brYywNjscUBvjbjzwug5zmqogvU0CebslAcP2GYzHuXjl0Y4yOp+ep7wilwmshkAw1s1xr5elPn3TcIASHqegUsfd3nswrTJ1bweFU87j3hiYU6UyrDjg8YUfGBeenJikPPmmb0PsEbuMiGiKf3qVq1qVhXP6pXVwZrYZA3gtTx2pgPnK0tEHyaFqZcVMJdwTMIFro9W4wl1BeJU4MSLLdPHy5AU1O5lGAWUcyLFeBJb3zzUJpeLa+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Whtb21+3zyjII9cnnylrL7ieDPHRI5l8dx2WAVkxkPs=; b=TVLuiSoA6cx0hT0J3xQzOSe1ndlaTZXvzgUC8hdbI1dPwCgXJFz59BV1GWYqKk+LkW0wiDh5Lz4VQ5ECqz+iPhgdfksZumZP+GuSHNaHRlvCfgMf+Sy2VtrHxwXjpUZFt6uzgoqISANTY0a6wJDcF96mYAQfWxJdLgpzbbkykJfK92HvBZ911V0fMn8skavUucdDlBfoK1sS85sZ5AtPHM283QzlU4FQgqC7f/B9LH3FUVaIJVZGX7hT1t5ZRxrfpAXBkAIwAgrzEKwYA1tBQA2uegZogjgNwOAXkuYCEG4w/03pAwEMvKvcDUUyRHtiBqMxrH9lQr1mnWAlNYfLGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mediatek.com; dmarc=pass action=none header.from=mediatek.com; dkim=pass header.d=mediatek.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mediateko365.onmicrosoft.com; s=selector2-mediateko365-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Whtb21+3zyjII9cnnylrL7ieDPHRI5l8dx2WAVkxkPs=; b=ZqEFkxQex19PV0/RL4GidQmJnUjHYmEVx9xOIkTSciQPso3iPEBPetRjACsaHk4jWiZjkjUzlFlm0DYVLvdS1Hc9SJxxF74B9TllUQ7kesp9n2tSkraKkT78LNYm07FaFkKbdaoVgQUswvE2oCaePXsk5e0M1qTujzq3T1rMRGU= Received: from TYZPR03MB6624.apcprd03.prod.outlook.com (2603:1096:400:1f4::13) by TY0PR03MB8222.apcprd03.prod.outlook.com (2603:1096:405:16::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.39; Mon, 1 Apr 2024 03:33:57 +0000 Received: from TYZPR03MB6624.apcprd03.prod.outlook.com ([fe80::f3b6:91a7:e0fb:cb27]) by TYZPR03MB6624.apcprd03.prod.outlook.com ([fe80::f3b6:91a7:e0fb:cb27%7]) with mapi id 15.20.7409.042; Mon, 1 Apr 2024 03:33:57 +0000 From: =?utf-8?B?Q0sgSHUgKOiDoeS/iuWFiSk=?= To: "p.zabel@pengutronix.de" , "dianders@chromium.org" , "chunkuang.hu@kernel.org" CC: "linux-kernel@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , =?utf-8?B?SmFzb24tSkggTGluICjmnpfnnb/npaUp?= , "daniel@ffwll.ch" , "dri-devel@lists.freedesktop.org" , =?utf-8?B?TmF0aGFuIEx1ICjlkYLmnbHpnJYp?= , "airlied@gmail.com" , "linux-arm-kernel@lists.infradead.org" , "matthias.bgg@gmail.com" , "angelogioacchino.delregno@collabora.com" Subject: Re: [PATCH] drm/mediatek: Init `ddp_comp` with devm_kcalloc() Thread-Topic: [PATCH] drm/mediatek: Init `ddp_comp` with devm_kcalloc() Thread-Index: AQHagSxG31DVhHPs1Emb0DDHRAE1drFSyIEA Date: Mon, 1 Apr 2024 03:33:57 +0000 Message-ID: References: <20240328092248.1.I2e73c38c0f264ee2fa4a09cdd83994e37ba9f541@changeid> In-Reply-To: <20240328092248.1.I2e73c38c0f264ee2fa4a09cdd83994e37ba9f541@changeid> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYZPR03MB6624:EE_|TY0PR03MB8222:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Keml/IMm8akNTqW2QRw1g+Y1yPtGzPhahXe+trd3XRcO1Ne2aaRlpKnslwH16gjVguoTZNlGUdSe4grEhYtskYUH7Uo+fLWN3JBQ0DWdBk0+AhyBXLJh0gyYGFGYK7JPCEOGtYm119u3yjI8/OT7r1EICZCG7/LakMwcjQOneSQ6/2yPSivHK9URNrlt7W2vkjM3T2vOoJIlW5fItlh/kja6fRsMPSdLu8XaFL0lsm7K/2SdUyD2SIY7Fsp2qu/HCHqQ0XzSbx1hymH1NekXXn/EuQGG7CIj/nw1C1b0Hthbc4hpGKsetSjHBHkA75yZ6eBA86/nSsYtUvo9DwuFcl1DlCVokWjt336NGkb5/cIZzSxSx2MUkk8NukWUPswLrVDzHEVCCmdQKk5Vw7xF9cn1ABixUVGqxf3Ai5rgZo8Y3iEBvcf/bOBXBNQpK2nDLx91kTu11ZlCuSFYi5FmFGHXsebSDGxzzABidlIES6jyM3nOfvHGi+AUGCQWWxyx4HDiA3Bu9apkDeNpOpw52vYM+f26JhPARagGx0+DjndJquP0RMwuGsZOuVCAy8D8GZMsbQsauBTXzOcEqR8aDkAW//XnBbMw+C+VQ/6U4h0Iic3OLO2dHFw/t6bbKW2MlQuPO9D9JjqrKrha6ZM7dHAoTgYBgXRCYSq5WVRd+ck= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:TYZPR03MB6624.apcprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(1800799015)(366007)(7416005)(376005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?c2E5NEFtUTJKdllxNVpyMnBocTQ5WTVKb2x1dWphSE9YdWNjTytjU1VHSC9J?= =?utf-8?B?RlM2dXJmR2p4a1c3YkVuZ2hNWWtzVi90RklhYkN4QllFY0kvdjJsM1JGZTAz?= =?utf-8?B?Si84V1h3S3RRb0hmVXkzcnI4RktYYU9wTHJuRndRUDMyekJWTUZ0ZWNONmcw?= =?utf-8?B?bUVjSlBaRFF4SEwvSGhhZ2VNRmZHa0xDNTlhdnZWTXltY1FOQ3NRSkJQVU9z?= =?utf-8?B?bndGY1RvRTFMTitTeEVYeGEvT2FwMU8yM3p5TXErR0tWdndMYVl4Mlh2NmlO?= =?utf-8?B?Q3F4N2lDMERRb1ExWVh0K0w4TEV2dE05aVFNaWZTSHZ0aW8vaDRwNjRPWmI3?= =?utf-8?B?N0VLTXljKzdjZ2RSaTZMRmxkNE96QnVic3NtejBnQytCeUZaTFlabEVGSUtz?= =?utf-8?B?dE5HT1NlN0JINTZ4RDRsQkJlMURuUlA1aFZ6d0d5b0ZiZ2FsRldzQURCN0py?= =?utf-8?B?UmI3d1lJVEhsSjZQZUtqL2QzNjhaK0ZtV2RySzA4aVJ0Ry9LWmtFWkdoWSta?= =?utf-8?B?blhyVk9WK2xCTHEwNkRML2dnZVlRU1FYS2xtK1N2VkVTcDc5WnI0ZTk5NUJo?= =?utf-8?B?UytzSktBajJ0M3NOMmlUTnJjeklXeDRWME1WUzBRSGFFdG12bXdVSExLNE5L?= =?utf-8?B?VG5SaUxWazJjTVVaczhtKzVxVFB0ZHFQUlF1UzIvU21CNjdiOTM0NU1XKzlE?= =?utf-8?B?K2ttQ28xbldmRVZwNXhDTk8zRmM0N1dOL3J5eVc5NzVsUjRWSWZZdkdBVG1U?= =?utf-8?B?UXpYZXI0UTN3cXNLQU9xbnZTdnVyLyt0SDhEUm55M0tyRktQVmtGd3pCbnVs?= =?utf-8?B?TkZBN3FVL0NLZW9RMlVHbXFHWmNLZUdzZmhTd0RlWXlCKzFNL2JrNUlXclRR?= =?utf-8?B?bGtRby8waEhQMndKN3c5cFY1Y3VOU0JDdW1oY0h2MExDQ3NPUXFlbjcxTUx0?= =?utf-8?B?YitBWVFadmhySjN0U3ZQYnVGMXJ4dUpnMzRLMllHZm1FWW13NHJ3MnhNRGZI?= =?utf-8?B?ZEo5aDlYR3NRZDFEcWxPSUFNdDh2Q1FmMXF2dWJPc1NWdW1pT2ZybjRNUjJ5?= =?utf-8?B?VUgrbG41Yjk4TEFPMlBTV3VJSkJ1YjZWOGI4eWhFSEdvcEFPalBpQVlIbGtl?= =?utf-8?B?Sm5qcUlhUVRQM1E5YWVoRUxQN3Z1dFJtdW5KWCtxTjgwMFRCU2J1RzRRVGs1?= =?utf-8?B?TlZVVWFUNGJYVUNmYkV2TCtmaEYzbXhlWUZRSGJZbXhlYzVlaG5kS0pWenVa?= =?utf-8?B?SmZQRGIvNzh6US94OFdORVcydXUzenBhaXJsbkZMNzNtR0J5NzNqVTFzRmZn?= =?utf-8?B?MXhmQXYxNGEvODJhaDNDVk40a0lJSTFJM25SWFRZekVTeHpVWVFOT3BLY0xz?= =?utf-8?B?NmJkV2FOUFdGMjVHVjZSZnA3SlVoYnBZeTJJc01WYVRUZm9mV2dDM1diRysx?= =?utf-8?B?b2FQdk83ZnpMOG1wUUZlcnIweTJIN0FHdDYzNzFlTzRjYWhVMUwzQlJSMWxE?= =?utf-8?B?OEFPYnl2UFprT3NXOWtHdHVnelFaSU5xUEJicmtXL0xXbngreXJJcXdiTjlj?= =?utf-8?B?djlDZjE5R2lzUjlXTWd5MnR2OE5CQ0taQWljazlnY09WVnZ5TGlRZnI1eXVO?= =?utf-8?B?UThqZmdaQU9QdFFDWUcrV0h5Z0JNTUhWNkZ3ODRUSHlMTWNXRFhxaXQ2U0Ur?= =?utf-8?B?eGdMSTVpNCtFVUo0Qk0wMjdHUVZsdGpnbVFzbzhia3lyUlZCckhldlhEenBP?= =?utf-8?B?US9TaUdKNnZ4WjFxMXdSNkl4VkxFUDFPWU5mUXRyQ2FUSEhodDl5WVpOQ1dD?= =?utf-8?B?cHNtM0R6VFhpdDlzS2d6TzMwK2RxakFxRFZJV2JMRHBzb0FYOUpyZ1IzSTQ1?= =?utf-8?B?eW1PVmw3OWdJSThPQnZHb2YvVVAzaUVqVGNhMVlYQS82cTduS0FYZkNITTdG?= =?utf-8?B?WERQS3dVbU5yelUvZmJEenlRTWJLTks1T3kwRkFOTmhWMll3VTM1ZWtnUjZU?= =?utf-8?B?SUJQMWt1L3JkblFFUzdhU2VwdjFUWXkvRkp5a1dKZXlFZjBydFJNcWhLTkRS?= =?utf-8?B?djZhbTQ3N2E1d29VMnBLeis2RlJlUWdtb1JVRU1ZbHBaUFlnYUVpTElYbmNm?= =?utf-8?Q?bS/zzHxjDDu+WQIKrZ+1G9a2v?= Content-ID: <422F6C01D22F3C49B012D4ED26FFA8F9@apcprd03.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYZPR03MB6624.apcprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: afe629ec-e182-4760-14ca-08dc51fc905e X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Apr 2024 03:33:57.5225 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a7687ede-7a6b-4ef6-bace-642f677fbe31 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wrA1mfgZ58ALM/aaPbeXn2U4ekUWAMZlG3yvGfynCsgTPiRMa4VSz9/IB8bniHK77VSM7+6T2a1Ma/Z224zkzg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY0PR03MB8222 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240331_203443_996871_888BE184 X-CRM114-Status: GOOD ( 29.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Douglas: On Thu, 2024-03-28 at 09:22 -0700, Douglas Anderson wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > In the case where `conn_routes` is true we allocate an extra slot in > the `ddp_comp` array but mtk_drm_crtc_create() never seemed to > initialize it in the test case I ran. For me, this caused a later > crash when we looped through the array in mtk_drm_crtc_mode_valid(). > This showed up for me when I booted with `slub_debug=FZPUA` which > poisons the memory initially. Without `slub_debug` I couldn't > reproduce, presumably because the later code handles the value being > NULL and in most cases (not guaranteed in all cases) the memory the > allocator returned started out as 0. > > It really doesn't hurt to initialize the array with devm_kcalloc() > since the array is small and the overhead of initting a handful of > elements to 0 is small. In general initting memory to zero is a safer > practice and usually it's suggested to only use the non-initting > alloc > functions if you really need to. > > Let's switch the function to use an allocation function that zeros > the > memory. For me, this avoids the crash. Reviewed-by: CK Hu > > Fixes: 01389b324c97 ("drm/mediatek: Add connector dynamic selection > capability") > Signed-off-by: Douglas Anderson > --- > I don't have a ton of experience with this driver to know if the fact > that the array item was still uninitialized when > mtk_drm_crtc_mode_valid() ran is the sign of a bug that should be > fixed. However, even if it is a bug and that bug is fixed then > zeroing > memory when we allocate is still safer. If it's a bug that this > memory > wasn't initialized then please consider this patch a bug report. ;-) > > I'll also note that I reproduced this on a downstream 6.1-based > kernel. It appears that only mt8188 uses `conn_routes` and, as far as > I can tell, mt8188 isn't supported upstream yet. > > drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > index a04499c4f9ca..29207b2756c1 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c > @@ -1009,10 +1009,10 @@ int mtk_drm_crtc_create(struct drm_device > *drm_dev, > > mtk_crtc->mmsys_dev = priv->mmsys_dev; > mtk_crtc->ddp_comp_nr = path_len; > - mtk_crtc->ddp_comp = devm_kmalloc_array(dev, > - mtk_crtc->ddp_comp_nr + > (conn_routes ? 1 : 0), > - sizeof(*mtk_crtc- > >ddp_comp), > - GFP_KERNEL); > + mtk_crtc->ddp_comp = devm_kcalloc(dev, > + mtk_crtc->ddp_comp_nr + > (conn_routes ? 1 : 0), > + sizeof(*mtk_crtc->ddp_comp), > + GFP_KERNEL); > if (!mtk_crtc->ddp_comp) > return -ENOMEM; > > -- > 2.44.0.396.g6e790dbe36-goog _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel