From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AC82C43381 for ; Tue, 5 Mar 2019 15:53:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CB62F20657 for ; Tue, 5 Mar 2019 15:53:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MZXIK0Ju"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="aMkLng9A"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="fxyTqaMG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CB62F20657 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9MDJluAfHz0wuHH0cmsylbG9LTa9TDGnV+6IZxEgOr8=; b=MZXIK0JugPUpnk gmFfok0M/HZ/0eRhwp0OcLwlST7yAx4bkIGwt/AFPVFDzJGTNE15lCuaELqb+P3RMHiHwr2uuU6xK DBrzmgL4DW2Mw8n4x14X7ScE8bGw1u4+e/qNGIkacX5fEJ08zCh9wr9FTw2iKqh4ybSgt9xM45lFb 9BZjZtoSXJlF7vxzXKWHqbvvVqQIiwoLK3gBcANZCB70ApPRetT3prDpXNRNPmF8mYvS3pX7moAkO jgokYYBE7gyApTD5+xAzw/yPRZyFs0BIuM+PI9C3KYe1ujVVTsRoL8CYB4n6DxtcMgvcOMXhXEued nlt5iKNFLxFyYML3iifQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1CNs-0006Jd-Bm; Tue, 05 Mar 2019 15:53:36 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1CNp-0006JC-2f for linux-arm-kernel@lists.infradead.org; Tue, 05 Mar 2019 15:53:34 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id C3AC56277E; Tue, 5 Mar 2019 15:53:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1551801210; bh=ST/u3tJKF6dcZuilN7fMPrllufbnDWt5TMvxekG96+k=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=aMkLng9AIfOhP1uy5CSkwmcDuLe3NyFVpHrElxhXVKZigFYpRIb3VGLGvi2tdg8bR A6x9QA6++OwiTdrRLCjpunlkR2ue7+QvJgtkhTHjMk5xbfkQARgRpwAuBc7ZhEfedH qP7J5sMj+Cjf5gmfhyiybSAt1ZP5wxLYaYUtSNGE= Received: from [10.204.79.37] (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: clingutla@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 0BA756277E; Tue, 5 Mar 2019 15:53:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1551801209; bh=ST/u3tJKF6dcZuilN7fMPrllufbnDWt5TMvxekG96+k=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=fxyTqaMGMKrvCDsgcxsFH1kCWei4fhQlw2NvFd4//6HrcNfjDse6wcLuID2l5pmP9 CW1E8UJOuFL3v9gGEms3JbhexeyLP2QMUgIW47qG1eT1RIxMUd5N7Gl9SoH0eMeAjg Hl6oq8kOqKnTYj4wR04sBand+Z4STxq+HFu5iU5k= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 0BA756277E Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=clingutla@codeaurora.org Subject: Re: [PATCH] arch_topology: Update user supplied capacity to possible cpus in cluster To: Sudeep Holla , Quentin Perret References: <1551354838-29902-1-git-send-email-clingutla@codeaurora.org> <20190228121901.GA26207@e107155-lin> <6d7eb7cc-2453-3a7b-9163-ef9a5389220f@codeaurora.org> <20190228152555.GA13165@e107155-lin> <5785fd91-3d76-78e6-f4c5-7ed07be1a14d@codeaurora.org> <20190304182138.GA7553@e107155-lin> <20190305092322.q7odi3inofnvzhre@queper01-lin> <20190305111321.GA5458@e107155-lin> <20190305112952.zux4bafbnhgnyvlh@queper01-lin> <20190305113633.GA2066@e107155-lin> From: Chandra Sekhar Lingutla Message-ID: Date: Tue, 5 Mar 2019 21:23:24 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.2 MIME-Version: 1.0 In-Reply-To: <20190305113633.GA2066@e107155-lin> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190305_075333_158555_B8A696FD X-CRM114-Status: GOOD ( 19.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: catalin.marinas@arm.com, will.deacon@arm.com, Jeremy Linton , Morten Rasmussen , dietmar.eggemann@arm.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3/5/2019 5:06 PM, Sudeep Holla wrote: > On Tue, Mar 05, 2019 at 11:29:55AM +0000, Quentin Perret wrote: >> On Tuesday 05 Mar 2019 at 11:13:21 (+0000), Sudeep Holla wrote: >> [...] >>> While I like the idea, I am afraid that linking this to cpufreq policy >>> may not be good. How will we deal with it on systems without CPUfreq ? >> >> Maybe something like this ? >> >> policy = cpufreq_cpu_get(cpu); >> if (policy) { >> for_each_cpu(i, policy->related_cpus) { >> /* Update capacity for @i*/ >> } >> cpufreq_cpu_put(policy); >> } else { >> /* Update capacity for @cpu*/ >> } >> >> I think it's OK to assume per-cpu capacities w/o CPUFreq. The only >> case where it makes sense to 'bind' the capacity of several CPUs >> together is when they're part of the same perf domain, I think. If you >> don't know what the perf domains are, then there's nothing sensible you >> can do. >> > > Makes sense. > >> And for the dependency, a large part of the arch_topology driver is >> already dependent on CPUFreq -- it registers a CPUFreq notifier on boot >> to re-scale the CPU capacities depending on the max freq of the various >> policies and so on. So the dependency is already there somehow. >> > > Sorry when I mentioned dependency, I meant absence of it needs to be > dealt with. Your suggestion looks good. > >> [...] >> >>> I think if there are no valid users of this, we *must* remove it. As I >>> have pointed out in past, giving user such access will need platform >>> knowledge. Though it's debatable topic, firmware providing this >>> information is the only correct solution IMO. >> >> Yeah, if nobody is using it then maybe we can just remove it. Or at >> least we can give it a go and if somebody complains then we can 'fix' it >> with something like my snippet above :-) >> > > Happy to Ack code removing it ;). The argument that it can't be provided > by firmware is no longer valid. We already have some dependency on DVFS > data from the firmware for this to be functional correctly. > If at all nobody uses it, making it as read-only (under debugfs) would be good ? or else we are ok to update patch with related_cpus ? > -- > Regards, > Sudeep > -- Chandrasekhar L, -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel