From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7671FCEBF96 for ; Fri, 27 Sep 2024 11:01:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DObtMepEvbntbYxpIRGYmA2PApftPcBR1DNFAq+0tiU=; b=dNYUCC+84LGV1Quu5/Y0Kcw3oO CLtjMNzXBDQ0DtkoNV87F1SY0YkuL9xJ2CBpDbHM0s2oyQNiwx1pUModp70r82MPxqNxdVBUHS0mZ FLt7oFJpczAuNuUjgKTTx7PV67god8i7enXhs/ZTtkgefmDZexU4CfKOop+ZGLhdP8Ov+ce5n+Err fncP7Y4bHY3F/7QJiDewq2jdfjbJV2OeGUbXoVfRT/SyCGpkhyKy+mmwO9XKGvqkZBsCOC88bqnVw lkBsa1YdwicNXUO8VYXmRclvqdRmrwhSTigAgo3tgCAskpz+9Z4XZSRewlCusApClGAb/oYOKd2JN 2Yox4wAw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1su8jG-0000000AuHq-1Xxo; Fri, 27 Sep 2024 11:01:42 +0000 Received: from mail-pl1-x631.google.com ([2607:f8b0:4864:20::631]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1su8h0-0000000Atv1-12lj; Fri, 27 Sep 2024 10:59:23 +0000 Received: by mail-pl1-x631.google.com with SMTP id d9443c01a7336-20b2ee7629fso1407715ad.3; Fri, 27 Sep 2024 03:59:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727434761; x=1728039561; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=DObtMepEvbntbYxpIRGYmA2PApftPcBR1DNFAq+0tiU=; b=WEiGFVCDB7BeuwPB4QMya5q40huDmQG8K7jHpBWN9oMmYDT3lWcflbT7G/3jvCgoYf 0DhkQ6kjn1axj0M/CHF64b15Ng+PaRQ8B7+MkAgnUU6H5zZRhzq1UZpJdbYP/kA31nuZ z7JWUCvyTu6e4fvoHMVuVsv/VQxz8d4soqZPsnOG4ZxBfbY0Wr0XNlaY3H+h7Ocomq7Y arLf/c3ggbkzXX2J81L/vDtWxcTg4CprBCOA49Za/PN7tWJUlwxby0/o5WRGv7KmrznH woXlL7O0zeeN3ViW7RjXOjvqFm/YA/7CNi7FgOJbr3FaY4RxfjZFNjzyONRIFJSsOhyN bBng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727434761; x=1728039561; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DObtMepEvbntbYxpIRGYmA2PApftPcBR1DNFAq+0tiU=; b=bIu41huOQ0urSBXCwa5H7rZAWu2lkqLqz6seKOjtli+oLqBYro5dTKg1/cGSK1nSQS tmxgxh4CDHiec2ZW71mfup+PJ/W4IFHbs3EDc0DW595ae46spCImI/EYZsY5GFLIkOHz ZSJGsJYuUF57luWyyAc7zszB/W2XFCdneAfbKlsscE/Z1y2G4P6+pa2Em4E9Yb5I27VD v2eHzgGIMVyULeCBx1rGhpeygOhEDFCkCo4k9/DMH/gcXeaVwRrYLsxjWBHTtNAyGzLN MOfDur6Horw7ipmwDwQ+yc4nS8KOkwDbsttCDVffYTw8lZIKCXSxsgRnhWgirJXUJGUQ /SBQ== X-Forwarded-Encrypted: i=1; AJvYcCWLuS0O0HgH0a/rJZ7DBg1KFG8S7IuZw1mAOt0EDF3+XEbu3wsfdJAjVIi0By1zpQ+SmJScegqjlTjNdqivYrE=@lists.infradead.org, AJvYcCWx+QO837rl5Ew37mbzKnREXn2l477scbwu6LeHWR5V8v7NoPdw82BdDcJwr4CCe8/vJ70JpX080MTIhUO46tNz@lists.infradead.org X-Gm-Message-State: AOJu0YweX1KQGfEaMdsX+ZtWkpfJXXe2S9+cZICGFlKNb/3MR1t97Bfn dKq0tsxINMB1kum+TIkhnld29vHz3g5B8SUWmKpYdqKZ0uPC0Y1W X-Google-Smtp-Source: AGHT+IHYLP9kUGQWnN2G8U5PQVJytgo7cazkgDwW/mKcpQ1mFG2jLNZxG0CwjnvcSkfgmE0hIzd/hQ== X-Received: by 2002:a17:903:191:b0:20b:9aa:efca with SMTP id d9443c01a7336-20b36adbadamr18954335ad.9.1727434761087; Fri, 27 Sep 2024 03:59:21 -0700 (PDT) Received: from [192.168.60.56] ([103.29.142.67]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20b37d60eb3sm11688325ad.44.2024.09.27.03.59.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Sep 2024 03:59:20 -0700 (PDT) Message-ID: Date: Fri, 27 Sep 2024 18:59:15 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] dt-bindings: phy: rockchip,inno-usb2phy: add rk3576 To: Krzysztof Kozlowski , vkoul@kernel.org, kishon@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, heiko@sntech.de Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, william.wu@rock-chips.com, tim.chen@rock-chips.com, frank.wang@rock-chips.com References: <20240926103223.29538-1-frawang.cn@gmail.com> <7944f4dd-96f0-40df-8c91-523409e3cb20@gmail.com> <4b98196a-c898-4d08-9101-31feb4e59b5c@kernel.org> <2815219e-3a20-4a5b-8573-d8a4ad2df1c9@kernel.org> Content-Language: en-US From: Frank Wang In-Reply-To: <2815219e-3a20-4a5b-8573-d8a4ad2df1c9@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240927_035922_310715_D9AA8628 X-CRM114-Status: GOOD ( 12.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Krzysztof, On 2024/9/27 17:52, Krzysztof Kozlowski wrote: > On 27/09/2024 09:59, Frank Wang wrote: >>>> -  clocks: >>>> -    maxItems: 1 >>>> +  clocks: true >>>> >>>> -  clock-names: >>>> -    const: phyclk >>>> +  clock-names: true >>> For the third time, read the code I gave you. Do you see something like >>> this there? Why doing all the time something different than existing code? >> Refer to the link you sent me that I must add minItems property for >> clocks, just like the below codes: >> >> @@ -35,7 +35,8 @@ properties: >>      const: 0 >> >>    clocks: >> -    maxItems: 1 >> +    minItems: 1 >> +    maxItems: 3 > Yes, for all variable properties, so also names. > >> That can pass dt_binding and dtb checking, however, "clocks" is the >> optional property for some old Rockchip PHYs,  I am not sure is it right >> to force set  minItems as 1 . >> If just keep maxItems, the dt_binding checking is failure. > Please specify the question you want to ask. > Please ignore my last garbled email as mailbox client issue. Q1: The "clocks" is an optional property for some old Rockchip PHYs, so set "minItems: 1" likes the below, is this a suitable setting?     clocks: -    maxItems: 1 +    minItems: 1 +    maxItems: 3 Q2: Do you want me to amend the code to like this?    clocks:     minItems: 1     maxItems: 3    clock-names:     minItems: 1     maxItems: 3 allOf: [...]   - if:       properties:         compatible:           contains:             enum:               - rockchip,px30-usb2phy               - rockchip,rk3128-usb2phy               - rockchip,rk3228-usb2phy               - rockchip,rk3308-usb2phy               - rockchip,rk3328-usb2phy               - rockchip,rk3366-usb2phy               - rockchip,rk3399-usb2phy               - rockchip,rk3568-usb2phy               - rockchip,rk3588-usb2phy               - rockchip,rv1108-usb2phy     then:       properties:         clocks:           maxItems: 1         clock-names:           const: phyclk   - if:       properties:         compatible:           contains:             enum:               - rockchip,rk3576-usb2phy     then:       properties:         clocks:           minItems: 3           maxItems: 3         clock-names:           items:             - const: phyclk             - const: aclk             - const: aclk_slv BR. Frank > Best regards, > Krzysztof >