From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Andy Yan <andyshrk@163.com>
Cc: heiko@sntech.de, krzysztof.kozlowski+dt@linaro.org,
robh+dt@kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 5/5] arm64: dts: rockchip: Add support for rk3588 based board Cool Pi CM5 EVB
Date: Mon, 11 Dec 2023 10:58:59 +0100 [thread overview]
Message-ID: <f61a9382-a2b9-44a8-a33e-4c4f8d6cae50@linaro.org> (raw)
In-Reply-To: <14ab4c8c.4fa1.18c58488bf2.Coremail.andyshrk@163.com>
On 11/12/2023 10:49, Andy Yan wrote:
>>> +
>>> + backlight: backlight {
>>> + compatible = "pwm-backlight";
>>> + power-supply = <&vcc12v_dcin>;
>>> + pwms = <&pwm2 0 25000 0>;
>>> + enable-gpios = <&gpio4 RK_PA3 GPIO_ACTIVE_HIGH>;
>>> + pinctrl-names = "default";
>>> + pinctrl-0 = <&bl_en>;
>>> + status = "okay";
>>
>> This is a friendly reminder during the review process.
>>
>> It seems my or other reviewer's previous comments were not fully
>> addressed. Maybe the feedback got lost between the quotes, maybe you
>> just forgot to apply it. Please go back to the previous discussion and
>> either implement all requested changes or keep discussing them.
>
> Yes， it seems that the comments were lost， I didn't get any comments about PATCH 5 in my V1.
> Anyway, I will check this patch again, and fix the issue I find by myself.
I don't have to repeat the same comment for every same thing to fix.
It's your task to fix all occurrences of the same issue.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2023-12-11 9:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-10 8:03 [PATCH v2 0/5] Add 2 rk3588 based boards from Cool Pi Andy Yan
2023-12-10 8:03 ` [PATCH v2 1/5] dt-bindings: vendor-prefixes: Add " Andy Yan
2023-12-10 8:04 ` [PATCH v2 2/5] dt-bindings: arm: rockchip: Add Cool Pi 4B Andy Yan
2023-12-10 11:10 ` Krzysztof Kozlowski
2023-12-10 8:05 ` [PATCH v2 3/5] arm64: dts: rockchip: Add support for rk3588s based board " Andy Yan
2023-12-10 11:13 ` Krzysztof Kozlowski
2023-12-11 7:48 ` Andy Yan
2023-12-10 8:06 ` [PATCH v2 4/5] dt-bindings: arm: rockchip: Add Cool Pi CM5 EVB Andy Yan
2023-12-10 11:11 ` Krzysztof Kozlowski
2023-12-11 7:46 ` Andy Yan
2023-12-10 8:06 ` [PATCH v2 5/5] arm64: dts: rockchip: Add support for rk3588 based board " Andy Yan
2023-12-10 11:12 ` Krzysztof Kozlowski
2023-12-11 9:49 ` Andy Yan
2023-12-11 9:58 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f61a9382-a2b9-44a8-a33e-4c4f8d6cae50@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andyshrk@163.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).