From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0F3EAEED60A for ; Thu, 12 Sep 2024 14:24:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JQcj2YDJcPOkha5AjFb9sgabfqS/mkYXHsp1WXdSRE0=; b=dzY9NEAiv+yuLaR9cMFKKn6syp HXIR6chYnBEuwwNKggsPzkq/7xd2E9iaKfddJqosn6VXUpNYG0Z6Wi2sr6xMtko9WJzHaeao//sRJ Wrv5xLFEXP0y9lY1rXmFOWd12RB2I0bpqHEmID7OW8kd1v954cwfbIm22zMWMDSjA4g1yRQYLXurT GztwO4gQSFpvg3Q8Ad5x6vU9jTLmBPCgeRCP9BF4zY8nyAYq18h6G22DC91wRqS26lGjcn1sUtDm9 uNy75xzsd539nbCZbNsXfIroe4wRDynZNPF9j5BJujT/kw5KgQae8KfIpDxQus0jQzG3F3xV4/nHp 2eTS+VCg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sokkL-0000000DKjM-3mci; Thu, 12 Sep 2024 14:24:33 +0000 Received: from out-188.mta1.migadu.com ([2001:41d0:203:375::bc]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sokjA-0000000DKXW-2NtS for linux-arm-kernel@lists.infradead.org; Thu, 12 Sep 2024 14:23:22 +0000 Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1726150991; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JQcj2YDJcPOkha5AjFb9sgabfqS/mkYXHsp1WXdSRE0=; b=Dmzhz82mKpoK7vDeWNHJ8FrrSmRqWeE4p4A2Gg7IU4qsDs5hfY+ZYc7GEvOoOQOfqMkUMX kncnb80/XNvOBRgi8lkmllfzNjB7cho4BWysXMLUfH7qP1RXO8+3J8wi6763V7vo77VvX7 l+qodB+IidCdHyBcI9NN0+g9d/sni84= Date: Thu, 12 Sep 2024 10:23:06 -0400 MIME-Version: 1.0 Subject: Re: [PATCH net] net: xilinx: axienet: Schedule NAPI in two steps To: Jakub Kicinski Cc: Radhey Shyam Pandey , "David S . Miller" , Eric Dumazet , Paolo Abeni , netdev@vger.kernel.org, Robert Hancock , linux-kernel@vger.kernel.org, Michal Simek , linux-arm-kernel@lists.infradead.org References: <20240909231904.1322387-1-sean.anderson@linux.dev> <20240910185801.42b7c17f@kernel.org> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Sean Anderson In-Reply-To: <20240910185801.42b7c17f@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240912_072321_076996_36829680 X-CRM114-Status: UNSURE ( 9.29 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/10/24 21:58, Jakub Kicinski wrote: > On Mon, 9 Sep 2024 19:19:04 -0400 Sean Anderson wrote: >> Additionally, since we are running >> in an IRQ context we can use the irqoff variant as well. > > The _irqoff variant is a bit of a minefield. It causes issues if kernel > is built with forced IRQ threading. With datacenter NICs forced > threading is never used so we look the other way. Since this is a fix > and driver is embedded I reckon we should stick to __napi_schedule(). Does it? __napi_schedule_irqoff selects between __napi_schedule and ____napi_schedule based on whether PREEMPT_RT is enabled. Is there some other way to force IRQ threading? --Sean