From mboxrd@z Thu Jan 1 00:00:00 1970 From: matthias.bgg@gmail.com (Matthias Brugger) Date: Thu, 23 Nov 2017 19:37:12 +0100 Subject: [PATCH 2/8] mfd: mtk-mmsys: Add mmsys driver In-Reply-To: <1511427867.8489.9.camel@mtksdaap41> References: <20171114214114.15793-1-mbrugger@suse.com> <20171114214114.15793-3-mbrugger@suse.com> <1511427867.8489.9.camel@mtksdaap41> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 11/23/2017 10:04 AM, CK Hu wrote: >> +static const struct of_device_id of_match_mmsys[] = { >> + { .compatible = "mediatek,mt2701-mmsys", > > Because this driver replace the original "mediatek,mt2701-mmsys" driver, > could you modify the binding document of "mediatek,mt2701-mmsys" [1]? > > [1] > https://www.kernel.org/doc/Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.txt > Well we are actually no replacing the compatible but keeping it. But yes, the documentation should be updated. Apart right now we have the definition twice. The other location is here: Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt Regards, Matthias