From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EA413C27C54 for ; Tue, 4 Jun 2024 21:35:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hHDjiBIt154a/8AxO/Q3thrtDAY5ZquggrYtcIpaHqo=; b=31yWhF3NdxS88D Tj8bI8X6t3RxYm+kXSRQKMaurew3BMyVDQGoNLJXwFpvDUfeN4+TZhkr29c1onc9WQDXLOgrG+ljI j6QICgOVEVZY4IiCapymPU8kE3ycuusW/uoMBooHXh+ZQn2nz7afFi/mM3r3grTlYXpg4dqpqFnTZ snvJlTqfHGzmNhEd4Qej5Cg3Ey8gnQ+Dx1SZLrCNI85aS3atfT2w7mEc7Enq4SQYiVDxmR5BotcjC SyVZjmrISbZX8qT1WuG60Flu9kpIYpgUTzyBKTkDNDAKDQEdahYmFIoFBIzgnUKYaq532swu2FSdD ndRixybdo9wuPLlfTXQA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sEboC-00000003s8Z-39xo; Tue, 04 Jun 2024 21:35:08 +0000 Received: from madrid.collaboradmins.com ([2a00:1098:ed:100::25]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sEbo8-00000003s7t-3ICV; Tue, 04 Jun 2024 21:35:06 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1717536900; bh=4j+xcEIW6UJVNE2Sr/TwZL1PpYm/E0XsZ43FgrExk3M=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=lR1C3lC0F22dScTwYgb/PlbrW444zV6vG6SUqY30nK1kZczq4RMlbCtCHs3KNvVZC OXriDU9xexPGxkACTS4+HrKgwgUQCRbj0za8jIGchpW/Q3wL+xGEVzhlmiMq9+O1Rr 8WnWurzV6iPf3gflmpmklD3ARSK5NRKFdy/S9MBqy3KhSoOTzAg8wZ1+zz31cljVxh NJAG6eThabGJncG5AxcJpr2fixrSdnTpCLY6Y0NRXEPliU+jOuQdcUdI0r/nCIzjPx RNREZde+ONgynJ+XqQ2Vp+WQLdTq0iiJ1guQgu6JTk6YSN8cpuspqEmlTHSKhYSK3x py6phNsJD8jeA== Received: from [100.115.223.179] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 6E8AD37810EF; Tue, 4 Jun 2024 21:34:58 +0000 (UTC) Message-ID: Date: Wed, 5 Jun 2024 00:34:57 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 13/14] drm/bridge: synopsys: Add DW HDMI QP TX controller driver To: Sam Ravnborg Cc: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Sandy Huang , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Andy Yan , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mark Yao , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, kernel@collabora.com, Alexandre ARNOUD , Luis de Arquer , Algea Cao References: <20240601-b4-rk3588-bridge-upstream-v1-0-f6203753232b@collabora.com> <20240601-b4-rk3588-bridge-upstream-v1-13-f6203753232b@collabora.com> <20240601143226.GA2003970@ravnborg.org> <59519381-2729-4839-9882-65a981a0c551@collabora.com> <20240604204110.GA84949@ravnborg.org> Content-Language: en-US From: Cristian Ciocaltea In-Reply-To: <20240604204110.GA84949@ravnborg.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240604_143505_028319_59488D00 X-CRM114-Status: GOOD ( 17.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 6/4/24 11:41 PM, Sam Ravnborg wrote: > Hi Cristian. > > On Tue, Jun 04, 2024 at 10:32:04PM +0300, Cristian Ciocaltea wrote: >> Hi Sam, >> >> On 6/1/24 5:32 PM, Sam Ravnborg wrote: >>> Hi Cristian, >>> >>> a few drive-by comments below. >>> >>> Sam >>> >>> >>>> + >>>> +static const struct drm_connector_funcs dw_hdmi_qp_connector_funcs = { >>>> + .fill_modes = drm_helper_probe_single_connector_modes, >>>> + .detect = dw_hdmi_connector_detect, >>>> + .destroy = drm_connector_cleanup, >>>> + .force = dw_hdmi_qp_connector_force, >>>> + .reset = drm_atomic_helper_connector_reset, >>>> + .atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state, >>>> + .atomic_destroy_state = drm_atomic_helper_connector_destroy_state, >>>> +}; >>>> + >>>> +static int dw_hdmi_qp_bridge_attach(struct drm_bridge *bridge, >>>> + enum drm_bridge_attach_flags flags) >>>> +{ >>>> + struct dw_hdmi *hdmi = bridge->driver_private; >>>> + >>>> + if (flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR) >>>> + return drm_bridge_attach(bridge->encoder, hdmi->next_bridge, >>>> + bridge, flags); >>>> + >>>> + return dw_hdmi_connector_create(hdmi, &dw_hdmi_qp_connector_funcs); >>>> +} >>> >>> Are there any users left that requires the display driver to create the >>> connector? >>> In other words - could this driver fail if DRM_BRIDGE_ATTACH_NO_CONNECTOR >>> is not passed and drop dw_hdmi_connector_create()? >>> >>> I did not try to verify this - just a naive question. >> >> I've just tested this and it doesn't work - dw_hdmi_connector_create() >> is still needed. > > Hmm, seems the display driver or some other bridge driver fails to > support "DRM_BRIDGE_ATTACH_NO_CONNECTOR". > what other drivers are involved? Could it be related to the glue driver (updated in the next patch) which is also responsible for setting up the encoder? > Note that my comments here should be seen as potential future > improvements, and do not block the patch from being used. Thanks for the heads up! Will try to get back to this soon and investigate. Cristian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel