From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F1C67D58D53 for ; Mon, 25 Nov 2024 14:32:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=J93E+NxLejNArO3+2VOJQf4OKPH97aM+T9JwQBih6OI=; b=mJ+O3DXL1Gy/R6QJbkwHFQ8WYp VeMK0p1gs/KFNTAz5xo4XU4B1HDExMpps8tP3eJxuYCu6w/gf/m/4wVg4hA9JEOmtOkQOV+BeAFq4 iw4vW+trwLGc2uUA6kDLqi/K7Ng8TIiDLzui/jvqpsUEuZuWtbftc8R89jjbm1b3pXq4zWQos8HzH hry+BFxJBid/fzkYSINoNz41WCdghojgFPamHIFOIzI6cRZU6ew/NdNpaqkoXn6MZofebixTyZNwg 3EC3fDdovhFzXmSYe+q2vLSXtruzYtjkPDAbcQ0tSXIFAacPVGdXAHGfOqnHDHldR7PABuBjfClxR f/g99DnA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tFa88-00000008JCK-15oR; Mon, 25 Nov 2024 14:32:00 +0000 Received: from bali.collaboradmins.com ([2a01:4f8:201:9162::2]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tFa7A-00000008J1S-1bdk; Mon, 25 Nov 2024 14:31:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1732545056; bh=Vaw2d8oop474FmniEdU/1m+YsHpuOS3//yAHGO+vuQ8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=PMpbqfx7tRj7ftNgiqW0roZHr6aM75u0vJgPaWI4eAQm+TswqxOWEGpqQzXO+IusU Wl51arWjGPupxQbWCLQBvgS4nrTD1+FkPUHF2aS9BAJCl19U7Z9T8Xbn7CrCOCOmNK Phgad/kADKL6xiTrCcamUL07P6uWWgf6RegQlgN/6CXGrmrb1pycHM84zriNYf//HX 2jdFu+RC9G5+JYdmdfAXnVNBm62kr9NYx4ErvrfTaly/MbG0JJvEq75gDGnTfL64Ad WAS/Aoq8zWyOc4lBQaBnoHsoEiJYwK4SAd+LPNHIgmOWGCVZ96ABZ5JxeEsTUsgRWo /z6N6oIY4WwiQ== Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by bali.collaboradmins.com (Postfix) with ESMTPSA id 579FF17E36AD; Mon, 25 Nov 2024 15:30:55 +0100 (CET) Message-ID: Date: Mon, 25 Nov 2024 15:30:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/7] dt-bindings: display: mediatek: Add binding for HDMIv2 DDC To: Rob Herring Cc: chunkuang.hu@kernel.org, p.zabel@pengutronix.de, airlied@gmail.com, simona@ffwll.ch, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, krzk+dt@kernel.org, conor+dt@kernel.org, matthias.bgg@gmail.com, ck.hu@mediatek.com, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@collabora.com References: <20241120124512.134278-1-angelogioacchino.delregno@collabora.com> <20241120124512.134278-2-angelogioacchino.delregno@collabora.com> <20241121210235.GA3798341-robh@kernel.org> From: AngeloGioacchino Del Regno Content-Language: en-US In-Reply-To: <20241121210235.GA3798341-robh@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241125_063100_600674_3B941671 X-CRM114-Status: GOOD ( 17.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Il 21/11/24 22:02, Rob Herring ha scritto: > On Wed, Nov 20, 2024 at 01:45:06PM +0100, AngeloGioacchino Del Regno wrote: >> Add a binding for the Display Data Channel (DDC) IP in MediaTek >> SoCs with version 2 HDMI TX IP. >> >> Signed-off-by: AngeloGioacchino Del Regno >> --- >> .../mediatek/mediatek,mt8195-hdmi-ddc.yaml | 41 +++++++++++++++++++ >> 1 file changed, 41 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,mt8195-hdmi-ddc.yaml >> >> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,mt8195-hdmi-ddc.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,mt8195-hdmi-ddc.yaml >> new file mode 100644 >> index 000000000000..d85e8ed2ffa7 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,mt8195-hdmi-ddc.yaml >> @@ -0,0 +1,41 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/display/mediatek/mediatek,mt8195-hdmi-ddc.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: MediaTek HDMI Display Data Channel (DDC) v2 >> + >> +maintainers: >> + - AngeloGioacchino Del Regno >> + - CK Hu >> + >> +properties: >> + compatible: >> + oneOf: >> + - const: mediatek,mt8195-hdmi-ddc >> + - items: >> + - const: mediatek,mt8188-hdmi-ddc >> + - const: mediatek,mt8195-hdmi-ddc >> + >> + clocks: >> + maxItems: 1 >> + >> + power-domains: >> + maxItems: 1 >> + >> +required: >> + - compatible >> + - clocks >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + hdmi { >> + hdmi_ddc: i2c { >> + compatible = "mediatek,mt8195-hdmi-ddc"; >> + clocks = <&clk26m>; > > Is this really a separate block? Doesn't really look like it. You don't > even have registers to interact with it. > MTK DDCv2, subnode of HDMI, uses registers from the iospace of its parent, so, from the HDMI controller. That one is a separate block, it's just that some of its registers are mixed inside of the register space of the HDMI controller itself... MediaTek likes to do that a lot... in this case, that is because of some hotplug detection bits (and some MCU related ones too) being shared between the DDC controller and the HDMI one, but then - apart from that - the DDC controller is the DDC controller and the HDMI one is... the HDMI one. :-) Cheers, Angelo >> + }; >> + }; >> +... >> -- >> 2.47.0 >>