Re: [PATCH] dt-bindings: reset: brcm,bcm63138-pmb: convert to yaml

From: Krzysztof Kozlowski <krzk@kernel.org>
To: Kanak Shilledar <kanakshilledar@gmail.com>
Cc: "Philipp Zabel" <p.zabel@pengutronix.de>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"William Zhang" <william.zhang@broadcom.com>,
	"Anand Gore" <anand.gore@broadcom.com>,
	"Kursad Oney" <kursad.oney@broadcom.com>,
	"Florian Fainelli" <florian.fainelli@broadcom.com>,
	"Rafał Miłecki" <rafal@milecki.pl>,
	"Broadcom internal kernel review list"
	<bcm-kernel-feedback-list@broadcom.com>,
	"Kanak Shilledar" <kanakshilledar111@protonmail.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: reset: brcm,bcm63138-pmb: convert to yaml
Date: Tue, 11 Jun 2024 10:14:12 +0200	[thread overview]
Message-ID: <f669ccf9-8a69-4d2b-a8b1-f486d97413fe@kernel.org> (raw)
In-Reply-To: <CAGLn_=u9jnKL1Y=-+d2-A6BrO7xDZJS4VHtwO=mBHnww6qOaew@mail.gmail.com>

On 11/06/2024 09:23, Kanak Shilledar wrote:
> On Tue, Jun 11, 2024 at 12:28 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> On 11/06/2024 05:53, Kanak Shilledar wrote:
>>> Convert the Broadcom BCM63138 Processor Monitor Bus to newer DT
>>> schema. Created DT schema based on the .txt file which had `compatible`,
>>> `reg` and `"#reset-cells" as required properties.
>>> Added one line description which was missing in the original .txt file.
>>> Added Philipp Zabel as the maintainer (took from MAINTAINERS file).
>>
>> One of the necessary steps EVERYTIME you make conversion of some random
>> binding is to grep. git grep. You grep for stale paths and usage of
>> compatible in DTS. Sometimes you find nothing, sometimes you would find
>> something.
>>
>> `git grep bcm63138-pmb` gives you:
>> 1. stale path which you did not fix,
>> 2. duplicated schema...
> 
> There is `brcm,bcm63138-pmb` defined in "/power/brcm,bcm-pmb.yaml" and
> "/reset/brcm,bcm63138-pmb.txt" but they both are for different purposes.

What do you mean by "different purposes"? It is the same device. You
cannot have same device with same compatible and two different bindings.
Testing also told you that: warnings.

> By stale path are you referring that I will need to convert
> "/arm/bcm/brcm,bcm63138.txt"
> to DT Schema as well?

No, I mean each wrong/stale path needs to be fixed. E.g. dropped or
updated, depending on the case.

Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel