From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41088C433EF for ; Tue, 14 Sep 2021 09:29:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EC814610A2 for ; Tue, 14 Sep 2021 09:29:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org EC814610A2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Cc:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ICmX8J/jJVBa4CZfSsOdhT7SwTsuzZVP7+uYLPs8WP4=; b=DqgHPkv/qFcn7hr/L4/DJymJVZ Ef2EfEEAIFfZhGSGc6kRE+4ulu1DCSUCVONvWpc9vyZ2GxXv48ZLm56X/d7CS54nuNmZBi1a/W9vI hYtwfa3zTzkIHv0K+mXJF0vT9eKFOl6xTxdwCYMF9L307KQYvgK1AlADceU40sN/AjS59FwUQrtO5 6EaoMiPXPVu42rgSyPgJMs/HhYnTazaQkX2Rf188/2KdIXudnMEGmKQc7eIhF3FCKjvXe/BkAm+hh xChh3s8I5fQxQKwhHZzBIV0OJ3iYn691iOaH9BoyRpYa8hqgpAJhlsivBJJpI6GbaIMvvXtwxKaGu fHoJDtWQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQ4j3-00517y-JG; Tue, 14 Sep 2021 09:27:38 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQ4ix-00516N-Ls for linux-arm-kernel@lists.infradead.org; Tue, 14 Sep 2021 09:27:33 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 532941FB; Tue, 14 Sep 2021 02:27:29 -0700 (PDT) Received: from [10.57.94.84] (unknown [10.57.94.84]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 372493F719; Tue, 14 Sep 2021 02:27:28 -0700 (PDT) Subject: Re: [PATCH v4 2/2] coresight: Update comments for removing cs_etm_find_snapshot() To: Leo Yan , Mathieu Poirier , Mike Leach , Alexander Shishkin , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20210912125748.2816606-1-leo.yan@linaro.org> <20210912125748.2816606-3-leo.yan@linaro.org> From: Suzuki K Poulose Message-ID: Date: Tue, 14 Sep 2021 10:27:26 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20210912125748.2816606-3-leo.yan@linaro.org> Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210914_022731_872047_98183153 X-CRM114-Status: GOOD ( 21.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12/09/2021 13:57, Leo Yan wrote: > Commit 2f01c200d440 ("perf cs-etm: Remove callback cs_etm_find_snapshot()") > has removed the function cs_etm_find_snapshot() from the perf tool in the > user space, now CoreSight trace directly uses the perf common function > __auxtrace_mmap__read() to calcualte the head and size for AUX trace data > in snapshot mode. > > This patch updates the comments in drivers to make them generic and not > stick to any specific function from perf tool. > > Signed-off-by: Leo Yan > --- > drivers/hwtracing/coresight/coresight-etb10.c | 5 ++--- > drivers/hwtracing/coresight/coresight-tmc-etf.c | 5 ++--- > drivers/hwtracing/coresight/coresight-tmc-etr.c | 5 ++--- > 3 files changed, 6 insertions(+), 9 deletions(-) > > diff --git a/drivers/hwtracing/coresight/coresight-etb10.c b/drivers/hwtracing/coresight/coresight-etb10.c > index f775cbee12b8..efa39820acec 100644 > --- a/drivers/hwtracing/coresight/coresight-etb10.c > +++ b/drivers/hwtracing/coresight/coresight-etb10.c > @@ -557,9 +557,8 @@ static unsigned long etb_update_buffer(struct coresight_device *csdev, > > /* > * In snapshot mode we simply increment the head by the number of byte > - * that were written. User space function cs_etm_find_snapshot() will > - * figure out how many bytes to get from the AUX buffer based on the > - * position of the head. > + * that were written. User space will figure out how many bytes to get > + * from the AUX buffer based on the position of the head. > */ > if (buf->snapshot) > handle->head += to_read; > diff --git a/drivers/hwtracing/coresight/coresight-tmc-etf.c b/drivers/hwtracing/coresight/coresight-tmc-etf.c > index cd0fb7bfba68..b416b1951d3e 100644 > --- a/drivers/hwtracing/coresight/coresight-tmc-etf.c > +++ b/drivers/hwtracing/coresight/coresight-tmc-etf.c > @@ -546,9 +546,8 @@ static unsigned long tmc_update_etf_buffer(struct coresight_device *csdev, > > /* > * In snapshot mode we simply increment the head by the number of byte > - * that were written. User space function cs_etm_find_snapshot() will > - * figure out how many bytes to get from the AUX buffer based on the > - * position of the head. > + * that were written. User space will figure out how many bytes to get > + * from the AUX buffer based on the position of the head. > */ > if (buf->snapshot) > handle->head += to_read; > diff --git a/drivers/hwtracing/coresight/coresight-tmc-etr.c b/drivers/hwtracing/coresight/coresight-tmc-etr.c > index d23c7690f29a..ce14eb83925c 100644 > --- a/drivers/hwtracing/coresight/coresight-tmc-etr.c > +++ b/drivers/hwtracing/coresight/coresight-tmc-etr.c > @@ -1573,9 +1573,8 @@ tmc_update_etr_buffer(struct coresight_device *csdev, > > /* > * In snapshot mode we simply increment the head by the number of byte > - * that were written. User space function cs_etm_find_snapshot() will > - * figure out how many bytes to get from the AUX buffer based on the > - * position of the head. > + * that were written. User space will figure out how many bytes to get > + * from the AUX buffer based on the position of the head. > */ > if (etr_perf->snapshot) > handle->head += size; > Thanks for the revised patch, I have queued both the patches. Kind regards Suzuki _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel