From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Kuldeep Singh <singh.kuldeep87k@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH 2/2] arm: dts: integrator: Update spi node properties
Date: Mon, 7 Mar 2022 22:57:40 +0100 [thread overview]
Message-ID: <f686aeeb-e033-927f-89bf-fad239ad70df@canonical.com> (raw)
In-Reply-To: <20220307205357.66322-3-singh.kuldeep87k@gmail.com>
On 07/03/2022 21:53, Kuldeep Singh wrote:
> SPI clock name for pl022 is "sspclk" and not "spiclk".
> Fix below dtc warning:
> clock-names:0: 'spiclk' is not one of ['SSPCLK', 'sspclk']
>
> Also, update node name to spi instead of ssp to enable spi bindings
> check.
>
> Signed-off-by: Kuldeep Singh <singh.kuldeep87k@gmail.com>
> ---
> arch/arm/boot/dts/integratorap-im-pd1.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/integratorap-im-pd1.dts b/arch/arm/boot/dts/integratorap-im-pd1.dts
> index d47bfb66d069..ebe938556645 100644
> --- a/arch/arm/boot/dts/integratorap-im-pd1.dts
> +++ b/arch/arm/boot/dts/integratorap-im-pd1.dts
> @@ -178,12 +178,12 @@ uart@200000 {
> clock-names = "uartclk", "apb_pclk";
> };
>
> - ssp@300000 {
> + ssp0: spi@300000 {
Is the alias used anywhere? Why adding it?
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-03-07 21:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-07 20:53 [PATCH 0/2] Arm based platforms dtc fixes for pl022 Kuldeep Singh
2022-03-07 20:53 ` [PATCH 1/2] arm: dts: realview/versatile/ste: Update spi clock name Kuldeep Singh
2022-03-08 1:14 ` Rob Herring
2022-03-08 6:33 ` Kuldeep Singh
2022-03-07 20:53 ` [PATCH 2/2] arm: dts: integrator: Update spi node properties Kuldeep Singh
2022-03-07 21:57 ` Krzysztof Kozlowski [this message]
2022-03-08 5:31 ` Kuldeep Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f686aeeb-e033-927f-89bf-fad239ad70df@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=singh.kuldeep87k@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox