From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D5EE7C83F33 for ; Mon, 4 Sep 2023 07:51:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/jKO58X5OwGzj8tQuSMUNybrTQdPG48wZsjkuqLAYPM=; b=ya6AOOiMyISrsL dChdN7xCoV8qVEwPqBprnjPPuuPz+mDvYYlR/LKiktpR7E2uyhOCkYza5j9lCyPFxnFvgzvux97xo 0GkPBcL5hIn2THNJSG9Nmype7K+fYyqSfeEqCLTtOJErQxLOJ7uZOsTyH0iiV7YjVUXyVl2HC+qBv cw2ghg5xfLwefDdzvZl+m5j7dnQF1bZIMRsDk38pXgv+Zv1ZEGKhl3keReVtkQazkRf2ZTVVuFL9e RynUAcEZXDt+vhPPbJHWtQ+J1mvS2k9BoTIwB+QaDMU2x+TmwDgYe5vIEq30NwE22gT49RR9xY/Rp OAMO7oGI5Vm+9P+5jRUQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qd4MA-003Vi2-1S; Mon, 04 Sep 2023 07:50:46 +0000 Received: from mail-ej1-x62b.google.com ([2a00:1450:4864:20::62b]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qd4M7-003VhH-0h for linux-arm-kernel@lists.infradead.org; Mon, 04 Sep 2023 07:50:44 +0000 Received: by mail-ej1-x62b.google.com with SMTP id a640c23a62f3a-99bc9e3cbf1so244357666b.0 for ; Mon, 04 Sep 2023 00:50:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693813840; x=1694418640; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7rwo1JQ07wN9AZgkdq/ZN73aYRmpPxX5x4XvDTXJBqg=; b=dnv1NiE3MbjqaX4CVlMhfjwgErtbGMpbwgcEssguDuUI18ZFnDBK78fKkWwuUY9+l+ 7sYs+O2eN7Zsjvp4I1QONI4V9vGSNZiUK7UWuOT3muxmpL9emnAIVjBFdRsE+BZGjqRI oun2iIq7WObhwNhPrrhOHR6s7ZZMROfLduqv8EhlEsaIyidBpJBv3eVxKLtSJTEoC+9I O+Qo6KK4Uwb79sO+W/5ImZ0uVWro7RJGi5BhNHuj24gFqQadmLAswaBm7ldlJ52clgPN pqMjSVOhjBkdV5Mzas77bf8arNP00EgBq8PC/3vFJyVzVwat8m2wiZ+AVrRVO54m8Zy9 mHsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693813840; x=1694418640; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7rwo1JQ07wN9AZgkdq/ZN73aYRmpPxX5x4XvDTXJBqg=; b=CMvlldtyyhDgd3c1DLK557pm9374dAqnt18YWXHW16dNpsAONpRYnG5v/xsNOKG/Qx O2XWhsP6hLDXlrGA4qHjny1Rg3hXPWGE/JyqpzKqB+PhQ+sY0ASllzXbrDFaappTyUsD pZBDzF1/oTPGi3qj+i4ybOqdea21jwyoRcrKrU41i+m3PjUKA7Fb4cx/6+jTYS3ogObG sYHMN/9SuKId47AORgN1E8UsvLPevikoq0mTFRA9nCQ/np4FQ2ovFMds8snpr4O4BzPp mvz+9C26/DRSJwMmzc/xTP1s1azYkRG2zzsTN8zY7FPmKxVdVBnxh8KnIVCP8zkI9c8h h/7g== X-Gm-Message-State: AOJu0Yz/1mjQw+j/q4JmOqLFuDmO+vgp5qcrqgVf5j1nK4Jc+EJ+48ZR VpAN0waesuS/vrQRSAJnxnZ0/g== X-Google-Smtp-Source: AGHT+IEMqpCQ0XocZ/dxGoFxB/NYSHOnxzelUaffF8qI5OwbjunnTJ/liyc30D7juKnqGjdDfxzxpQ== X-Received: by 2002:a17:907:7b9e:b0:9a1:d29c:fb6b with SMTP id ne30-20020a1709077b9e00b009a1d29cfb6bmr13395072ejc.25.1693813840320; Mon, 04 Sep 2023 00:50:40 -0700 (PDT) Received: from [192.168.69.115] ([176.187.209.227]) by smtp.gmail.com with ESMTPSA id v20-20020a1709061dd400b00982a352f078sm5750337ejh.124.2023.09.04.00.50.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Sep 2023 00:50:39 -0700 (PDT) Message-ID: Date: Mon, 4 Sep 2023 09:50:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH v4 3/3] remoteproc: zynqmp: get TCM from device-tree Content-Language: en-US To: Tanmay Shah , linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Bjorn Andersson , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Michal Simek Cc: Conor Dooley , Radhey Shyam Pandey , Ben Levinsky References: <20230829181900.2561194-1-tanmay.shah@amd.com> <20230829181900.2561194-4-tanmay.shah@amd.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <20230829181900.2561194-4-tanmay.shah@amd.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230904_005043_262448_12D8DC72 X-CRM114-Status: GOOD ( 17.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On 29/8/23 20:19, Tanmay Shah wrote: > Use new dt bindings to get TCM address and size > information. Also make sure that driver stays > compatible with previous device-tree bindings. > So, if TCM information isn't available in device-tree > for zynqmp platform, hard-coded address of TCM will > be used. > > New platforms that are compatible with this > driver must add TCM support in device-tree as per new > bindings. > > Signed-off-by: Tanmay Shah > --- > drivers/remoteproc/xlnx_r5_remoteproc.c | 279 +++++++++++++++++++----- > 1 file changed, 221 insertions(+), 58 deletions(-) > /** > @@ -75,11 +79,17 @@ struct mbox_info { > * Hardcoded TCM bank values. This will be removed once TCM bindings are > * accepted for system-dt specifications and upstreamed in linux kernel Just curious, for how long this fall back code has to be maintained? (When/how will we know we can remove it?) > */ > -static const struct mem_bank_data zynqmp_tcm_banks[] = { > - {0xffe00000UL, 0x10000UL, PD_R5_0_ATCM, "atcm0"}, /* TCM 64KB each */ > - {0xffe20000UL, 0x10000UL, PD_R5_0_BTCM, "btcm0"}, > - {0xffe90000UL, 0x10000UL, PD_R5_1_ATCM, "atcm1"}, > - {0xffeb0000UL, 0x10000UL, PD_R5_1_BTCM, "btcm1"}, > +static const struct mem_bank_data zynqmp_tcm_banks_split[] = { > + {0xffe00000, 0x0, 0x10000, PD_R5_0_ATCM, 0, "atcm0"}, /* TCM 64KB each */ > + {0xffe20000, 0x20000, 0x10000, PD_R5_0_BTCM, 0, "btcm0"}, > + {0xffe90000, 0x0, 0x10000, PD_R5_1_ATCM, 0, "atcm1"}, > + {0xffeb0000, 0x20000, 0x10000, PD_R5_1_BTCM, 0, "btcm1"}, > +}; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel