From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6558C433DB for ; Mon, 22 Mar 2021 16:55:34 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7AC6B6196C for ; Mon, 22 Mar 2021 16:55:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7AC6B6196C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gAxcXiqoOJr4WDoQx6uCC0ic2JNvggKq8aT6QiUpqOk=; b=JqtdxP8Ob9NdNOQu+C43ZtjZ0 GezTmP4LUC2vSQIk0zP/ZarAPrR9KPDPGD4KYb9q9NnHusF9h8a61NZ6ABLNDHg9OA6jdSlSj1dk0 xeldqABjHDN1tcyWk8pQWgeaoSL8Be4alsKpjGy5OmbsOKHCcyAUmZAhk3hKd6iwECjjQe9Ax6sod fdH5arLKLfRfXwQ2PyKXv38Y6BTk8dnbhGp4yY4m//LGI/YXJxpk4oiJ5AJvM/zJg+vBpZgWWuQJr zar+o3li77xx3STdcC3XeUqaF0kM0Kvhm0PDRb6NtmamEn8zZz04JNOQNUjs89dcGiBz5LNvAymIX oO6LV8WFg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lONnz-00C65o-37; Mon, 22 Mar 2021 16:53:28 +0000 Received: from foss.arm.com ([217.140.110.172]) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lONns-00C64O-SL for linux-arm-kernel@lists.infradead.org; Mon, 22 Mar 2021 16:53:23 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A56551063; Mon, 22 Mar 2021 09:53:18 -0700 (PDT) Received: from [10.57.55.187] (unknown [10.57.55.187]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4D4EF3F719; Mon, 22 Mar 2021 09:53:17 -0700 (PDT) Subject: Re: [PATCH v4 15/19] dts: bindings: Document device tree bindings for ETE To: Rob Herring Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, mathieu.poirier@linaro.org, mike.leach@linaro.org, anshuman.khandual@arm.com, leo.yan@linaro.org, devicetree@vger.kernel.org References: <20210225193543.2920532-1-suzuki.poulose@arm.com> <20210225193543.2920532-16-suzuki.poulose@arm.com> <20210306210627.GA1207387@robh.at.kernel.org> From: Suzuki K Poulose Message-ID: Date: Mon, 22 Mar 2021 16:53:15 +0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210306210627.GA1207387@robh.at.kernel.org> Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210322_165321_543571_D448FEAF X-CRM114-Status: GOOD ( 19.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Rob On 06/03/2021 21:06, Rob Herring wrote: > On Thu, Feb 25, 2021 at 07:35:39PM +0000, Suzuki K Poulose wrote: >> Document the device tree bindings for Embedded Trace Extensions. >> ETE can be connected to legacy coresight components and thus >> could optionally contain a connection graph as described by >> the CoreSight bindings. >> >> Cc: devicetree@vger.kernel.org >> Cc: Mathieu Poirier >> Cc: Mike Leach >> Cc: Rob Herring >> Signed-off-by: Suzuki K Poulose >> --- >> Changes: >> - Fix out-ports defintion >> --- >> .../devicetree/bindings/arm/ete.yaml | 71 +++++++++++++++++++ >> 1 file changed, 71 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/arm/ete.yaml >> >> diff --git a/Documentation/devicetree/bindings/arm/ete.yaml b/Documentation/devicetree/bindings/arm/ete.yaml >> new file mode 100644 >> index 000000000000..35a42d92bf97 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/arm/ete.yaml >> @@ -0,0 +1,71 @@ >> +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause >> +# Copyright 2021, Arm Ltd >> +%YAML 1.2 >> +--- >> +$id: "http://devicetree.org/schemas/arm/ete.yaml#" >> +$schema: "http://devicetree.org/meta-schemas/core.yaml#" >> + >> +title: ARM Embedded Trace Extensions >> + >> +maintainers: >> + - Suzuki K Poulose >> + - Mathieu Poirier >> + >> +description: | >> + Arm Embedded Trace Extension(ETE) is a per CPU trace component that >> + allows tracing the CPU execution. It overlaps with the CoreSight ETMv4 >> + architecture and has extended support for future architecture changes. >> + The trace generated by the ETE could be stored via legacy CoreSight >> + components (e.g, TMC-ETR) or other means (e.g, using a per CPU buffer >> + Arm Trace Buffer Extension (TRBE)). Since the ETE can be connected to >> + legacy CoreSight components, a node must be listed per instance, along >> + with any optional connection graph as per the coresight bindings. >> + See bindings/arm/coresight.txt. >> + >> +properties: >> + $nodename: >> + pattern: "^ete([0-9a-f]+)$" >> + compatible: >> + items: >> + - const: arm,embedded-trace-extension >> + >> + cpu: >> + description: | >> + Handle to the cpu this ETE is bound to. >> + $ref: /schemas/types.yaml#/definitions/phandle >> + >> + out-ports: >> + description: | >> + Output connections from the ETE to legacy CoreSight trace bus. >> + $ref: /schemas/graph.yaml#/properties/port > > s/port/ports/ Ok. > > And then you need: > > properties: > port: > description: what this port is > $ref: /schemas/graph.yaml#/properties/port Isn't this already covered by the definition of ports ? There are no fixed connections for ETE. It is optional and could be connected to any legacy CoreSight component. i.e, a "ports" object can have port objects inside. Given we have defined out-ports as an object "confirming to the ports" do we need to describe the individual port nodes ? Cheers Suzuki _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel