From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Mateusz Majewski <m.majewski2@samsung.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH v2] ARM: dts: exynos: enable polling in Exynos 4210
Date: Thu, 14 Sep 2023 10:03:32 +0200 [thread overview]
Message-ID: <f69b4727-679f-7874-2d0e-137d17e5841f@linaro.org> (raw)
In-Reply-To: <e30a38fd-ea70-d5de-795f-9c8ea3177ac4@linaro.org>
On 14/09/2023 10:01, Krzysztof Kozlowski wrote:
> On 11/09/2023 15:34, Mateusz Majewski wrote:
>> It seems that thermal in Exynos 4210 is broken without this, as it will
>> never decrease cooling after increasing it.
>>
>> Signed-off-by: Mateusz Majewski <m.majewski2@samsung.com>
>> ---
>> v1 -> v2: Just uploaded separately from all the thermal: exynos:
>> patches with a shorter recipient list, no change otherwise.
>>
>> arch/arm/boot/dts/samsung/exynos4210.dtsi | 10 ++++++++--
>> 1 file changed, 8 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/samsung/exynos4210.dtsi b/arch/arm/boot/dts/samsung/exynos4210.dtsi
>> index 0e27c3375e2e..aae185b7f91c 100644
>> --- a/arch/arm/boot/dts/samsung/exynos4210.dtsi
>> +++ b/arch/arm/boot/dts/samsung/exynos4210.dtsi
>> @@ -391,8 +391,14 @@ &cpu_alert2 {
>> };
>>
>> &cpu_thermal {
>> - polling-delay-passive = <0>;
>> - polling-delay = <0>;
>> + /* Exynos 4210 supports thermal interrupts, but only for the rising threshold.
>
> This is a friendly reminder during the review process.
>
> It seems my previous comments were not fully addressed. Maybe my
> feedback got lost between the quotes, maybe you just forgot to apply it.
> Please go back to the previous discussion and either implement all
> requested changes or keep discussing them.
>
> I fixed it up and applied.
>
BTW, line wrapping was also not correct :/ Please follow coding style -
it is still 80, unless exception makes things readable. There is no need
for exception here.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-09-14 8:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230911133431eucas1p2631e7060cecb0914933ed45b837cf8eb@eucas1p2.samsung.com>
2023-09-11 13:34 ` [PATCH v2] ARM: dts: exynos: enable polling in Exynos 4210 Mateusz Majewski
2023-09-14 8:01 ` Krzysztof Kozlowski
2023-09-14 8:03 ` Krzysztof Kozlowski [this message]
2023-09-14 8:10 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f69b4727-679f-7874-2d0e-137d17e5841f@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.majewski2@samsung.com \
--cc=m.szyprowski@samsung.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox