From: Dmitry Osipenko <digetx@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Rob Herring <robh+dt@kernel.org>,
Lukasz Luba <lukasz.luba@arm.com>,
Alim Akhtar <alim.akhtar@samsung.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 7/8] memory: of: parse max-freq property
Date: Sun, 6 Feb 2022 18:33:48 +0300 [thread overview]
Message-ID: <f6af1977-51d5-527d-669f-d71cd0fcb64f@gmail.com> (raw)
In-Reply-To: <20220206135807.211767-8-krzysztof.kozlowski@canonical.com>
06.02.2022 16:58, Krzysztof Kozlowski пишет:
> Passing the memory timings maximum frequency as an unit address was
> a workaround and instead 'max-freq' is preferred. Look for 'max-freq'
> first and then fallback to 'reg'.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
> drivers/memory/of_memory.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/memory/of_memory.c b/drivers/memory/of_memory.c
> index b94408954d85..bac5c7f34936 100644
> --- a/drivers/memory/of_memory.c
> +++ b/drivers/memory/of_memory.c
> @@ -212,8 +212,10 @@ static int of_lpddr3_do_get_timings(struct device_node *np,
> {
> int ret;
>
> - /* The 'reg' param required since DT has changed, used as 'max-freq' */
> - ret = of_property_read_u32(np, "reg", &tim->max_freq);
> + ret = of_property_read_u32(np, "max-freq", &tim->max_freq);
> + if (ret)
> + /* Deprecated way of passing max-freq as 'reg' */
> + ret = of_property_read_u32(np, "reg", &tim->max_freq);
> ret |= of_property_read_u32(np, "min-freq", &tim->min_freq);
> ret |= of_property_read_u32(np, "tRFC", &tim->tRFC);
> ret |= of_property_read_u32(np, "tRRD", &tim->tRRD);
Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-02-06 15:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-06 13:57 [PATCH v3 0/8] dt-bindings: memory: convert to dtschema Krzysztof Kozlowski
2022-02-06 13:58 ` [PATCH v3 1/8] dt-bindings: memory: lpddr2-timings: " Krzysztof Kozlowski
2022-02-06 13:58 ` [PATCH v3 2/8] dt-bindings: memory: lpddr3-timings: " Krzysztof Kozlowski
2022-02-06 13:58 ` [PATCH v3 3/8] dt-bindings: memory: lpddr3: " Krzysztof Kozlowski
2022-02-06 15:33 ` Dmitry Osipenko
2022-02-06 13:58 ` [PATCH v3 4/8] dt-bindings: memory: lpddr3: adjust IO width to spec Krzysztof Kozlowski
2022-02-06 13:58 ` [PATCH v3 5/8] dt-bindings: memory: lpddr3: deprecate manufacturer ID Krzysztof Kozlowski
2022-02-07 4:14 ` Alim Akhtar
2022-02-07 8:56 ` Krzysztof Kozlowski
2022-02-07 11:24 ` Alim Akhtar
2022-02-06 13:58 ` [PATCH v3 6/8] dt-bindings: memory: lpddr3: deprecate passing timings frequency as unit address Krzysztof Kozlowski
2022-02-06 15:33 ` Dmitry Osipenko
2022-02-06 13:58 ` [PATCH v3 7/8] memory: of: parse max-freq property Krzysztof Kozlowski
2022-02-06 15:33 ` Dmitry Osipenko [this message]
2022-02-07 4:16 ` Alim Akhtar
2022-02-06 13:59 ` [PATCH v3 8/8] ARM: dts: exynos: remove deprecated unit address for LPDDR3 timings on Odroid Krzysztof Kozlowski
2022-02-06 15:35 ` Dmitry Osipenko
2022-04-04 17:02 ` (subset) " Krzysztof Kozlowski
2022-02-07 21:57 ` [PATCH v3 0/8] dt-bindings: memory: convert to dtschema Rob Herring
2022-02-09 14:36 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6af1977-51d5-527d-669f-d71cd0fcb64f@gmail.com \
--to=digetx@gmail.com \
--cc=alim.akhtar@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).