From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 65055EB64DD for ; Thu, 13 Jul 2023 11:24:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zR2ZsJTuIAT6IYF4TYRj5fFQF0GI/m6xTzvdVQSMMac=; b=lE6imMAMOjIv8t +1TnoCmVD9rl1jhXAUY70Lqn52POiytMOfdtbn1CnPtbfOh6JOBhi4MpOOgSR2UiPa4VWWk0qONi/ brQj7lHAC6Qzjf7Gfe8/RAOQIN1HhT9NDP/7lTjs3NWQhWEWCIc4xro1nq/KzMyE4jMxYjOUaKE7y b8RDj3KpKufb8iPgszl9lXnfnqtHZKqchR6mZDPwuow5M6nChrgOducDdIh+mLThpDslkAR/yyV2h rZHdnNzB1mdvtgVOYdRuxNqi89PcFREU49EBXdxqTUb+P5tM18RB0UJcJxR7fDWHIUep5K0AlW0bN iNtrot9LVRBs08Dyikrw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qJuQA-0034ZK-2N; Thu, 13 Jul 2023 11:23:42 +0000 Received: from mail-lf1-x134.google.com ([2a00:1450:4864:20::134]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qJuQ7-0034Xx-2J for linux-arm-kernel@lists.infradead.org; Thu, 13 Jul 2023 11:23:41 +0000 Received: by mail-lf1-x134.google.com with SMTP id 2adb3069b0e04-4fb94b1423eso1052403e87.1 for ; Thu, 13 Jul 2023 04:23:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689247417; x=1691839417; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=XdA26b3TlY+qVHFXfPT1loEQBlaITbodxKS5uFmTHFI=; b=p998AEX5zIHGMjonVjUbgh8/6QXiGDq451oj4GhrOMbgxHlwnZ45wSU6N4fOY1nXCq dQ19BR1al1G1NrDLgXCflOyr7ZtXl2BquH+coP6BfC6Cr6/PGdsTeKWrvIaB25vdsonP dcPRwSM48VY60QKLAHO+hhMyD5EV//veREUy0rN2p7nJbnpyhyJ2Fq7O0wVgIISYC2Xi vh0BKVFkYFPaYpn3ffOanHRSVDw+LIGOWSZ62hw3ct6AC3mbVVUjBLr6RpGs12Y350rJ CtixOs+Q6PYq2ZJNoTkwXz054d4lePbxrRwEbiCdBw4LC91TVzhnvYwKdPIaLky4F6tB kX3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689247417; x=1691839417; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XdA26b3TlY+qVHFXfPT1loEQBlaITbodxKS5uFmTHFI=; b=GNJzL8+2r1+PzKMigj72/sc+URYdh5f9gmzmmLoi898Gx6lJZGmxWLqzM7BKRbt0rr WVAOz99dLcaSmFgWUiHZb2cXKGN31vZ+8s2Vq3VicKx2IwWPs1cyMWbh1r01K88jRyob n7kglDTNdYZMaX45iON3sK2BN6lKRqfinYRNpMR+zc/gaQDY5sNF9KbROdMKYwFQZjfs wFT0feDmQD3X230BrdERnikTt+XrcXl8+S8YDdZohQPLqrREb8RlLBkGmstfY23Pu90f fZPL9TvTfct/YB50SMRJHPd6OUDyWFa4P5tTMlecfhd6N8ZuDSHg5vnQmQTZCkbxqy1Z Jkog== X-Gm-Message-State: ABy/qLYSrHAO9Y5C6Pp1nqMxhm26m0Xxz5Qd9HOQK6GDReqATT4N1YNn b81tF/Tdy6JNHHW7PGQxswJZRQ== X-Google-Smtp-Source: APBJJlFOclpA9UTM6DzH6FOtAA8753K+Xc9Pk5yTtRuLx+RYqFXrAkPPpxbPMKd+GiA3HToh0ficQw== X-Received: by 2002:a05:6512:65:b0:4fb:c693:c73b with SMTP id i5-20020a056512006500b004fbc693c73bmr1040777lfo.64.1689247416988; Thu, 13 Jul 2023 04:23:36 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.104]) by smtp.gmail.com with ESMTPSA id w16-20020a5d6810000000b003144b50034esm7675296wru.110.2023.07.13.04.23.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Jul 2023 04:23:36 -0700 (PDT) Message-ID: Date: Thu, 13 Jul 2023 13:23:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] dt-bindings: net: xilinx_gmii2rgmii: Convert to json schema Content-Language: en-US To: Pranavi Somisetty , davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, michal.simek@amd.com, harini.katakam@amd.com Cc: git@amd.com, radhey.shyam.pandey@amd.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230713103453.24018-1-pranavi.somisetty@amd.com> From: Krzysztof Kozlowski In-Reply-To: <20230713103453.24018-1-pranavi.somisetty@amd.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230713_042339_765836_3E3AA533 X-CRM114-Status: GOOD ( 16.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 13/07/2023 12:34, Pranavi Somisetty wrote: > Convert the Xilinx GMII to RGMII Converter device tree binding > documentation to json schema. > This converter is usually used as gem <---> gmii2rgmii <---> external phy > and, it's phy-handle should point to the phandle of the external phy. > > Signed-off-by: Pranavi Somisetty ... > + > +description: > + The Gigabit Media Independent Interface (GMII) to Reduced Gigabit Media > + Independent Interface (RGMII) core provides the RGMII between RGMII-compliant > + ethernet physical media devices (PHY) and the Gigabit Ethernet controller. > + This core can be used in all three modes of operation(10/100/1000 Mb/s). > + The Management Data Input/Output (MDIO) interface is used to configure the > + speed of operation. This core can switch dynamically between the three > + different speed modes by configuring the converter register through mdio write. > + The core cannot function without an external phy connected to it. > + > +properties: > + compatible: > + const: xlnx,gmii-to-rgmii-1.0 > + > + reg: > + minimum: 0 > + maximum: 31 > + description: The ID number for the phy, usually a small integer. Drop the "usually small...", it's obvious from constraints. > + > + phy-handle: true Where is this defined? > + > +required: > + - compatible > + - reg > + - phy-handle > + > +unevaluatedProperties: false Either you miss $ref or this should be additionalProperties. I bet it's the first problem. > + > +examples: > + - | > + mdio { > + #address-cells = <1>; > + #size-cells = <0>; > + phy: ethernet-phy@0 { > + reg = <0>; > + }; Drop this node, quite obvious. > + gmiitorgmii@8 { > + compatible = "xlnx,gmii-to-rgmii-1.0"; > + reg = <8>; > + phy-handle = <&phy>; > + }; > + }; Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel