From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E591C433F5 for ; Sat, 18 Sep 2021 20:52:41 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4F6AD61004 for ; Sat, 18 Sep 2021 20:52:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4F6AD61004 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=omp.ru Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:CC:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=z0S469dkvaTVePO+vQImZXG9KXb3Xqgr48mPY/Fz2cY=; b=gzU57uUJC/eRd6mXZ3WJvYcSrO iotKDt4NztCOgNRzzTe2WSDfCUwhC+chelpjNZLn8dvWXiHJlshXPmiOOEqciWl5nLZutx187yAMF i8GnScdWW1nE2qW9uH/V/0dCnq8dXzgsKTvyWM14wO+u6YNANDhX7cclZ28gHTDvBoSSwFYxy6xzT ifwf4Bulv8yDOY7lGiNMbzY+nfYjnsuDlTgzhDW9wmHc1vDYOCYtaum9dtAMeQxzGKf7bmK+4smPr ZvPDTbPP1WEuVm0utUFdNX9BbJZu9NXbWtbqE6c4QEdooKC7w0JJP/1nkbwQtw2FDn2R+y2057c6S NosLPFeg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mRhHw-00GLrM-4a; Sat, 18 Sep 2021 20:50:20 +0000 Received: from mxout03.lancloud.ru ([45.84.86.113]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mRhHq-00GLqm-R9 for linux-arm-kernel@lists.infradead.org; Sat, 18 Sep 2021 20:50:17 +0000 Received: from LanCloud DKIM-Filter: OpenDKIM Filter v2.11.0 mxout03.lancloud.ru 5F83D20A7684 Received: from LanCloud Received: from LanCloud Received: from LanCloud Subject: Re: [PATCH 4/4] pata_imx: deny IRQ0 To: Fabio Estevam , Sergey Shtylyov CC: Jens Axboe , , Shawn Guo , Sascha Hauer , "Pengutronix Kernel Team" , NXP Linux Team , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" References: <2e552c36-84a5-a642-a8f0-1395f77a1a6a@omprussia.ru> From: Sergey Shtylyov Organization: Open Mobile Platform Message-ID: Date: Sat, 18 Sep 2021 23:49:54 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Originating-IP: [192.168.11.198] X-ClientProxiedBy: LFEXT01.lancloud.ru (fd00:f066::141) To LFEX1907.lancloud.ru (fd00:f066::207) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210918_135015_115809_1DC7F83D X-CRM114-Status: GOOD ( 13.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello! On 3/21/21 10:06 PM, Fabio Estevam wrote: [...] Sorry for replying this late. If I don't reply to mails right away, I tend to forget about the unreplied mails. I might have been busy with other stuff ATM too... :-) >> If platform_get_irq() returns IRQ0 (considered invalid according to Linus) > > How can platform_get_irq() return 0 on i.MX? > This driver only runs on imx31 and imx51 and in both platforms the > PATA IRQ is non-zero. Maybe this is impossible indeed -- iff someone doesn't change the kernel (or DT) on purpose (the driver wouldn't work correctly in this case as libata would ignore the driver's IRQ handler). > IMHO the current code is correct as-is. Not quite... I don't want to leave a bad example for the future driver authors. What should I change in the patch description for the patch to become acceptable for you? MBR, Sergey _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel