From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CE074C433FE for ; Tue, 8 Nov 2022 06:03:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gifHtXoclyj9ALKeD00T2dJzMTUX9Rv8k9plwm5Q/JU=; b=BOwAAhyPuRPNLv TJ55DU4naK76RZwewcsGY2dUh+KW4OM/nrk2hQOgvHWQyT+VmXPp0rVMaf60dxCjFV92I7+b5BDqd CeXJZTXJDbUT/JiAKdX90otR+09P0fj3V1u4sxdF7bgJ2aHmw0C59+gRgSSnhRo8810Bvx2SRgzCz 8AZlJHWgogJwxdbbId5kaUpn1lMaHplOBd6q0sZY6LVwFmpmCYKGYl1qT8sIXr8mhKyQfHqF5Y8Bs pXephLEHjKfOMz7xcmRb4ya0iz2J4ZcqWh5jHlMUZHvomMi6xmvnaFXyuimVmMkqq49+WPZWX/mqF a4MDG6MV52d3ZPDYJTRg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1osHgF-0031v3-NR; Tue, 08 Nov 2022 06:01:51 +0000 Received: from nbd.name ([46.4.11.11]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1osHgD-0031uR-8T; Tue, 08 Nov 2022 06:01:50 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbd.name; s=20160729; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=V+aVuxTdXdd9m/xR2Q0RVS8UnyYU09ZK74bwG6KqNE8=; b=BmR7J+Z/XxI14992OWg4fOM59J ulfRuZpB6RSzOTI7ciB7kpIFromcGNTXVQR0ukGPiDKBuRegPAWxbZxZyum5IewmO5YljJkkSeCTO li0wYOO9LFOicFc+ql6NfoCyfxDYyKZB3queWRUBhj8L0CsHRILAcmvwsGq+fY5hGLJE=; Received: from p200300daa72ee1006d973cebf3767a25.dip0.t-ipconnect.de ([2003:da:a72e:e100:6d97:3ceb:f376:7a25] helo=nf.local) by ds12 with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1osHfu-000RzP-Cj; Tue, 08 Nov 2022 07:01:30 +0100 Message-ID: Date: Tue, 8 Nov 2022 07:01:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [PATCH 05/14] net: dsa: tag_mtk: assign per-port queues Content-Language: en-US To: Vladimir Oltean Cc: netdev@vger.kernel.org, Sean Wang , Landen Chao , DENG Qingfang , Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org References: <20221107185452.90711-1-nbd@nbd.name> <20221107185452.90711-5-nbd@nbd.name> <20221107212209.4pmoctkze4m2ggbv@skbuf> From: Felix Fietkau In-Reply-To: <20221107212209.4pmoctkze4m2ggbv@skbuf> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221107_220149_404456_56BCC490 X-CRM114-Status: GOOD ( 14.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 07.11.22 22:22, Vladimir Oltean wrote: > On Mon, Nov 07, 2022 at 07:54:43PM +0100, Felix Fietkau wrote: >> Keeps traffic sent to the switch within link speed limits >> >> Signed-off-by: Felix Fietkau >> --- >> net/dsa/tag_mtk.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/net/dsa/tag_mtk.c b/net/dsa/tag_mtk.c >> index 415d8ece242a..445d6113227f 100644 >> --- a/net/dsa/tag_mtk.c >> +++ b/net/dsa/tag_mtk.c >> @@ -25,6 +25,9 @@ static struct sk_buff *mtk_tag_xmit(struct sk_buff *skb, >> u8 xmit_tpid; >> u8 *mtk_tag; >> >> + /* Reserve the first three queues for packets not passed through DSA */ >> + skb_set_queue_mapping(skb, 3 + dp->index); >> + > > Should DSA have to care about this detail, or could you rework your > mtk_select_queue() procedure to adjust the queue mapping as needed? I'm setting the queue here so that I don't have to add the extra overhead of parsing the payload in the ethernet driver. For passing the queue, I used a similar approach as tag_brcm.c and drivers/net/ethernet/broadcom/bcmsysport.c - Felix _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel