From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05D93C43381 for ; Mon, 1 Apr 2019 09:49:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C7E9320896 for ; Mon, 1 Apr 2019 09:49:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MpaFw6sQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C7E9320896 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aW81fV60CU+7zpkdjmPxu5eA1dFkEq47PgBy5mzGk+U=; b=MpaFw6sQLcBVET 6HukC1ftzoW5jfafGn/9B8SOe4EuDnQ+4R8YOb0Q+kmYpO9gkUgRJpTJpyADEHulm1rf90f7J1SpM bJMyIEFrhUcF1VJeoCzzVQfxb0yBaJmfLSINdYZ2BB/BFkL4v6Ofzaw85MKYTSqA8i6RbKk6B580J XVUMiJnBZLkrYqJGkxRyHrkPQpk6mWOysX6/Rm0DYfO1jzx1TCu+TD0Si7pNK3WkF03MH6vvF7AxJ 8bHibAG5cDWnrn7bC5ib2usQFUdaO1NmOd3tmu2iJi72Czq7qEa2XgOYuFn5CDKmaIIWWQfHnFQOl H8bmtBZiWyD6PzuDgNRg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hAtZc-0001fA-F0; Mon, 01 Apr 2019 09:49:48 +0000 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70] helo=foss.arm.com) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hAtZZ-0001en-Kp for linux-arm-kernel@lists.infradead.org; Mon, 01 Apr 2019 09:49:46 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1D158A78; Mon, 1 Apr 2019 02:49:43 -0700 (PDT) Received: from [10.1.197.45] (e112298-lin.cambridge.arm.com [10.1.197.45]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6E5653F690; Mon, 1 Apr 2019 02:49:41 -0700 (PDT) Subject: Re: [PATCH] arm64: fix wrong check of on_sdei_stack in nmi context To: Wei Li , catalin.marinas@arm.com, will.deacon@arm.com, mark.rutland@arm.com, labbott@redhat.com, alex.popov@linux.com, james.morse@arm.com References: <20190401035557.22191-1-liwei391@huawei.com> From: Julien Thierry Message-ID: Date: Mon, 1 Apr 2019 10:49:39 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20190401035557.22191-1-liwei391@huawei.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190401_024945_689734_035113B0 X-CRM114-Status: GOOD ( 17.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: huawei.libin@huawei.com, linux-arm-kernel@lists.infradead.org, guohanjun@huawei.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Wei, On 01/04/2019 04:55, Wei Li wrote: > When doing unwind_frame() in the context of pseudo nmi (need enable > CONFIG_ARM64_PSEUDO_NMI), reaching the botton of the stack (fp == 0, > pc != 0), function on_sdei_stack() will return true while the sdei acpi > table is not inited in fact. This will cause a "NULL pointer dereference" > oops when going on. > > Signed-off-by: Wei Li Thanks for catching this. The change makes sense to me. Reviewed-by: Julien Thierry > --- > arch/arm64/kernel/sdei.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm64/kernel/sdei.c b/arch/arm64/kernel/sdei.c > index 5ba4465e44f0..ea94cf8f9dc6 100644 > --- a/arch/arm64/kernel/sdei.c > +++ b/arch/arm64/kernel/sdei.c > @@ -94,6 +94,9 @@ static bool on_sdei_normal_stack(unsigned long sp, struct stack_info *info) > unsigned long low = (unsigned long)raw_cpu_read(sdei_stack_normal_ptr); > unsigned long high = low + SDEI_STACK_SIZE; > > + if (!low) > + return false; > + > if (sp < low || sp >= high) > return false; > > @@ -111,6 +114,9 @@ static bool on_sdei_critical_stack(unsigned long sp, struct stack_info *info) > unsigned long low = (unsigned long)raw_cpu_read(sdei_stack_critical_ptr); > unsigned long high = low + SDEI_STACK_SIZE; > > + if (!low) > + return false; > + > if (sp < low || sp >= high) > return false; > > -- Julien Thierry _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel