From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31DB5C43461 for ; Thu, 3 Sep 2020 21:28:49 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E5CAC206CA for ; Thu, 3 Sep 2020 21:28:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="xTXpCLtB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E5CAC206CA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:References: To:From:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gvwuPT/uwVbpy4Y9iVQ6XRCFGg2k6BZtFFwCMABpnbU=; b=xTXpCLtBHjPy9Ng9EEYwePGwm BAVP0nWbE9aN79A0UojwUJpWOvsY8sdYdFjB/5lNX+29P0LV2IphK2z4xQe+C6JTZ7r5z0H4l/QLM tvaW8XuA1e7JsgirsnBzpdpJe83oSTVRIvdp4nvfjOx2iJlbCTozx5SPX7HaYNRlE3ThOWnibwItd mWP/9EXIlbQG9E08tTKyEe2b1/XDbOm9uj8JAQSMyUJwingVHBTFARvLB3J1DQAy+6TFg060kpnJ/ Zo9mdMRIbWTr+ZFkIvSSHZUJR8VkTf6xHKwHpNQukHX8sTM3SedDJYKlGcwysk6MElrEA7SMT7lW0 G/77vaDjg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDwl9-0007o1-MZ; Thu, 03 Sep 2020 21:27:07 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDwkx-0007hf-Db for linux-arm-kernel@lists.infradead.org; Thu, 03 Sep 2020 21:26:56 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 57F6B1045; Thu, 3 Sep 2020 14:26:54 -0700 (PDT) Received: from [10.57.40.122] (unknown [10.57.40.122]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DFF2F3F68F; Thu, 3 Sep 2020 14:26:52 -0700 (PDT) Subject: Re: [PATCH] drm/komeda: Drop local dma_parms From: Robin Murphy To: james.qian.wang@arm.com, liviu.dudau@arm.com, mihail.atanassov@arm.com References: <8de297b5b916628c77b99068fb5aac1a69eed6f5.1599164796.git.robin.murphy@arm.com> Message-ID: Date: Thu, 3 Sep 2020 22:26:50 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <8de297b5b916628c77b99068fb5aac1a69eed6f5.1599164796.git.robin.murphy@arm.com> Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200903_172655_559382_16D79771 X-CRM114-Status: GOOD ( 24.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: malidp@foss.arm.com, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2020-09-03 21:36, Robin Murphy wrote: > Since commit 9495b7e92f71 ("driver core: platform: Initialize dma_parms > for platform devices"), struct platform_device already provides a > dma_parms structure, so we can save allocating another one. > > Signed-off-by: Robin Murphy > --- > > FYI, get_maintainer.pl seems to be choking on your L: entry somehow, > since it just shows " (open list:ARM KOMEDA DRM-KMS DRIVER)" without the > description or address, not sure what's up with that. > > drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 1 - > drivers/gpu/drm/arm/display/komeda/komeda_dev.h | 2 -- > 2 files changed, 3 deletions(-) > > diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c > index 1d767473ba8a..e7bb905062d9 100644 > --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c > +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c > @@ -261,7 +261,6 @@ struct komeda_dev *komeda_dev_create(struct device *dev) > goto disable_clk; > } > > - dev->dma_parms = &mdev->dma_parms; > dma_set_max_seg_size(dev, DMA_BIT_MASK(32)); Oops, I missed my "Also the DMA segment size is simply a size, not a bitmask" bit here - ideally this should be changed to UINT_MAX while we're cleaning up. Maybe that could just be fixed up when applying, but let me know if you'd like a resend. Cheers, Robin. > mdev->iommu = iommu_get_domain_for_dev(mdev->dev); > diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.h b/drivers/gpu/drm/arm/display/komeda/komeda_dev.h > index ce27f2f27c24..5b536f0cb548 100644 > --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.h > +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.h > @@ -163,8 +163,6 @@ struct komeda_dev { > struct device *dev; > /** @reg_base: the base address of komeda io space */ > u32 __iomem *reg_base; > - /** @dma_parms: the dma parameters of komeda */ > - struct device_dma_parameters dma_parms; > > /** @chip: the basic chip information */ > struct komeda_chip_info chip; > -- > 2.28.0.dirty > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel