linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: James Morse <james.morse@arm.com>
To: Gavin Shan <gshan@redhat.com>, linux-arm-kernel@lists.infradead.org
Cc: mark.rutland@arm.com, catalin.marinas@arm.com, will@kernel.org,
	shan.gavin@gmail.com, Jonathan.Cameron@huawei.com
Subject: Re: [PATCH v4 06/15] drivers/firmware/sdei: Remove duplicate check in sdei_get_conduit()
Date: Fri, 18 Sep 2020 17:12:28 +0100	[thread overview]
Message-ID: <f7706273-a0cd-cb2f-028f-cbb4dc5d8440@arm.com> (raw)
In-Reply-To: <20200730014531.310465-7-gshan@redhat.com>

Hi Gavin,

On 30/07/2020 02:45, Gavin Shan wrote:
> The following two checks are duplicate because @acpi_disabled doesn't
> depend on CONFIG_ACPI. So the duplicate check (IS_ENABLED(CONFIG_ACPI))
> can be dropped. More details is provided to keep the commit log complete:
> 
>    * @acpi_disabled is defined in arch/arm64/kernel/acpi.c when
>      CONFIG_ACPI is enabled.
>    * @acpi_disabled in defined in include/acpi.h when CONFIG_ACPI
>      is disabled.

Acked-by: James Morse <james.morse@arm.com>


Thanks,

James

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-09-18 16:14 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-30  1:45 [PATCH v4 00/15] Refactor SDEI client driver Gavin Shan
2020-07-30  1:45 ` [PATCH v4 01/15] drivers/firmware/sdei: Remove sdei_is_err() Gavin Shan
2020-07-30  1:45 ` [PATCH v4 02/15] drivers/firmware/sdei: Common block for failing path in sdei_event_create() Gavin Shan
2020-09-18 16:10   ` James Morse
2020-07-30  1:45 ` [PATCH v4 03/15] drivers/firmware/sdei: Retrieve event number from event instance Gavin Shan
2020-09-18 16:11   ` James Morse
2020-07-30  1:45 ` [PATCH v4 04/15] drivers/firmware/sdei: Avoid nested statements in sdei_init() Gavin Shan
2020-09-18 16:11   ` James Morse
2020-07-30  1:45 ` [PATCH v4 05/15] drivers/firmware/sdei: Unregister driver on error " Gavin Shan
2020-09-18 16:12   ` James Morse
2020-09-20  1:10     ` Gavin Shan
2020-07-30  1:45 ` [PATCH v4 06/15] drivers/firmware/sdei: Remove duplicate check in sdei_get_conduit() Gavin Shan
2020-09-18 16:12   ` James Morse [this message]
2020-07-30  1:45 ` [PATCH v4 07/15] drivers/firmware/sdei: Remove Drop redundant error message in sdei_probe() Gavin Shan
2020-09-18 16:12   ` James Morse
2020-07-30  1:45 ` [PATCH v4 08/15] drivers/firmware/sdei: Remove while loop in sdei_event_register() Gavin Shan
2020-09-18 16:13   ` James Morse
2020-09-20  2:18     ` Gavin Shan
2020-07-30  1:45 ` [PATCH v4 09/15] drivers/firmware/sdei: Remove while loop in sdei_event_unregister() Gavin Shan
2020-07-30  1:45 ` [PATCH v4 10/15] drivers/firmware/sdei: Cleanup on cross call function Gavin Shan
2020-09-18 16:13   ` James Morse
2020-07-30  1:45 ` [PATCH v4 11/15] drivers/firmware/sdei: Introduce sdei_do_local_call() Gavin Shan
2020-09-18 16:13   ` James Morse
2020-07-30  1:45 ` [PATCH v4 12/15] drivers/firmware/sdei: Remove _sdei_event_register() Gavin Shan
2020-09-18 16:14   ` James Morse
2020-07-30  1:45 ` [PATCH v4 13/15] drivers/firmware/sdei: Remove _sdei_event_unregister() Gavin Shan
2020-09-18 16:14   ` James Morse
2020-07-30  1:45 ` [PATCH v4 14/15] drivers/firmware/sdei: Expose struct sdei_event Gavin Shan
2020-07-30 10:54   ` Jonathan Cameron
2020-07-31  0:20     ` Gavin Shan
2020-09-18 16:15   ` James Morse
2020-09-20  2:42     ` Gavin Shan
2020-07-30  1:45 ` [PATCH v4 15/15] drivers/firmware/sdei: Identify event by " Gavin Shan
2020-07-30  8:03 ` [PATCH v4 00/15] Refactor SDEI client driver Gavin Shan
2020-08-27  6:55   ` Gavin Shan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f7706273-a0cd-cb2f-028f-cbb4dc5d8440@arm.com \
    --to=james.morse@arm.com \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=catalin.marinas@arm.com \
    --cc=gshan@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=shan.gavin@gmail.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).