From: Tim Chen <tim.c.chen@linux.intel.com>
To: Yicong Yang <yangyicong@huawei.com>,
Yicong Yang <yangyicong@hisilicon.com>,
peterz@infradead.org, mingo@redhat.com, juri.lelli@redhat.com,
vincent.guittot@linaro.org, gautham.shenoy@amd.com,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Cc: dietmar.eggemann@arm.com, rostedt@goodmis.org,
bsegall@google.com, bristot@redhat.com, prime.zeng@huawei.com,
jonathan.cameron@huawei.com, ego@linux.vnet.ibm.com,
srikar@linux.vnet.ibm.com, linuxarm@huawei.com,
21cnbao@gmail.com, guodong.xu@linaro.org,
hesham.almatary@huawei.com, john.garry@huawei.com,
shenyang39@huawei.com, Chen Yu <yu.c.chen@intel.com>
Subject: Re: [PATCH v4 2/2] sched/fair: Scan cluster before scanning LLC in wake-up path
Date: Fri, 10 Jun 2022 14:19:57 -0700 [thread overview]
Message-ID: <f7a0d098ac635c9596d739515efd4f1bc383c73e.camel@linux.intel.com> (raw)
In-Reply-To: <4ab2c422-04ae-3199-ae2a-357c3270cd05@huawei.com>
On Fri, 2022-06-10 at 14:39 +0800, Yicong Yang wrote:
>
>
> I've tested this patch with MySQL as well (like in v2). This won't hurt
> the MySQL case with SIS_PROP but observed some improvement with SIS_UTIL
> posted in [1]. We leverage the nr to suppress redundant scanning in the
> current approach and seems SIS_UTIL is more efficient in this case.
>
> 5.19-rc1 patched patched+SIS_UTIL[1]
> TPS-16threads 6215.11 6172.74 (-0.68%) 6217.33 (0.04%)
> QPS-16threads 124302.21 123454.68 (-0.68%) 124346.52 (0.04%)
> avg-lat-16threads 2.57 2.59 (-0.65%) 2.57 (0.00%)
> TPS-24threads 8726.40 8690.87 (-0.41%) 8833.08 (1.22%)
> QPS-24threads 174527.88 173817.42 (-0.41%) 176661.54 (1.21%)
> avg-lat-24threads 2.75 2.76 (-0.36%) 2.71 (1.33%)
> TPS-32threads 9555.42 9514.86 (-0.42%) 10010.87 (4.77%)
> QPS-32threads 191108.37 190297.28 (-0.42%) 200217.35 (4.55%)
> avg-lat-32threads 3.35 3.36 (-0.30%) 3.20 (4.58%)
> TPS-64threads 10290.10 10324.75 (0.34%) 10819.77 (5.15%)
> QPS-64threads 205802.05 206494.95 (0.34%) 216395.40 (4.90%)
> avg-lat-64threads 6.22 6.20 (0.38%) 5.92 (4.88%)
>
Thanks for the numbers. SIS_UTIL will keep off migrations off the cluster
that doesn't really improve overall utilization. We have higher chance that
L2 cache is warm. So it makes sense that we see a bit
better performance there.
Tim
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-10 21:21 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-09 12:06 [PATCH v4 0/2] sched/fair: Wake task within the cluster when possible Yicong Yang
2022-06-09 12:06 ` [PATCH v4 1/2] sched: Add per_cpu cluster domain info and cpus_share_resources API Yicong Yang
2022-06-09 22:28 ` Tim Chen
2022-06-10 6:54 ` Yicong Yang
2022-06-15 14:19 ` K Prateek Nayak
2022-06-15 15:43 ` Gautham R. Shenoy
2022-06-16 8:10 ` Yicong Yang
2022-06-16 7:55 ` Yicong Yang
[not found] ` <6bf4f032-7d07-d4a4-4f5a-28f3871131c0@amd.com>
2022-06-17 16:50 ` Tim Chen
2022-06-20 11:20 ` K Prateek Nayak
2022-06-20 13:37 ` Abel Wu
2022-06-28 11:55 ` K Prateek Nayak
2022-06-29 3:22 ` Yicong Yang
2022-06-09 12:06 ` [PATCH v4 2/2] sched/fair: Scan cluster before scanning LLC in wake-up path Yicong Yang
2022-06-09 22:47 ` Tim Chen
2022-06-10 4:01 ` Barry Song
2022-06-10 6:39 ` Yicong Yang
2022-06-10 21:19 ` Tim Chen [this message]
2022-06-11 3:03 ` Chen Yu
2022-06-11 7:40 ` Yicong Yang
2022-06-11 9:04 ` Chen Yu
2022-06-26 12:13 ` Abel Wu
2022-06-27 8:16 ` Yicong Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7a0d098ac635c9596d739515efd4f1bc383c73e.camel@linux.intel.com \
--to=tim.c.chen@linux.intel.com \
--cc=21cnbao@gmail.com \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=ego@linux.vnet.ibm.com \
--cc=gautham.shenoy@amd.com \
--cc=guodong.xu@linaro.org \
--cc=hesham.almatary@huawei.com \
--cc=john.garry@huawei.com \
--cc=jonathan.cameron@huawei.com \
--cc=juri.lelli@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=prime.zeng@huawei.com \
--cc=rostedt@goodmis.org \
--cc=shenyang39@huawei.com \
--cc=srikar@linux.vnet.ibm.com \
--cc=vincent.guittot@linaro.org \
--cc=yangyicong@hisilicon.com \
--cc=yangyicong@huawei.com \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).