From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AF7B4C433EF for ; Fri, 10 Jun 2022 21:21:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6oMKzRwPlq5C1C/VtND83EJlIonfavboP+6W3j9wNy0=; b=3N2ZVDLK74GTNU M7/a9SjLLWJr7xN2ACfFMVvDmzfc7gzM1U70vfj+whF7vVL1t3unooJi5UOsTIxC2orr20V4MRLqj VFabvs4F4Y36+geHRsdOo/ACXvl95z4PK3x7vy/OYic2W9SQ51bjF+pR/jw5BfW2XgKEJ1S/O8mHm krklxxp3TCB8Igui8kHnODxCKbuTQH57Xm7ARY5oCNL1ynBbcY0r9kzDUbR/dhatrvFJ6f5xy9NJz kCWM+meT4Y1FDkTmiXCPylt50pc0zI9ZB/DdLi9IpyrxiGWU7Ts5ZP8RXBCPy7FobuppXSfFfCwPH xVGK5C1xmeCrukpehNjQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nzm3F-009y1I-Dk; Fri, 10 Jun 2022 21:20:17 +0000 Received: from mga17.intel.com ([192.55.52.151]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nzm3A-009xzD-Ql for linux-arm-kernel@lists.infradead.org; Fri, 10 Jun 2022 21:20:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654896012; x=1686432012; h=message-id:subject:from:to:cc:date:in-reply-to: references:mime-version:content-transfer-encoding; bh=pqG+Qg/ylT4j8GOZY6J5PxKZ3poP9l+qi4+yhxajZUU=; b=Xkom5ebcdXiqZj0smSLtHmYsa0pgBY3PMziU9sCOhgKhiUcgZFSJQXTr ljeNR7meV+m8zJpjg8aKYJpQEooekgihxhNDDVErcMXG9thZ1enKo+Bbw JN241Qencjqdk/BMdH+rRSeq4pM0mhjHV7FEXTiG3Jgr7zLHYMFA/76tE Og0+ruROG59ybrE8xz62eDT7bLMmyDXToo9VYpJGS8JdkZsZ/mnE35F+u puISU/kyWeZ3WxqTpltaaHYjp+PAmFwP8y3JI05RZjAAXwD6WQNyYKigj 5nlbReiQqaX1XQjkJeZEkLXG4dAwUV04z2ajsKm7MLWR1zzAjCmvzYVDz Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10374"; a="258186657" X-IronPort-AV: E=Sophos;i="5.91,291,1647327600"; d="scan'208";a="258186657" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jun 2022 14:20:10 -0700 X-IronPort-AV: E=Sophos;i="5.91,291,1647327600"; d="scan'208";a="610887491" Received: from schen9-mobl.amr.corp.intel.com ([10.252.137.228]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jun 2022 14:19:58 -0700 Message-ID: Subject: Re: [PATCH v4 2/2] sched/fair: Scan cluster before scanning LLC in wake-up path From: Tim Chen To: Yicong Yang , Yicong Yang , peterz@infradead.org, mingo@redhat.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, gautham.shenoy@amd.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, prime.zeng@huawei.com, jonathan.cameron@huawei.com, ego@linux.vnet.ibm.com, srikar@linux.vnet.ibm.com, linuxarm@huawei.com, 21cnbao@gmail.com, guodong.xu@linaro.org, hesham.almatary@huawei.com, john.garry@huawei.com, shenyang39@huawei.com, Chen Yu Date: Fri, 10 Jun 2022 14:19:57 -0700 In-Reply-To: <4ab2c422-04ae-3199-ae2a-357c3270cd05@huawei.com> References: <20220609120622.47724-1-yangyicong@hisilicon.com> <20220609120622.47724-3-yangyicong@hisilicon.com> <4ab2c422-04ae-3199-ae2a-357c3270cd05@huawei.com> User-Agent: Evolution 3.34.4 (3.34.4-1.fc31) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220610_142012_952575_FAC570B2 X-CRM114-Status: GOOD ( 10.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 2022-06-10 at 14:39 +0800, Yicong Yang wrote: > > > I've tested this patch with MySQL as well (like in v2). This won't hurt > the MySQL case with SIS_PROP but observed some improvement with SIS_UTIL > posted in [1]. We leverage the nr to suppress redundant scanning in the > current approach and seems SIS_UTIL is more efficient in this case. > > 5.19-rc1 patched patched+SIS_UTIL[1] > TPS-16threads 6215.11 6172.74 (-0.68%) 6217.33 (0.04%) > QPS-16threads 124302.21 123454.68 (-0.68%) 124346.52 (0.04%) > avg-lat-16threads 2.57 2.59 (-0.65%) 2.57 (0.00%) > TPS-24threads 8726.40 8690.87 (-0.41%) 8833.08 (1.22%) > QPS-24threads 174527.88 173817.42 (-0.41%) 176661.54 (1.21%) > avg-lat-24threads 2.75 2.76 (-0.36%) 2.71 (1.33%) > TPS-32threads 9555.42 9514.86 (-0.42%) 10010.87 (4.77%) > QPS-32threads 191108.37 190297.28 (-0.42%) 200217.35 (4.55%) > avg-lat-32threads 3.35 3.36 (-0.30%) 3.20 (4.58%) > TPS-64threads 10290.10 10324.75 (0.34%) 10819.77 (5.15%) > QPS-64threads 205802.05 206494.95 (0.34%) 216395.40 (4.90%) > avg-lat-64threads 6.22 6.20 (0.38%) 5.92 (4.88%) > Thanks for the numbers. SIS_UTIL will keep off migrations off the cluster that doesn't really improve overall utilization. We have higher chance that L2 cache is warm. So it makes sense that we see a bit better performance there. Tim _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel