From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2F6FEC4706F for ; Tue, 26 Dec 2023 17:00:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hJEOV1jb4y8YAR79guoVZjpB/u7fZ/NCuCsYp60tm6w=; b=rKjZT+qgdpOAQk ZPhvtyQfCKmuZr58h2GPp5PqVKZ+cOarCO3/MhYEhyqOp5gk++rD0BcIkidv6HUqI5lcrYdcOaeuM H1GNkHycuxffks18IWPA4FP9E+YQ74uTDNbBo2QqBkdrKoPMNgGIoycN8YrAu02tgHKrizE2ll1SZ /k2A/ncLc9+gcy+ckUwLfwC1Jdmdz+zc7uLju/Qd4T0AIkLw1nTV+GR/y7ssAY4lmIG49P2SH9v5d XuhgY7JOmMoLznrQQeUQ08wHOT6O/uJQUTUdIBnq8hRTjCtS0AEQfbWEm5nAnzSKzxS3ZaVxejYav ZYJq931KC8nMPyRPupCw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rIAn4-00DHwx-27; Tue, 26 Dec 2023 17:00:26 +0000 Received: from vps0.lunn.ch ([156.67.10.101]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rIAn2-00DHwZ-0x for linux-arm-kernel@lists.infradead.org; Tue, 26 Dec 2023 17:00:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=6oO/nH2dTlO47uvvrA8XfEBvbbkUP87KpzAhKCfS8Po=; b=X51qlWeZpB7a5LmhCmAqMgit9V 5wlCoUbGKhz50VybZ0LOPHKRcANysy7WkeNOqBgGsqdH4sQlA0nBX5N5Womnn9mdtDNWVJ+19GBUA 5hNmsXpSFhp0iJ6dj4WSf4I69dbtZgzu5Eshaa7bJOpmpVHOl22E4cdtfowmrnUmTacc=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1rIAmv-003meD-Cw; Tue, 26 Dec 2023 18:00:17 +0100 Date: Tue, 26 Dec 2023 18:00:17 +0100 From: Andrew Lunn To: Vladimir Oltean Cc: Jagan Teki , Heiner Kallweit , "Andrew F. Davis" , Florian Fainelli , linux-kernel , netdev@vger.kernel.org, Michael Nazzareno Trimarchi , Ioana Ciornei , Shawn Guo , linux-arm-kernel , Fabio Estevam Subject: Re: PHY issue with SJA1105Q/DP84849I Design Message-ID: References: <20231222145100.sfcuux7ayxtxgogo@skbuf> <20231226153055.4yihsmu6kiak6hkf@skbuf> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231226153055.4yihsmu6kiak6hkf@skbuf> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231226_090024_333539_8DF5FC99 X-CRM114-Status: UNSURE ( 8.95 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > The code which should have prevented this from happening is in > phy_attach_direct(): > > if (phydev->attached_dev) { > dev_err(&dev->dev, "PHY already attached\n"); > err = -EBUSY; > goto error; > } The problem might be dsa_shared_port_phylink_register(): err = phylink_of_phy_connect(dp->pl, port_dn, 0); if (err && err != -ENODEV) { pr_err("could not attach to PHY: %d\n", err); goto err_phy_connect; } return 0; Since it is not -ENODEV, it just keep going. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel