From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 41E31CCA479 for ; Mon, 4 Jul 2022 09:55:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:Message-ID: In-Reply-To:Subject:cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QZWyD1fTSvdUFSsma0tKuvhCoQhK5NsAQWuMcLtdEMU=; b=Ch93ikY7wRH0RR H9c2VKPsdjQsxzt0SafE6xOUXBXPco0kOkZ+pGN6XwrFgv+pXVBLJqsbkLl0t2tcjuuipymROWjUM 91psOX14RV9sHXzLQNBSVkaqtNFvqFGo7h+RiKTo550KIkE5zPsQXuOzrvgW7rEdmaTWtIqbKxT3j SYsgwjTqZxgXVSc6QxsWzdafSjBtOhSqSthL70QW8aNW/bJpbODN8cqtRdXBNc842YAcZaYo8QZus FP6BqoY27UJDPUy7QccOjrE3S2cmaztU2niZaf6qCiLq/ri64rgRDn9rZco1IVOL3UqzJi0UV7erd LdLBM1AGynAXyHotQ1dw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o8ImT-006deE-FK; Mon, 04 Jul 2022 09:54:13 +0000 Received: from mga17.intel.com ([192.55.52.151]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o8ImN-006dZt-Lx for linux-arm-kernel@lists.infradead.org; Mon, 04 Jul 2022 09:54:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1656928447; x=1688464447; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=lSh2EbbxhUgUat8Nrxc/d9fNoMjhwQg9R6qR3jGL+Ug=; b=etdLVxMjDFb/UKPjtQGcTIFJFAjSwOPkNzXL8uLd++krQc0HvSKUpAVL WaSf//U9/U223LyZcJ0gMTpv6au4MAdy2wgxb0SQbya7bKqrNR9l82DKO Ae5ZyD02T1Bq6IOXT7C5ZLND3zBgs6bxnu/WOkHad1Gh6ltRnx59I8xHt eSFb1XwNwW0YGJtqHRof36MocKARPSJcoLsIbzg1mCIQWh4PpUSW9NPTW rjS3+So51Dv+0UUT0OKKboYPO0CCSY7kajBmoJQJfQE0WKD+DLleUHSqY dgYc0c9hh+h/NjVr1+MBPDIzZKHy3EeX+pNHj7fxnyf/fsKxNjDB1LXw4 A==; X-IronPort-AV: E=McAfee;i="6400,9594,10397"; a="263511024" X-IronPort-AV: E=Sophos;i="5.92,243,1650956400"; d="scan'208";a="263511024" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jul 2022 02:54:07 -0700 X-IronPort-AV: E=Sophos;i="5.92,243,1650956400"; d="scan'208";a="649512912" Received: from bclindho-mobl.ger.corp.intel.com ([10.252.49.27]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jul 2022 02:54:01 -0700 Date: Mon, 4 Jul 2022 12:53:58 +0300 (EEST) From: =?ISO-8859-15?Q?Ilpo_J=E4rvinen?= To: Lino Sanfilippo cc: Andy Shevchenko , Greg Kroah-Hartman , Jiri Slaby , Rob Herring , Krzysztof Kozlowski , Andy Shevchenko , Vladimir Zapolskiy , linux-arm Mailing List , devicetree , "open list:SERIAL DRIVERS" , Linux Kernel Mailing List , Lukas Wunner , p.rosenberger@kunbus.com, Lino Sanfilippo Subject: Re: [PATCH v2 7/9] serial: ar933x: Fix check for RS485 support In-Reply-To: Message-ID: References: <20220703170039.2058202-1-LinoSanfilippo@gmx.de> <20220703170039.2058202-8-LinoSanfilippo@gmx.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220704_025407_776983_92C33423 X-CRM114-Status: GOOD ( 20.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 4 Jul 2022, Lino Sanfilippo wrote: > On 03.07.22 20:39, Andy Shevchenko wrote: > > On Sun, Jul 3, 2022 at 7:02 PM Lino Sanfilippo wrote: > >> > >> From: Lino Sanfilippo > >> > >> Without an RTS GPIO RS485 is not possible so disable the support > >> regardless of whether RS485 is enabled at boottime or not. Also remove the > > > > boot time > > > >> now superfluous check for the RTS GPIO in ar933x_config_rs485(). > >> > >> Fixes: e849145e1fdd ("serial: ar933x: Fill in rs485_supported") > > > > Is it an independent fix? If so, it should be the first patch in the > > series, otherwise if it's dependent on something from previous patches > > you need to mark all of them as a fix. > > > > The fix is independent, patch 8 depends on the fix however. I was not > aware of this fixes-first rule for series with patches that are independent > from each other. I will change the order accordingly in the next version of the series. While at it, you could separate just the fix to own patch and the ->rs485_config() cleanup to own patch (or move it all to patch 8). Not that this fix is expected to go anywhere else besides tty-next. -- i. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel