* [PATCH 0/3] ARM: dts: imx: cleanup most gpmi related CHECK_DTB warning
@ 2025-11-04 22:27 Frank Li
2025-11-04 22:27 ` [PATCH 1/3] ARM: dts: imx6qdl: add '#address-cells' and '#size-cells' for gpmi-nand Frank Li
` (3 more replies)
0 siblings, 4 replies; 11+ messages in thread
From: Frank Li @ 2025-11-04 22:27 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam
Cc: devicetree, imx, linux-arm-kernel, linux-kernel, Frank Li
Only few warning left because original data is wrong
arch/arm/boot/dts/nxp/imx/imx6ull-engicam-microgea-bmm.dtb: nand-controller@1806000 (fsl,imx6q-gpmi-nand): nand@0:nand-ecc-step-size: 0 is less than the minimum of 1
driver will leave default value when these value is 0, but binding require
start from 1.
Since 2019 year, commit
(212e496935929 dt-bindings: mtd: Add YAML schemas for the generic NAND options)
NAND related property is preferred located under nand@<n> even though only
one NAND chip supported.
NAND related property should be located under nand@0. This format already
support quite long time, so it should be safe to switch to modern format.
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
Frank Li (3):
ARM: dts: imx6qdl: add '#address-cells' and '#size-cells' for gpmi-nand
ARM: dts: imx6sx: update gpmi #size-cells to 0
ARM: dts: imx: move nand related property under nand@0
arch/arm/boot/dts/nxp/imx/imx6-logicpd-som.dtsi | 6 +++++-
arch/arm/boot/dts/nxp/imx/imx6qdl-icore.dtsi | 6 +++++-
arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-pfla02.dtsi | 6 +++++-
arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-phycore-som.dtsi | 6 +++++-
arch/arm/boot/dts/nxp/imx/imx6qdl-skov-cpu.dtsi | 6 +++++-
arch/arm/boot/dts/nxp/imx/imx6qdl-tx6.dtsi | 6 +++++-
arch/arm/boot/dts/nxp/imx/imx6qdl.dtsi | 2 ++
arch/arm/boot/dts/nxp/imx/imx6sx.dtsi | 2 +-
arch/arm/boot/dts/nxp/imx/imx6ul-geam.dts | 6 +++++-
arch/arm/boot/dts/nxp/imx/imx6ul-isiot.dtsi | 6 +++++-
arch/arm/boot/dts/nxp/imx/imx6ul-phytec-phycore-som.dtsi | 6 +++++-
arch/arm/boot/dts/nxp/imx/imx6ul-tx6ul.dtsi | 6 +++++-
arch/arm/boot/dts/nxp/imx/imx6ull-colibri.dtsi | 12 ++++++++----
arch/arm/boot/dts/nxp/imx/imx6ull-engicam-microgea.dtsi | 12 ++++++++----
arch/arm/boot/dts/nxp/imx/imx6ull-myir-mys-6ulx.dtsi | 6 +++++-
arch/arm/boot/dts/nxp/imx/imx6ulz-bsh-smm-m2.dts | 6 +++++-
arch/arm/boot/dts/nxp/imx/imx7-colibri.dtsi | 8 ++++++--
17 files changed, 85 insertions(+), 23 deletions(-)
---
base-commit: f8a6148698538647188a0f801f686ff90035a8ca
change-id: 20251104-gpmi_dts-67f07fb2041c
Best regards,
--
Frank Li <Frank.Li@nxp.com>
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 1/3] ARM: dts: imx6qdl: add '#address-cells' and '#size-cells' for gpmi-nand
2025-11-04 22:27 [PATCH 0/3] ARM: dts: imx: cleanup most gpmi related CHECK_DTB warning Frank Li
@ 2025-11-04 22:27 ` Frank Li
2025-11-04 22:27 ` [PATCH 2/3] ARM: dts: imx6sx: update gpmi #size-cells to 0 Frank Li
` (2 subsequent siblings)
3 siblings, 0 replies; 11+ messages in thread
From: Frank Li @ 2025-11-04 22:27 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam
Cc: devicetree, imx, linux-arm-kernel, linux-kernel, Frank Li
Add '#address-cells' and '#size-cells' for gpmi-nand to below CHECK_DTBS
warings:
arm/boot/dts/nxp/imx/imx6dl-aristainetos_4.dtb: nand-controller@112000 (fsl,imx6q-gpmi-nand): '#address-cells' is a required property
from schema $id: http://devicetree.org/schemas/mtd/gpmi-nand.yaml#
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
arch/arm/boot/dts/nxp/imx/imx6qdl.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl.dtsi
index 45bcfd7faf9db628479359b5c0a26e1011a7c2d3..a361886144ee1de5a183f405a58d7020d75cba9b 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6qdl.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6qdl.dtsi
@@ -166,6 +166,8 @@ gpmi: nand-controller@112000 {
compatible = "fsl,imx6q-gpmi-nand";
reg = <0x00112000 0x2000>, <0x00114000 0x2000>;
reg-names = "gpmi-nand", "bch";
+ #address-cells = <1>;
+ #size-cells = <0>;
interrupts = <0 15 IRQ_TYPE_LEVEL_HIGH>;
interrupt-names = "bch";
clocks = <&clks IMX6QDL_CLK_GPMI_IO>,
--
2.34.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 2/3] ARM: dts: imx6sx: update gpmi #size-cells to 0
2025-11-04 22:27 [PATCH 0/3] ARM: dts: imx: cleanup most gpmi related CHECK_DTB warning Frank Li
2025-11-04 22:27 ` [PATCH 1/3] ARM: dts: imx6qdl: add '#address-cells' and '#size-cells' for gpmi-nand Frank Li
@ 2025-11-04 22:27 ` Frank Li
2025-11-04 22:27 ` [PATCH 3/3] ARM: dts: imx: move nand related property under nand@0 Frank Li
2025-11-05 2:07 ` [PATCH 0/3] ARM: dts: imx: cleanup most gpmi related CHECK_DTB warning Peng Fan
3 siblings, 0 replies; 11+ messages in thread
From: Frank Li @ 2025-11-04 22:27 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam
Cc: devicetree, imx, linux-arm-kernel, linux-kernel, Frank Li
Update gpmi #size-cells to 0 to fix below CHECK_DTB warnings:
arch/arm/boot/dts/nxp/imx/imx6sx-nitrogen6sx.dtb: nand-controller@1806000 (fsl,imx6sx-gpmi-nand): #size-cells: 0 was expected
from schema $id: http://devicetree.org/schemas/mtd/gpmi-nand.yaml#
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
arch/arm/boot/dts/nxp/imx/imx6sx.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/nxp/imx/imx6sx.dtsi b/arch/arm/boot/dts/nxp/imx/imx6sx.dtsi
index 5132b575b001564b9767605ae7ff044701516673..1426f357d47448ab0ed289a5233f71c1e365033e 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6sx.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6sx.dtsi
@@ -224,7 +224,7 @@ dma_apbh: dma-controller@1804000 {
gpmi: nand-controller@1806000 {
compatible = "fsl,imx6sx-gpmi-nand";
#address-cells = <1>;
- #size-cells = <1>;
+ #size-cells = <0>;
reg = <0x01806000 0x2000>, <0x01808000 0x4000>;
reg-names = "gpmi-nand", "bch";
interrupts = <GIC_SPI 15 IRQ_TYPE_LEVEL_HIGH>;
--
2.34.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 3/3] ARM: dts: imx: move nand related property under nand@0
2025-11-04 22:27 [PATCH 0/3] ARM: dts: imx: cleanup most gpmi related CHECK_DTB warning Frank Li
2025-11-04 22:27 ` [PATCH 1/3] ARM: dts: imx6qdl: add '#address-cells' and '#size-cells' for gpmi-nand Frank Li
2025-11-04 22:27 ` [PATCH 2/3] ARM: dts: imx6sx: update gpmi #size-cells to 0 Frank Li
@ 2025-11-04 22:27 ` Frank Li
2025-11-05 11:55 ` Francesco Dolcini
2025-11-05 2:07 ` [PATCH 0/3] ARM: dts: imx: cleanup most gpmi related CHECK_DTB warning Peng Fan
3 siblings, 1 reply; 11+ messages in thread
From: Frank Li @ 2025-11-04 22:27 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam
Cc: devicetree, imx, linux-arm-kernel, linux-kernel, Frank Li
Add child node nand@0 and move NAND related property under it to align
modern nand-controller.yaml.
Fix below CHECK_DTBS warnings:
arch/arm/boot/dts/nxp/imx/imx6ull-colibri-aster.dtb: nand-controller@1806000 (fsl,imx6q-gpmi-nand): Unevaluated properties are not allowed ('nand-ecc-mode', 'nand-ecc-step-size', 'nand-ecc-strength', 'nand-on-flash-bbt' were unexpected)
from schema $id: http://devicetree.org/schemas/mtd/gpmi-nand.yaml#
Since 2019 year, commit
(212e496935929 dt-bindings: mtd: Add YAML schemas for the generic NAND options)
NAND related property is preferred located under nand@<n> even though only
one NAND chip supported.
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
arch/arm/boot/dts/nxp/imx/imx6-logicpd-som.dtsi | 6 +++++-
arch/arm/boot/dts/nxp/imx/imx6qdl-icore.dtsi | 6 +++++-
arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-pfla02.dtsi | 6 +++++-
arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-phycore-som.dtsi | 6 +++++-
arch/arm/boot/dts/nxp/imx/imx6qdl-skov-cpu.dtsi | 6 +++++-
arch/arm/boot/dts/nxp/imx/imx6qdl-tx6.dtsi | 6 +++++-
arch/arm/boot/dts/nxp/imx/imx6ul-geam.dts | 6 +++++-
arch/arm/boot/dts/nxp/imx/imx6ul-isiot.dtsi | 6 +++++-
arch/arm/boot/dts/nxp/imx/imx6ul-phytec-phycore-som.dtsi | 6 +++++-
arch/arm/boot/dts/nxp/imx/imx6ul-tx6ul.dtsi | 6 +++++-
arch/arm/boot/dts/nxp/imx/imx6ull-colibri.dtsi | 12 ++++++++----
arch/arm/boot/dts/nxp/imx/imx6ull-engicam-microgea.dtsi | 12 ++++++++----
arch/arm/boot/dts/nxp/imx/imx6ull-myir-mys-6ulx.dtsi | 6 +++++-
arch/arm/boot/dts/nxp/imx/imx6ulz-bsh-smm-m2.dts | 6 +++++-
arch/arm/boot/dts/nxp/imx/imx7-colibri.dtsi | 8 ++++++--
15 files changed, 82 insertions(+), 22 deletions(-)
diff --git a/arch/arm/boot/dts/nxp/imx/imx6-logicpd-som.dtsi b/arch/arm/boot/dts/nxp/imx/imx6-logicpd-som.dtsi
index 547fb141ec0c9f4f2aace5f2095bfbd2d921d2dd..f452764fae00ef801ab0d69879457f9a404bef2e 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6-logicpd-som.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6-logicpd-som.dtsi
@@ -36,8 +36,12 @@ &clks {
&gpmi {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_gpmi_nand>;
- nand-on-flash-bbt;
status = "okay";
+
+ nand@0 {
+ reg = <0>;
+ nand-on-flash-bbt;
+ };
};
&i2c3 {
diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-icore.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-icore.dtsi
index 9975b6ee433d1daf4ed24bf2b91f167fbaa398ff..58ecdb87c6d404ee3e06501f3bddd029eb9670af 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6qdl-icore.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-icore.dtsi
@@ -172,8 +172,12 @@ eth_phy: ethernet-phy@0 {
&gpmi {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_gpmi_nand>;
- nand-on-flash-bbt;
status = "okay";
+
+ nand@0 {
+ reg = <0>;
+ nand-on-flash-bbt;
+ };
};
&i2c1 {
diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-pfla02.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-pfla02.dtsi
index aa9a442852f41b76782c570d28d277e7eb586636..6f3becd33a5b5f83dcc5df3286244fb601eaa537 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-pfla02.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-pfla02.dtsi
@@ -102,8 +102,12 @@ ethphy: ethernet-phy@0 {
&gpmi {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_gpmi_nand>;
- nand-on-flash-bbt;
status = "okay";
+
+ nand@0 {
+ reg = <0>;
+ nand-on-flash-bbt;
+ };
};
&i2c1 {
diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-phycore-som.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-phycore-som.dtsi
index 85e278eb201610a1c851c4093025bb205e02a3b3..f2140dd8525f81c9b242cef1e4970baa6462b9b8 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-phycore-som.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-phycore-som.dtsi
@@ -73,8 +73,12 @@ ethphy: ethernet-phy@3 {
&gpmi {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_gpmi_nand>;
- nand-on-flash-bbt;
status = "disabled";
+
+ nand@0 {
+ reg = <0>;
+ nand-on-flash-bbt;
+ };
};
&i2c3 {
diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-skov-cpu.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-skov-cpu.dtsi
index c93dbc595ef6eceda5fdf7b90dac57bfed59e489..131a3428ddb86796ed843b46cbae12f5d095b2f4 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6qdl-skov-cpu.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-skov-cpu.dtsi
@@ -260,10 +260,14 @@ fixed-link {
&gpmi {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_gpmi_nand>;
- nand-on-flash-bbt;
#address-cells = <1>;
#size-cells = <0>;
status = "okay";
+
+ nand@0 {
+ reg = <0>;
+ nand-on-flash-bbt;
+ };
};
&i2c3 {
diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-tx6.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-tx6.dtsi
index 57297d6521cf09f1fd629ae375c9994ebb683375..d29adfef5fdba321606eb68614cc82393fea9052 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6qdl-tx6.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-tx6.dtsi
@@ -252,9 +252,13 @@ etnphy: ethernet-phy@0 {
&gpmi {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_gpmi_nand>;
- nand-on-flash-bbt;
fsl,no-blockmark-swap;
status = "okay";
+
+ nand@0 {
+ reg = <0>;
+ nand-on-flash-bbt;
+ };
};
&i2c1 {
diff --git a/arch/arm/boot/dts/nxp/imx/imx6ul-geam.dts b/arch/arm/boot/dts/nxp/imx/imx6ul-geam.dts
index 2a6bb5ff808add0d3648480061e136e1050a1ccf..40d530c1dc29f2a679804992b8b41fd05ee7ead3 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6ul-geam.dts
+++ b/arch/arm/boot/dts/nxp/imx/imx6ul-geam.dts
@@ -133,8 +133,12 @@ ethphy1: ethernet-phy@1 {
&gpmi {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_gpmi_nand>;
- nand-on-flash-bbt;
status = "okay";
+
+ nand@0 {
+ reg = <0>;
+ nand-on-flash-bbt;
+ };
};
&i2c1 {
diff --git a/arch/arm/boot/dts/nxp/imx/imx6ul-isiot.dtsi b/arch/arm/boot/dts/nxp/imx/imx6ul-isiot.dtsi
index e34c8cbe36aec682f46ffa128247bc47f3a6cab9..776f6f78ee4631fc154bf261299f687285137413 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6ul-isiot.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6ul-isiot.dtsi
@@ -101,8 +101,12 @@ ethphy0: ethernet-phy@0 {
&gpmi {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_gpmi_nand>;
- nand-on-flash-bbt;
status = "disabled";
+
+ nand@0 {
+ reg = <0>;
+ nand-on-flash-bbt;
+ };
};
&i2c1 {
diff --git a/arch/arm/boot/dts/nxp/imx/imx6ul-phytec-phycore-som.dtsi b/arch/arm/boot/dts/nxp/imx/imx6ul-phytec-phycore-som.dtsi
index a3ea1b20846253b8c4a5dc3a0ff0d505c24be3ff..27e4d2aec137fc35016428d8b3605ebaed65f490 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6ul-phytec-phycore-som.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6ul-phytec-phycore-som.dtsi
@@ -63,8 +63,12 @@ ethphy1: ethernet-phy@1 {
&gpmi {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_gpmi_nand>;
- nand-on-flash-bbt;
status = "disabled";
+
+ nand@0 {
+ reg = <0>;
+ nand-on-flash-bbt;
+ };
};
&i2c1 {
diff --git a/arch/arm/boot/dts/nxp/imx/imx6ul-tx6ul.dtsi b/arch/arm/boot/dts/nxp/imx/imx6ul-tx6ul.dtsi
index 1992dfb53b45cd308522c3e922d5758f5b8fe527..dc53f9286ffe27c718b8b8bd01169d1ff4ad13af 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6ul-tx6ul.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6ul-tx6ul.dtsi
@@ -296,9 +296,13 @@ &fec2 {
&gpmi {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_gpmi_nand>;
- nand-on-flash-bbt;
fsl,no-blockmark-swap;
status = "okay";
+
+ nand@0 {
+ reg = <0>;
+ nand-on-flash-bbt;
+ };
};
&i2c2 {
diff --git a/arch/arm/boot/dts/nxp/imx/imx6ull-colibri.dtsi b/arch/arm/boot/dts/nxp/imx/imx6ull-colibri.dtsi
index ec3c1e7301f48f6fbf0190a8286d5110ef61c35d..eaed2cbf0c82aa55bb436a03e0eb45be7cf94c5b 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6ull-colibri.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6ull-colibri.dtsi
@@ -160,11 +160,15 @@ &gpmi {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_gpmi_nand>;
fsl,use-minimum-ecc;
- nand-on-flash-bbt;
- nand-ecc-mode = "hw";
- nand-ecc-strength = <8>;
- nand-ecc-step-size = <512>;
status = "okay";
+
+ nand@0 {
+ reg = <0>;
+ nand-on-flash-bbt;
+ nand-ecc-mode = "hw";
+ nand-ecc-strength = <8>;
+ nand-ecc-step-size = <512>;
+ };
};
/* I2C3_SDA/SCL on SODIMM 194/196 (e.g. RTC on carrier board) */
diff --git a/arch/arm/boot/dts/nxp/imx/imx6ull-engicam-microgea.dtsi b/arch/arm/boot/dts/nxp/imx/imx6ull-engicam-microgea.dtsi
index 43518bf0760249831781dc5220fa640eabf16d14..3dfd43b320553c45e22e4862cb1299c11eee1dfd 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6ull-engicam-microgea.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6ull-engicam-microgea.dtsi
@@ -43,11 +43,15 @@ ethphy0: ethernet-phy@0 {
&gpmi {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_gpmi_nand>;
- nand-ecc-mode = "hw";
- nand-ecc-strength = <0>;
- nand-ecc-step-size = <0>;
- nand-on-flash-bbt;
status = "okay";
+
+ nand@0 {
+ reg = <0>;
+ nand-ecc-mode = "hw";
+ nand-ecc-strength = <0>;
+ nand-ecc-step-size = <0>;
+ nand-on-flash-bbt;
+ };
};
&iomuxc {
diff --git a/arch/arm/boot/dts/nxp/imx/imx6ull-myir-mys-6ulx.dtsi b/arch/arm/boot/dts/nxp/imx/imx6ull-myir-mys-6ulx.dtsi
index 83b9de17cee2de37c15a461ddbdc74f0aee2e34c..fc298f57bfff349fe51983baae19c58d7e99f1aa 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6ull-myir-mys-6ulx.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6ull-myir-mys-6ulx.dtsi
@@ -60,8 +60,12 @@ ethphy0: ethernet-phy@0 {
&gpmi {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_gpmi_nand>;
- nand-on-flash-bbt;
status = "disabled";
+
+ nand@0 {
+ reg = <0>;
+ nand-on-flash-bbt;
+ };
};
&uart1 {
diff --git a/arch/arm/boot/dts/nxp/imx/imx6ulz-bsh-smm-m2.dts b/arch/arm/boot/dts/nxp/imx/imx6ulz-bsh-smm-m2.dts
index 2d9f495660c9a329dcfb15d04864690efbd1cb7f..8ec18eae98a46abbf3d0a81cca2c5bd24765fcb6 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6ulz-bsh-smm-m2.dts
+++ b/arch/arm/boot/dts/nxp/imx/imx6ulz-bsh-smm-m2.dts
@@ -25,8 +25,12 @@ usdhc2_pwrseq: usdhc2-pwrseq {
&gpmi {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_gpmi_nand>;
- nand-on-flash-bbt;
status = "okay";
+
+ nand@0 {
+ reg = <0>;
+ nand-on-flash-bbt;
+ };
};
&snvs_poweroff {
diff --git a/arch/arm/boot/dts/nxp/imx/imx7-colibri.dtsi b/arch/arm/boot/dts/nxp/imx/imx7-colibri.dtsi
index 8666dcd7fe974699354beba7a04844fd0a2cd27f..a41dc4edfc0ddc34ff235d6ba9964120fe56fe27 100644
--- a/arch/arm/boot/dts/nxp/imx/imx7-colibri.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx7-colibri.dtsi
@@ -375,10 +375,14 @@ &gpio7 {
/* NAND on such SKUs */
&gpmi {
fsl,use-minimum-ecc;
- nand-ecc-mode = "hw";
- nand-on-flash-bbt;
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_gpmi_nand>;
+
+ nand@0 {
+ reg = <0>;
+ nand-ecc-mode = "hw";
+ nand-on-flash-bbt;
+ };
};
/* On-module Power I2C */
--
2.34.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH 0/3] ARM: dts: imx: cleanup most gpmi related CHECK_DTB warning
2025-11-04 22:27 [PATCH 0/3] ARM: dts: imx: cleanup most gpmi related CHECK_DTB warning Frank Li
` (2 preceding siblings ...)
2025-11-04 22:27 ` [PATCH 3/3] ARM: dts: imx: move nand related property under nand@0 Frank Li
@ 2025-11-05 2:07 ` Peng Fan
3 siblings, 0 replies; 11+ messages in thread
From: Peng Fan @ 2025-11-05 2:07 UTC (permalink / raw)
To: Frank Li
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, devicetree,
imx, linux-arm-kernel, linux-kernel
On Tue, Nov 04, 2025 at 05:27:11PM -0500, Frank Li wrote:
>Only few warning left because original data is wrong
>arch/arm/boot/dts/nxp/imx/imx6ull-engicam-microgea-bmm.dtb: nand-controller@1806000 (fsl,imx6q-gpmi-nand): nand@0:nand-ecc-step-size: 0 is less than the minimum of 1
>
>driver will leave default value when these value is 0, but binding require
>start from 1.
>
>Since 2019 year, commit
> (212e496935929 dt-bindings: mtd: Add YAML schemas for the generic NAND options)
> NAND related property is preferred located under nand@<n> even though only
> one NAND chip supported.
>
>NAND related property should be located under nand@0. This format already
>support quite long time, so it should be safe to switch to modern format.
>
>Signed-off-by: Frank Li <Frank.Li@nxp.com>
>---
>Frank Li (3):
> ARM: dts: imx6qdl: add '#address-cells' and '#size-cells' for gpmi-nand
> ARM: dts: imx6sx: update gpmi #size-cells to 0
> ARM: dts: imx: move nand related property under nand@0
>
Reviewed-by: Peng Fan <peng.fan@nxp.com>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 3/3] ARM: dts: imx: move nand related property under nand@0
2025-11-04 22:27 ` [PATCH 3/3] ARM: dts: imx: move nand related property under nand@0 Frank Li
@ 2025-11-05 11:55 ` Francesco Dolcini
2025-11-05 15:29 ` Frank Li
0 siblings, 1 reply; 11+ messages in thread
From: Francesco Dolcini @ 2025-11-05 11:55 UTC (permalink / raw)
To: Frank Li
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, devicetree,
imx, linux-arm-kernel, linux-kernel
Hello Frank,
On Tue, Nov 04, 2025 at 05:27:14PM -0500, Frank Li wrote:
> Add child node nand@0 and move NAND related property under it to align
> modern nand-controller.yaml.
>
> Fix below CHECK_DTBS warnings:
> arch/arm/boot/dts/nxp/imx/imx6ull-colibri-aster.dtb: nand-controller@1806000 (fsl,imx6q-gpmi-nand): Unevaluated properties are not allowed ('nand-ecc-mode', 'nand-ecc-step-size', 'nand-ecc-strength', 'nand-on-flash-bbt' were unexpected)
> from schema $id: http://devicetree.org/schemas/mtd/gpmi-nand.yaml#
>
> Since 2019 year, commit
> (212e496935929 dt-bindings: mtd: Add YAML schemas for the generic NAND options)
> NAND related property is preferred located under nand@<n> even though only
> one NAND chip supported.
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> arch/arm/boot/dts/nxp/imx/imx6-logicpd-som.dtsi | 6 +++++-
> arch/arm/boot/dts/nxp/imx/imx6qdl-icore.dtsi | 6 +++++-
> arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-pfla02.dtsi | 6 +++++-
> arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-phycore-som.dtsi | 6 +++++-
> arch/arm/boot/dts/nxp/imx/imx6qdl-skov-cpu.dtsi | 6 +++++-
> arch/arm/boot/dts/nxp/imx/imx6qdl-tx6.dtsi | 6 +++++-
> arch/arm/boot/dts/nxp/imx/imx6ul-geam.dts | 6 +++++-
> arch/arm/boot/dts/nxp/imx/imx6ul-isiot.dtsi | 6 +++++-
> arch/arm/boot/dts/nxp/imx/imx6ul-phytec-phycore-som.dtsi | 6 +++++-
> arch/arm/boot/dts/nxp/imx/imx6ul-tx6ul.dtsi | 6 +++++-
> arch/arm/boot/dts/nxp/imx/imx6ull-colibri.dtsi | 12 ++++++++----
> arch/arm/boot/dts/nxp/imx/imx6ull-engicam-microgea.dtsi | 12 ++++++++----
> arch/arm/boot/dts/nxp/imx/imx6ull-myir-mys-6ulx.dtsi | 6 +++++-
> arch/arm/boot/dts/nxp/imx/imx6ulz-bsh-smm-m2.dts | 6 +++++-
> arch/arm/boot/dts/nxp/imx/imx7-colibri.dtsi | 8 ++++++--
> 15 files changed, 82 insertions(+), 22 deletions(-)
>
Was any of these changes tested? Is the driver able to cope with the
binding change?
Francesco
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 3/3] ARM: dts: imx: move nand related property under nand@0
2025-11-05 11:55 ` Francesco Dolcini
@ 2025-11-05 15:29 ` Frank Li
2025-11-07 15:52 ` Francesco Dolcini
0 siblings, 1 reply; 11+ messages in thread
From: Frank Li @ 2025-11-05 15:29 UTC (permalink / raw)
To: Francesco Dolcini
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, devicetree,
imx, linux-arm-kernel, linux-kernel
On Wed, Nov 05, 2025 at 12:55:38PM +0100, Francesco Dolcini wrote:
> Hello Frank,
>
> On Tue, Nov 04, 2025 at 05:27:14PM -0500, Frank Li wrote:
> > Add child node nand@0 and move NAND related property under it to align
> > modern nand-controller.yaml.
> >
> > Fix below CHECK_DTBS warnings:
> > arch/arm/boot/dts/nxp/imx/imx6ull-colibri-aster.dtb: nand-controller@1806000 (fsl,imx6q-gpmi-nand): Unevaluated properties are not allowed ('nand-ecc-mode', 'nand-ecc-step-size', 'nand-ecc-strength', 'nand-on-flash-bbt' were unexpected)
> > from schema $id: http://devicetree.org/schemas/mtd/gpmi-nand.yaml#
> >
> > Since 2019 year, commit
> > (212e496935929 dt-bindings: mtd: Add YAML schemas for the generic NAND options)
> > NAND related property is preferred located under nand@<n> even though only
> > one NAND chip supported.
> >
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> > arch/arm/boot/dts/nxp/imx/imx6-logicpd-som.dtsi | 6 +++++-
> > arch/arm/boot/dts/nxp/imx/imx6qdl-icore.dtsi | 6 +++++-
> > arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-pfla02.dtsi | 6 +++++-
> > arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-phycore-som.dtsi | 6 +++++-
> > arch/arm/boot/dts/nxp/imx/imx6qdl-skov-cpu.dtsi | 6 +++++-
> > arch/arm/boot/dts/nxp/imx/imx6qdl-tx6.dtsi | 6 +++++-
> > arch/arm/boot/dts/nxp/imx/imx6ul-geam.dts | 6 +++++-
> > arch/arm/boot/dts/nxp/imx/imx6ul-isiot.dtsi | 6 +++++-
> > arch/arm/boot/dts/nxp/imx/imx6ul-phytec-phycore-som.dtsi | 6 +++++-
> > arch/arm/boot/dts/nxp/imx/imx6ul-tx6ul.dtsi | 6 +++++-
> > arch/arm/boot/dts/nxp/imx/imx6ull-colibri.dtsi | 12 ++++++++----
> > arch/arm/boot/dts/nxp/imx/imx6ull-engicam-microgea.dtsi | 12 ++++++++----
> > arch/arm/boot/dts/nxp/imx/imx6ull-myir-mys-6ulx.dtsi | 6 +++++-
> > arch/arm/boot/dts/nxp/imx/imx6ulz-bsh-smm-m2.dts | 6 +++++-
> > arch/arm/boot/dts/nxp/imx/imx7-colibri.dtsi | 8 ++++++--
> > 15 files changed, 82 insertions(+), 22 deletions(-)
> >
>
> Was any of these changes tested? Is the driver able to cope with the
> binding change?
I have not board to do direct test. This format is used at imx8 platform,
which use the same gpmi driver.
This properties are parsed at mtd common part
drivers/mtd/nand/raw/nand_base.c
If you have one of above board to test it, it will be appericated.
Frank
>
> Francesco
>
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 3/3] ARM: dts: imx: move nand related property under nand@0
2025-11-05 15:29 ` Frank Li
@ 2025-11-07 15:52 ` Francesco Dolcini
2025-11-10 16:12 ` Frank Li
0 siblings, 1 reply; 11+ messages in thread
From: Francesco Dolcini @ 2025-11-07 15:52 UTC (permalink / raw)
To: Frank Li
Cc: Francesco Dolcini, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
devicetree, imx, linux-arm-kernel, linux-kernel
Hello Frank,
On Wed, Nov 05, 2025 at 10:29:05AM -0500, Frank Li wrote:
> On Wed, Nov 05, 2025 at 12:55:38PM +0100, Francesco Dolcini wrote:
> > On Tue, Nov 04, 2025 at 05:27:14PM -0500, Frank Li wrote:
> > > Add child node nand@0 and move NAND related property under it to align
> > > modern nand-controller.yaml.
> > >
> > > Fix below CHECK_DTBS warnings:
> > > arch/arm/boot/dts/nxp/imx/imx6ull-colibri-aster.dtb: nand-controller@1806000 (fsl,imx6q-gpmi-nand): Unevaluated properties are not allowed ('nand-ecc-mode', 'nand-ecc-step-size', 'nand-ecc-strength', 'nand-on-flash-bbt' were unexpected)
> > > from schema $id: http://devicetree.org/schemas/mtd/gpmi-nand.yaml#
> > >
> > > Since 2019 year, commit
> > > (212e496935929 dt-bindings: mtd: Add YAML schemas for the generic NAND options)
> > > NAND related property is preferred located under nand@<n> even though only
> > > one NAND chip supported.
> > >
> > > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > > ---
> > > arch/arm/boot/dts/nxp/imx/imx6-logicpd-som.dtsi | 6 +++++-
> > > arch/arm/boot/dts/nxp/imx/imx6qdl-icore.dtsi | 6 +++++-
> > > arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-pfla02.dtsi | 6 +++++-
> > > arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-phycore-som.dtsi | 6 +++++-
> > > arch/arm/boot/dts/nxp/imx/imx6qdl-skov-cpu.dtsi | 6 +++++-
> > > arch/arm/boot/dts/nxp/imx/imx6qdl-tx6.dtsi | 6 +++++-
> > > arch/arm/boot/dts/nxp/imx/imx6ul-geam.dts | 6 +++++-
> > > arch/arm/boot/dts/nxp/imx/imx6ul-isiot.dtsi | 6 +++++-
> > > arch/arm/boot/dts/nxp/imx/imx6ul-phytec-phycore-som.dtsi | 6 +++++-
> > > arch/arm/boot/dts/nxp/imx/imx6ul-tx6ul.dtsi | 6 +++++-
> > > arch/arm/boot/dts/nxp/imx/imx6ull-colibri.dtsi | 12 ++++++++----
> > > arch/arm/boot/dts/nxp/imx/imx6ull-engicam-microgea.dtsi | 12 ++++++++----
> > > arch/arm/boot/dts/nxp/imx/imx6ull-myir-mys-6ulx.dtsi | 6 +++++-
> > > arch/arm/boot/dts/nxp/imx/imx6ulz-bsh-smm-m2.dts | 6 +++++-
> > > arch/arm/boot/dts/nxp/imx/imx7-colibri.dtsi | 8 ++++++--
> > > 15 files changed, 82 insertions(+), 22 deletions(-)
> > >
> >
> > Was any of these changes tested? Is the driver able to cope with the
> > binding change?
>
> I have not board to do direct test. This format is used at imx8 platform,
> which use the same gpmi driver.
>
> This properties are parsed at mtd common part
> drivers/mtd/nand/raw/nand_base.c
>
> If you have one of above board to test it, it will be appericated.
I did a minimal boot test, on colibri-imx6ull, and the board was booting
fine, with Linux 6.18.0-rc4 and this patch applied.
I am wondering if there is any impact with the bootloader, this DT is
used as it is also in U-Boot, and there the NAND driver is for sure
different. Any comment on this? I was not able to test this combination.
Francesco
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 3/3] ARM: dts: imx: move nand related property under nand@0
2025-11-07 15:52 ` Francesco Dolcini
@ 2025-11-10 16:12 ` Frank Li
2025-11-11 7:21 ` Francesco Dolcini
2025-11-11 10:09 ` Krzysztof Kozlowski
0 siblings, 2 replies; 11+ messages in thread
From: Frank Li @ 2025-11-10 16:12 UTC (permalink / raw)
To: Francesco Dolcini
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, devicetree,
imx, linux-arm-kernel, linux-kernel
On Fri, Nov 07, 2025 at 04:52:01PM +0100, Francesco Dolcini wrote:
> Hello Frank,
>
> On Wed, Nov 05, 2025 at 10:29:05AM -0500, Frank Li wrote:
> > On Wed, Nov 05, 2025 at 12:55:38PM +0100, Francesco Dolcini wrote:
> > > On Tue, Nov 04, 2025 at 05:27:14PM -0500, Frank Li wrote:
> > > > Add child node nand@0 and move NAND related property under it to align
> > > > modern nand-controller.yaml.
> > > >
> > > > Fix below CHECK_DTBS warnings:
> > > > arch/arm/boot/dts/nxp/imx/imx6ull-colibri-aster.dtb: nand-controller@1806000 (fsl,imx6q-gpmi-nand): Unevaluated properties are not allowed ('nand-ecc-mode', 'nand-ecc-step-size', 'nand-ecc-strength', 'nand-on-flash-bbt' were unexpected)
> > > > from schema $id: http://devicetree.org/schemas/mtd/gpmi-nand.yaml#
> > > >
> > > > Since 2019 year, commit
> > > > (212e496935929 dt-bindings: mtd: Add YAML schemas for the generic NAND options)
> > > > NAND related property is preferred located under nand@<n> even though only
> > > > one NAND chip supported.
> > > >
> > > > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > > > ---
> > > > arch/arm/boot/dts/nxp/imx/imx6-logicpd-som.dtsi | 6 +++++-
> > > > arch/arm/boot/dts/nxp/imx/imx6qdl-icore.dtsi | 6 +++++-
> > > > arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-pfla02.dtsi | 6 +++++-
> > > > arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-phycore-som.dtsi | 6 +++++-
> > > > arch/arm/boot/dts/nxp/imx/imx6qdl-skov-cpu.dtsi | 6 +++++-
> > > > arch/arm/boot/dts/nxp/imx/imx6qdl-tx6.dtsi | 6 +++++-
> > > > arch/arm/boot/dts/nxp/imx/imx6ul-geam.dts | 6 +++++-
> > > > arch/arm/boot/dts/nxp/imx/imx6ul-isiot.dtsi | 6 +++++-
> > > > arch/arm/boot/dts/nxp/imx/imx6ul-phytec-phycore-som.dtsi | 6 +++++-
> > > > arch/arm/boot/dts/nxp/imx/imx6ul-tx6ul.dtsi | 6 +++++-
> > > > arch/arm/boot/dts/nxp/imx/imx6ull-colibri.dtsi | 12 ++++++++----
> > > > arch/arm/boot/dts/nxp/imx/imx6ull-engicam-microgea.dtsi | 12 ++++++++----
> > > > arch/arm/boot/dts/nxp/imx/imx6ull-myir-mys-6ulx.dtsi | 6 +++++-
> > > > arch/arm/boot/dts/nxp/imx/imx6ulz-bsh-smm-m2.dts | 6 +++++-
> > > > arch/arm/boot/dts/nxp/imx/imx7-colibri.dtsi | 8 ++++++--
> > > > 15 files changed, 82 insertions(+), 22 deletions(-)
> > > >
> > >
> > > Was any of these changes tested? Is the driver able to cope with the
> > > binding change?
> >
> > I have not board to do direct test. This format is used at imx8 platform,
> > which use the same gpmi driver.
> >
> > This properties are parsed at mtd common part
> > drivers/mtd/nand/raw/nand_base.c
> >
> > If you have one of above board to test it, it will be appericated.
>
> I did a minimal boot test, on colibri-imx6ull, and the board was booting
> fine, with Linux 6.18.0-rc4 and this patch applied.
>
> I am wondering if there is any impact with the bootloader, this DT is
> used as it is also in U-Boot, and there the NAND driver is for sure
> different. Any comment on this? I was not able to test this combination.
Uboot should have theirself tree, which copy dts and not direct use it.
I worry uboot parser kernel's dtb to do some hot fix for specific boards.
But most likely not related these proptetry, maybe just add partitions.
Frank
>
> Francesco
>
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 3/3] ARM: dts: imx: move nand related property under nand@0
2025-11-10 16:12 ` Frank Li
@ 2025-11-11 7:21 ` Francesco Dolcini
2025-11-11 10:09 ` Krzysztof Kozlowski
1 sibling, 0 replies; 11+ messages in thread
From: Francesco Dolcini @ 2025-11-11 7:21 UTC (permalink / raw)
To: Frank Li
Cc: Francesco Dolcini, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
devicetree, imx, linux-arm-kernel, linux-kernel
On Mon, Nov 10, 2025 at 11:12:49AM -0500, Frank Li wrote:
> On Fri, Nov 07, 2025 at 04:52:01PM +0100, Francesco Dolcini wrote:
> > Hello Frank,
> >
> > On Wed, Nov 05, 2025 at 10:29:05AM -0500, Frank Li wrote:
> > > On Wed, Nov 05, 2025 at 12:55:38PM +0100, Francesco Dolcini wrote:
> > > > On Tue, Nov 04, 2025 at 05:27:14PM -0500, Frank Li wrote:
> > > > > Add child node nand@0 and move NAND related property under it to align
> > > > > modern nand-controller.yaml.
> > > > >
> > > > > Fix below CHECK_DTBS warnings:
> > > > > arch/arm/boot/dts/nxp/imx/imx6ull-colibri-aster.dtb: nand-controller@1806000 (fsl,imx6q-gpmi-nand): Unevaluated properties are not allowed ('nand-ecc-mode', 'nand-ecc-step-size', 'nand-ecc-strength', 'nand-on-flash-bbt' were unexpected)
> > > > > from schema $id: http://devicetree.org/schemas/mtd/gpmi-nand.yaml#
> > > > >
> > > > > Since 2019 year, commit
> > > > > (212e496935929 dt-bindings: mtd: Add YAML schemas for the generic NAND options)
> > > > > NAND related property is preferred located under nand@<n> even though only
> > > > > one NAND chip supported.
> > > > >
> > > > > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > > > > ---
> > > > > arch/arm/boot/dts/nxp/imx/imx6-logicpd-som.dtsi | 6 +++++-
> > > > > arch/arm/boot/dts/nxp/imx/imx6qdl-icore.dtsi | 6 +++++-
> > > > > arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-pfla02.dtsi | 6 +++++-
> > > > > arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-phycore-som.dtsi | 6 +++++-
> > > > > arch/arm/boot/dts/nxp/imx/imx6qdl-skov-cpu.dtsi | 6 +++++-
> > > > > arch/arm/boot/dts/nxp/imx/imx6qdl-tx6.dtsi | 6 +++++-
> > > > > arch/arm/boot/dts/nxp/imx/imx6ul-geam.dts | 6 +++++-
> > > > > arch/arm/boot/dts/nxp/imx/imx6ul-isiot.dtsi | 6 +++++-
> > > > > arch/arm/boot/dts/nxp/imx/imx6ul-phytec-phycore-som.dtsi | 6 +++++-
> > > > > arch/arm/boot/dts/nxp/imx/imx6ul-tx6ul.dtsi | 6 +++++-
> > > > > arch/arm/boot/dts/nxp/imx/imx6ull-colibri.dtsi | 12 ++++++++----
> > > > > arch/arm/boot/dts/nxp/imx/imx6ull-engicam-microgea.dtsi | 12 ++++++++----
> > > > > arch/arm/boot/dts/nxp/imx/imx6ull-myir-mys-6ulx.dtsi | 6 +++++-
> > > > > arch/arm/boot/dts/nxp/imx/imx6ulz-bsh-smm-m2.dts | 6 +++++-
> > > > > arch/arm/boot/dts/nxp/imx/imx7-colibri.dtsi | 8 ++++++--
> > > > > 15 files changed, 82 insertions(+), 22 deletions(-)
> > > > >
> > > >
> > > > Was any of these changes tested? Is the driver able to cope with the
> > > > binding change?
> > >
> > > I have not board to do direct test. This format is used at imx8 platform,
> > > which use the same gpmi driver.
> > >
> > > This properties are parsed at mtd common part
> > > drivers/mtd/nand/raw/nand_base.c
> > >
> > > If you have one of above board to test it, it will be appericated.
> >
> > I did a minimal boot test, on colibri-imx6ull, and the board was booting
> > fine, with Linux 6.18.0-rc4 and this patch applied.
> >
> > I am wondering if there is any impact with the bootloader, this DT is
> > used as it is also in U-Boot, and there the NAND driver is for sure
> > different. Any comment on this? I was not able to test this combination.
>
> Uboot should have theirself tree, which copy dts and not direct use it.
> I worry uboot parser kernel's dtb to do some hot fix for specific boards.
> But most likely not related these proptetry, maybe just add partitions.
U-Boot just sync the device tree from Linux, copying those, for some
boards (depending on the usage of the so called OF_UPSTREAM).
You cannot think at this change affecting only Linux.
Francesco
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 3/3] ARM: dts: imx: move nand related property under nand@0
2025-11-10 16:12 ` Frank Li
2025-11-11 7:21 ` Francesco Dolcini
@ 2025-11-11 10:09 ` Krzysztof Kozlowski
1 sibling, 0 replies; 11+ messages in thread
From: Krzysztof Kozlowski @ 2025-11-11 10:09 UTC (permalink / raw)
To: Frank Li, Francesco Dolcini
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, devicetree,
imx, linux-arm-kernel, linux-kernel
On 10/11/2025 17:12, Frank Li wrote:
> On Fri, Nov 07, 2025 at 04:52:01PM +0100, Francesco Dolcini wrote:
>> Hello Frank,
>>
>> On Wed, Nov 05, 2025 at 10:29:05AM -0500, Frank Li wrote:
>>> On Wed, Nov 05, 2025 at 12:55:38PM +0100, Francesco Dolcini wrote:
>>>> On Tue, Nov 04, 2025 at 05:27:14PM -0500, Frank Li wrote:
>>>>> Add child node nand@0 and move NAND related property under it to align
>>>>> modern nand-controller.yaml.
>>>>>
>>>>> Fix below CHECK_DTBS warnings:
>>>>> arch/arm/boot/dts/nxp/imx/imx6ull-colibri-aster.dtb: nand-controller@1806000 (fsl,imx6q-gpmi-nand): Unevaluated properties are not allowed ('nand-ecc-mode', 'nand-ecc-step-size', 'nand-ecc-strength', 'nand-on-flash-bbt' were unexpected)
>>>>> from schema $id: http://devicetree.org/schemas/mtd/gpmi-nand.yaml#
>>>>>
>>>>> Since 2019 year, commit
>>>>> (212e496935929 dt-bindings: mtd: Add YAML schemas for the generic NAND options)
>>>>> NAND related property is preferred located under nand@<n> even though only
>>>>> one NAND chip supported.
>>>>>
>>>>> Signed-off-by: Frank Li <Frank.Li@nxp.com>
>>>>> ---
>>>>> arch/arm/boot/dts/nxp/imx/imx6-logicpd-som.dtsi | 6 +++++-
>>>>> arch/arm/boot/dts/nxp/imx/imx6qdl-icore.dtsi | 6 +++++-
>>>>> arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-pfla02.dtsi | 6 +++++-
>>>>> arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-phycore-som.dtsi | 6 +++++-
>>>>> arch/arm/boot/dts/nxp/imx/imx6qdl-skov-cpu.dtsi | 6 +++++-
>>>>> arch/arm/boot/dts/nxp/imx/imx6qdl-tx6.dtsi | 6 +++++-
>>>>> arch/arm/boot/dts/nxp/imx/imx6ul-geam.dts | 6 +++++-
>>>>> arch/arm/boot/dts/nxp/imx/imx6ul-isiot.dtsi | 6 +++++-
>>>>> arch/arm/boot/dts/nxp/imx/imx6ul-phytec-phycore-som.dtsi | 6 +++++-
>>>>> arch/arm/boot/dts/nxp/imx/imx6ul-tx6ul.dtsi | 6 +++++-
>>>>> arch/arm/boot/dts/nxp/imx/imx6ull-colibri.dtsi | 12 ++++++++----
>>>>> arch/arm/boot/dts/nxp/imx/imx6ull-engicam-microgea.dtsi | 12 ++++++++----
>>>>> arch/arm/boot/dts/nxp/imx/imx6ull-myir-mys-6ulx.dtsi | 6 +++++-
>>>>> arch/arm/boot/dts/nxp/imx/imx6ulz-bsh-smm-m2.dts | 6 +++++-
>>>>> arch/arm/boot/dts/nxp/imx/imx7-colibri.dtsi | 8 ++++++--
>>>>> 15 files changed, 82 insertions(+), 22 deletions(-)
>>>>>
>>>>
>>>> Was any of these changes tested? Is the driver able to cope with the
>>>> binding change?
>>>
>>> I have not board to do direct test. This format is used at imx8 platform,
>>> which use the same gpmi driver.
>>>
>>> This properties are parsed at mtd common part
>>> drivers/mtd/nand/raw/nand_base.c
>>>
>>> If you have one of above board to test it, it will be appericated.
>>
>> I did a minimal boot test, on colibri-imx6ull, and the board was booting
>> fine, with Linux 6.18.0-rc4 and this patch applied.
>>
>> I am wondering if there is any impact with the bootloader, this DT is
>> used as it is also in U-Boot, and there the NAND driver is for sure
>> different. Any comment on this? I was not able to test this combination.
>
> Uboot should have theirself tree, which copy dts and not direct use it.
Sorry, but what? No they shall not.
There is only one DTS. For all upstream users following kernel style,
which includes BSD and U-boot and probably many more.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2025-11-11 10:09 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-04 22:27 [PATCH 0/3] ARM: dts: imx: cleanup most gpmi related CHECK_DTB warning Frank Li
2025-11-04 22:27 ` [PATCH 1/3] ARM: dts: imx6qdl: add '#address-cells' and '#size-cells' for gpmi-nand Frank Li
2025-11-04 22:27 ` [PATCH 2/3] ARM: dts: imx6sx: update gpmi #size-cells to 0 Frank Li
2025-11-04 22:27 ` [PATCH 3/3] ARM: dts: imx: move nand related property under nand@0 Frank Li
2025-11-05 11:55 ` Francesco Dolcini
2025-11-05 15:29 ` Frank Li
2025-11-07 15:52 ` Francesco Dolcini
2025-11-10 16:12 ` Frank Li
2025-11-11 7:21 ` Francesco Dolcini
2025-11-11 10:09 ` Krzysztof Kozlowski
2025-11-05 2:07 ` [PATCH 0/3] ARM: dts: imx: cleanup most gpmi related CHECK_DTB warning Peng Fan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).