From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 16D06C4332F for ; Wed, 2 Nov 2022 16:27:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:Reply-To:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:Subject: From:MIME-Version:Date:Message-ID:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FKQLHKW2dFyIclB67J9sQ8BCVvmBxnw4REglNlB6OqY=; b=Cgef/8Gt3XXVzhIPYIzfaMUu80 5QJPOZUCzCd4LH68/ScsFD0liKCNwMkFHq658gLRvVGiqPa4+ErT9fWguzLmRILsfjUbUuCjSGUb3 crjQ/0vVwTsribPe6mnng1+JShZsW5avvYuYKVFEdd2f0DGDMYViL5n5ELvG1+HHp0C4t/zGQ4cZZ GeH3C01CE4zZ8BPkTOvBo9q/6oZX5ld8EKrlPMCI/ddLXTPXYl6hs3k6pTbF8vEWCIfRHH28BYBsf 0JMS0M0SqEDUKaaYhy7VswNkI7MwGLAMhxt07J/NFUMCn4NwS4VPq0ezMuyhN8/LOjZE53QVLB05b OFQ79fPQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oqGZM-00C7a4-HE; Wed, 02 Nov 2022 16:26:24 +0000 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oqGZJ-00C7XF-4W for linux-arm-kernel@lists.infradead.org; Wed, 02 Nov 2022 16:26:22 +0000 Received: by mail-wm1-x32c.google.com with SMTP id t4so10988772wmj.5 for ; Wed, 02 Nov 2022 09:26:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=zv7Fq5k50QWQLxnPbss2vXizhHRaHgo0CLWyEMOtNXY=; b=XLT+2bOf52xM6JdQqN+Tbi3UN/LLLCaptLMtL5KvSTYPvI/lUr4ONN2+m47aatNmUE rdrtReOAY4RmLpenQiqcMEofRRUhxktec1oIjlF4j6H6wmkxi5XEDnpOZ9QGJaSBxv+F LhWZTjMyJ0KzHsT2tice4ZplDy8smvhGjPpxQ+xekviGu2gOZfr+P+dYshaOnkeqsqVi uLKwI/Sm12ueV22i0iRvO64/ABCyk4cZb6c2neFCEhma60LYtaOmfJBEUoWMY7xkEKJ/ WLGsayqA2AIVW/hhoObdJU0oqJ/+fBkdyyFvsfYKhIOtXxaDfx5ozca5oUxePLiG0MUO U5Rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zv7Fq5k50QWQLxnPbss2vXizhHRaHgo0CLWyEMOtNXY=; b=fUVncreEa/MDSiRbSn/NU2IOFmQkkM8HIvt/zWHGnADCePK/edRo7opkDydAGhnNgu uIbBPHZH3E6I9ttGRlABPeOSbZcer2A1w8QyA/n+9qXZil3lbBnq8yzN+6/pMZ2TQYj1 kt6jfnKGWrdRC1iGnZFbsFQ7pP8+rK/cylVhJF8oVCqQASbyUtAonUEB0CyLAmEezJJt wYRxKe3Ol+b8uMeQd0dGg927dCv0touMZHii7bbgqIi7cgZRezF7Yy/CvXmaRVZmxlbH jKlKsAm5EP3VjUK+cjZFBHvh/wqy+EwMMWrOFeWpNJmKCH3j0PAmNByZvaw6+JcO6rI1 bBdg== X-Gm-Message-State: ACrzQf2KLqXhJfO6rnPwArHXUvhS0Vzk1KoMolSfXKNSm6b2Ed515lP7 xnzf1R/k51EIq5Z/cCZowgUTOg== X-Google-Smtp-Source: AMsMyM58DL/hkAn4DnGcSmAn4Lnobs2eqhlbRBLy1/I33qod5riKNI2cBWPxvRt82gxskj2IR0PZIw== X-Received: by 2002:a05:600c:4ed1:b0:3cf:86ab:3a0f with SMTP id g17-20020a05600c4ed100b003cf86ab3a0fmr2853053wmq.106.1667406377451; Wed, 02 Nov 2022 09:26:17 -0700 (PDT) Received: from ?IPV6:2a01:e0a:982:cbb0:3541:e8cb:4c8c:e204? ([2a01:e0a:982:cbb0:3541:e8cb:4c8c:e204]) by smtp.gmail.com with ESMTPSA id v7-20020a05600c444700b003c70191f267sm2844571wmn.39.2022.11.02.09.26.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Nov 2022 09:26:17 -0700 (PDT) Message-ID: Date: Wed, 2 Nov 2022 17:26:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 From: Neil Armstrong Subject: Re: [PATCH 1/4] dt-bindings: reset: document Odroid Go Ultra power-off Content-Language: en-US To: Rob Herring Cc: Martin Blumenstingl , Krzysztof Kozlowski , Kevin Hilman , Sebastian Reichel , Jerome Brunet , linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org References: <20221031-b4-odroid-go-ultra-initial-v1-0-42e3dbea86d5@linaro.org> <20221031-b4-odroid-go-ultra-initial-v1-1-42e3dbea86d5@linaro.org> <20221102162344.GA3993882-robh@kernel.org> Organization: Linaro Developer Services In-Reply-To: <20221102162344.GA3993882-robh@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221102_092621_240734_ADCB5C33 X-CRM114-Status: GOOD ( 18.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: neil.armstrong@linaro.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On 02/11/2022 17:23, Rob Herring wrote: > On Mon, Oct 31, 2022 at 05:47:25PM +0100, Neil Armstrong wrote: >> The Hardkernel Odroid Go Ultra poweroff scheme requires requesting a poweroff >> to its two PMICs in order, this represents the poweroff scheme needed to complet >> a clean poeroff of the system. >> >> Signed-off-by: Neil Armstrong >> --- >> .../reset/hardkernel,odroid-go-ultra-poweroff.yaml | 42 ++++++++++++++++++++++ >> 1 file changed, 42 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/power/reset/hardkernel,odroid-go-ultra-poweroff.yaml b/Documentation/devicetree/bindings/power/reset/hardkernel,odroid-go-ultra-poweroff.yaml >> new file mode 100644 >> index 000000000000..65e42258717c >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/power/reset/hardkernel,odroid-go-ultra-poweroff.yaml >> @@ -0,0 +1,42 @@ >> +# SPDX-License-Identifier: GPL-2.0 >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/power/reset/hardkernel,odroid-go-ultra-poweroff.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Hardkernel Odroid Go Ultra poweroff >> + >> +maintainers: >> + - Neil Armstrong >> + >> +description: >> + The Hardkernel Odroid Go Ultra poweroff scheme requires requesting a poweroff >> + to its two PMICs in order, this represents the poweroff scheme needed to complete >> + a clean poeroff of the system. > > You don't really need a node for this. Test against the top level > compatible and then find the PMIC nodes by their compatible strings. Hmm ok, indeed would be simpler. Neil > >> + >> +properties: >> + compatible: >> + const: hardkernel,odroid-go-ultra-poweroff >> + >> + hardkernel,rk817-pmic: >> + $ref: /schemas/types.yaml#/definitions/phandle >> + description: Phandle to the RK817 PMIC node >> + >> + hardkernel,rk818-pmic: >> + $ref: /schemas/types.yaml#/definitions/phandle >> + description: Phandle to the RK818 PMIC node >> + >> +required: >> + - compatible >> + - hardkernel,rk817-pmic >> + - hardkernel,rk818-pmic >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + poweroff { >> + compatible = "hardkernel,odroid-go-ultra-poweroff"; >> + hardkernel,rk817-pmic = <&rk817>; >> + hardkernel,rk818-pmic = <&rk818>; >> + }; >> >> -- >> b4 0.10.1 >> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel