From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 16A54C4332F for ; Thu, 15 Dec 2022 20:16:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=L5+uL8Ux0FPyrz4V8e9oCdeQPgSVDNGqvb4R0XbH/Ns=; b=oCx2fduEGrUeRP 1ZO17y/27t5UHoljUCd5dRMzbXzLdIhOmCHFKnFOh+I91sCpqTdNdTcx3oNq6o1UC8GQ1eTBCZRjp wTP/zo+JlFazknGc88Lm25qIaQsph5dHozGeiugpc7oQCT6AIOa0ay2aXU5LRZAHD9JqxdRaYh5EK usfrikY6ukShDj56ZbrqMyXV8Mu+oWg2liDppyEbm0tf8XaCn2H2y4530qakH0m3QdnkzfAdNf82g KKLuJtjNNd4+RGsnfRkC1TrKm/RBRpVXy0dHizAhFFBmRHtPgwEZ7VjFMinES0CwOMqQhK6yw0Ipq kZ9inyqJLMfd/s72RNQQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p5udo-00BCbK-HB; Thu, 15 Dec 2022 20:15:40 +0000 Received: from mail-yw1-x112d.google.com ([2607:f8b0:4864:20::112d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p5udj-00BCa1-R7 for linux-arm-kernel@lists.infradead.org; Thu, 15 Dec 2022 20:15:38 +0000 Received: by mail-yw1-x112d.google.com with SMTP id 00721157ae682-3f15a6f72d0so5603287b3.1 for ; Thu, 15 Dec 2022 12:15:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=iK4o9jLvL400oAI7gEBPMmyw5mH/OfCQsL+GJz6EUHE=; b=FYpzgSu9zxFCEB9DpsLOEbzthnkgW6+UtEfzlgYsMp+oEloOnYVB6FsMTKHc8ef7Ol zvgSd0UaFf+unzNSBr8vkWFSnPGwxktncmDM0+ftf3XHHXdd9RyUEUiylE5Rs67rpd0o xc0OTHWKVJ0cXXCP9bJJ5uBVEt/5uniVJtRnTw1MqpUj8Dd9eOgkL5qkQ9zq5BxVXGmj ZqpO9fFkNYxbJqSUSNm7xBnEtPqaE0ktyBkbKXceEOCdOeDagmEVLgqHP+E8yDer/tdQ UGocSBQ8f7Xn0aWerfyeTmQkjqf06ZBbe7hHoQB+iDt7r333slCqxyV2qG4W5Kx+XZ9E eysw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iK4o9jLvL400oAI7gEBPMmyw5mH/OfCQsL+GJz6EUHE=; b=psLwZLm7IWAmXLaicXywvbz+Do3LLM842TDK2Dzbt1Yr/+ISBHKjKomJSHcDdKAFn3 G3bppRmBH3j+YUoG6yVjvdjJq/lZIcSl1vLOeZ4+fRFb5uPYlct1364uD73dhUA9j82e rSoMltGm/YQmlMGWCxNM5CR9TBMN+iYY2yU9V1Hf2oj5hSiSF2FASfT6mgodNoOUCTpL tYNsLZq1JYN9jzLMWFomHm+xPtu+M8/OFqSsDYuUeGthHztcIjpunJ/KG3A7R+VTXcve YMcRROy8akyb5H+xlROqfQ/rhD2LhMGC8PDfhfp9pKGoJ99/AWu2OJq7UGM0PWUr5qnz HFOQ== X-Gm-Message-State: ANoB5pl81IBzMfFRVC1dn9bNGhGUVbY7PWXoW/BPkKId0uESY03MUyXM XvbZq/LCqrqer52HCbqW2ng= X-Google-Smtp-Source: AA0mqf5kqRcoR1s9S1eHc44XGjbfjpzsT1/6GNL5vrgogObGEBdPweTHjesvj8jJUu38rHm17qyBbw== X-Received: by 2002:a81:9c7:0:b0:36b:eafd:ca50 with SMTP id 190-20020a8109c7000000b0036beafdca50mr34291075ywj.52.1671135331232; Thu, 15 Dec 2022 12:15:31 -0800 (PST) Received: from [10.4.10.38] (pool-108-26-182-112.bstnma.fios.verizon.net. [108.26.182.112]) by smtp.gmail.com with ESMTPSA id c15-20020ae9ed0f000000b006e702033b15sm12450949qkg.66.2022.12.15.12.15.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Dec 2022 12:15:30 -0800 (PST) Message-ID: Date: Thu, 15 Dec 2022 15:15:29 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] clk: imx: fix compile testing imxrt1050 Content-Language: en-US To: Arnd Bergmann , Abel Vesa , Michael Turquette , Stephen Boyd , Shawn Guo , Sascha Hauer Cc: Arnd Bergmann , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Peng Fan , Giulio Benetti , Dario Binacchi , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20221215165836.2136448-1-arnd@kernel.org> From: Jesse Taube In-Reply-To: <20221215165836.2136448-1-arnd@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221215_121535_912252_528ABE6C X-CRM114-Status: GOOD ( 24.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12/15/22 11:58, Arnd Bergmann wrote: > From: Arnd Bergmann > > Randconfig testing revealed multiple issues with this driver: > > ERROR: modpost: missing MODULE_LICENSE() in drivers/clk/imx/clk-imxrt1050.o > ERROR: modpost: "imx_clk_hw_pllv3" [drivers/clk/imx/clk-imxrt1050.ko] undefined! > ERROR: modpost: "imx_clk_hw_pfd" [drivers/clk/imx/clk-imxrt1050.ko] undefined! > > Export the necessary symbols from the core clk driver and add the > license and author tags. To find this type of problem more easily > in the future, also enable building on other platforms, as we do for > the other i.MX clk drivers. > > Signed-off-by: Arnd Bergmann > --- > drivers/clk/imx/Kconfig | 2 +- > drivers/clk/imx/clk-imxrt1050.c | 4 ++++ > drivers/clk/imx/clk-pfd.c | 2 ++ > drivers/clk/imx/clk-pllv3.c | 2 ++ > 4 files changed, 9 insertions(+), 1 deletion(-) > > diff --git a/drivers/clk/imx/Kconfig b/drivers/clk/imx/Kconfig > index 25785ec9c276..f6b82e0b9703 100644 > --- a/drivers/clk/imx/Kconfig > +++ b/drivers/clk/imx/Kconfig > @@ -115,7 +115,7 @@ config CLK_IMX93 > > config CLK_IMXRT1050 > tristate "IMXRT1050 CCM Clock Driver" > - depends on SOC_IMXRT > + depends on SOC_IMXRT || COMPILE_TEST Not sure what COMPILE_TEST is but, Acked-by: Jesse Taube Sorry about the issues introduced. Thanks, Jesse Taube > select MXC_CLK > help > Build the driver for i.MXRT1050 CCM Clock Driver > diff --git a/drivers/clk/imx/clk-imxrt1050.c b/drivers/clk/imx/clk-imxrt1050.c > index e972abd299a8..fd5c51fc92c0 100644 > --- a/drivers/clk/imx/clk-imxrt1050.c > +++ b/drivers/clk/imx/clk-imxrt1050.c > @@ -167,3 +167,7 @@ static struct platform_driver imxrt1050_clk_driver = { > }, > }; > module_platform_driver(imxrt1050_clk_driver); > + > +MODULE_LICENSE("Dual BSD/GPL"); > +MODULE_AUTHOR("Jesse Taube "); > +MODULE_AUTHOR("Giulio Benetti "); > diff --git a/drivers/clk/imx/clk-pfd.c b/drivers/clk/imx/clk-pfd.c > index 5d2a9a3be95e..5cf0149dfa15 100644 > --- a/drivers/clk/imx/clk-pfd.c > +++ b/drivers/clk/imx/clk-pfd.c > @@ -5,6 +5,7 @@ > */ > > #include > +#include > #include > #include > #include > @@ -153,3 +154,4 @@ struct clk_hw *imx_clk_hw_pfd(const char *name, const char *parent_name, > > return hw; > } > +EXPORT_SYMBOL_GPL(imx_clk_hw_pfd); > diff --git a/drivers/clk/imx/clk-pllv3.c b/drivers/clk/imx/clk-pllv3.c > index eea32f87c60a..11fb238ee8f0 100644 > --- a/drivers/clk/imx/clk-pllv3.c > +++ b/drivers/clk/imx/clk-pllv3.c > @@ -6,6 +6,7 @@ > > #include > #include > +#include > #include > #include > #include > @@ -486,3 +487,4 @@ struct clk_hw *imx_clk_hw_pllv3(enum imx_pllv3_type type, const char *name, > > return hw; > } > +EXPORT_SYMBOL_GPL(imx_clk_hw_pllv3); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel