From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 81AB8C433EF for ; Thu, 7 Jul 2022 06:20:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EnqOynvSJyJLNyESWTkjgveQ11/ViqfMzyc5KOxJz8I=; b=wUPI2ZxJzsMyh1 US5I/b07nluc0JNMq+iZSUMSPi4INBbKGzytkhgKwSvSQ+dVZIqVdpQQHvbyT8yEDd+lhmcL/Cb1X 55Mrm34pJ7zns8Swd8onXrizA7XU76pvyYv/QjOvFs3kb23gMLwZsiyBB4+DRQRaxtYj2x49H7Sn+ iIrzzxEFq9YCtg+xd9IGXqEJ7GqwtyTUxl4wxNaw3RYXf+iXrwc582jlSvKVFv5F8ljmfvhb5IZbr 3pTeUmo66Thv6Hf3Xs+y6LnNLymtbCOtx13k3RYJh76TIwyeXJcc0zhrLiGaf8kr5GVYeIQwRlju1 n+b9PIrr5sBRPPI5PUig==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o9Kr8-00Dxp7-Ig; Thu, 07 Jul 2022 06:19:18 +0000 Received: from mail-lf1-x12d.google.com ([2a00:1450:4864:20::12d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o9Kr5-00Dxj8-BD for linux-arm-kernel@lists.infradead.org; Thu, 07 Jul 2022 06:19:16 +0000 Received: by mail-lf1-x12d.google.com with SMTP id e12so29417164lfr.6 for ; Wed, 06 Jul 2022 23:19:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=hu5UjHiJ+bwaBYMGAryVawqznhB30VuU79LnyvZFUMw=; b=JNp0Rwnl+SSoqs6qNOAEWXREGt6UlkNQkuecqWBJLD9ZJR/ibvstoD0e45BHSrl+Xw YM1HAqpYoC2lXg8QaXtGlNtCgTuiHomMfowFZF+3Tmos8azDdxrp0kyxJozCvDTzOrFs m96/x6ff2el1Y57xpRLqrGnln1v+oercSODRBjeqpPQpIGkvoXvF0DzHL4UsvX5AB+6R 5e61fvxg5C0Unpt2AX1/9yD3UAJ3d+/xV3q06XPS0aXmz3eKzW+lhWrXtaAbZ7eS5BMa /r7DPHTmt4MnHoDgf9PMRlkZO95RgxwijHedqmyDloO+D7D90qH8LQR8t6oVNGshqGf8 OVlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=hu5UjHiJ+bwaBYMGAryVawqznhB30VuU79LnyvZFUMw=; b=7BYRHbW9nPuH/qI9RHqMNyvgY+PG+ZW8DM92tL+uy0VEWHa05mVT1cJsF6sw0TyH4U zQk+D8nHIrezjW7zK+0eMFeuAZ/ii8ezuRtgWpm9G2hpY1sLIaf1gx37a7HOtFoimmIs jedTr9165N256HNpQAMzKBkXHIJ11raYW3Ue9mrW0SISdJOX/e5BdrAjMMbc+w4G1DI/ a5iDNsZ+b0HAU3Q3NSCzMwQnWKtUg6wZMMOFyCLS2/SsIGwmNi4SfsMBHShjKXQ7GsvQ MdR6Bew/ljievMdbrlKA4+yhHefqk3yEBvCsFQtCeO2SSYDCHrNPrmdz/K6BARUqnND+ Fpyw== X-Gm-Message-State: AJIora+dUxlqMxYuDg5GC8z9O5DcPm0N/LeUfQ4eEb8ZxM21opr7ZnfO 4R/RMaLloaFPhZtLmuOmyzw42Q== X-Google-Smtp-Source: AGRyM1uviZn/Ui2JM9JTF4A7nVpBIeYAn+SP8Qcua3Czg37Jnoz7oFZB26ttHQaS+IPboCj+0LM5TA== X-Received: by 2002:ac2:4941:0:b0:485:da81:6c95 with SMTP id o1-20020ac24941000000b00485da816c95mr4851170lfi.368.1657174750665; Wed, 06 Jul 2022 23:19:10 -0700 (PDT) Received: from [192.168.1.52] ([84.20.121.239]) by smtp.gmail.com with ESMTPSA id j2-20020a056512344200b0047255d21107sm171772lfr.54.2022.07.06.23.19.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Jul 2022 23:19:10 -0700 (PDT) Message-ID: Date: Thu, 7 Jul 2022 08:19:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] dt-bindings: phy: samsung,ufs-phy: match clock items Content-Language: en-US To: Chanho Park , Krzysztof Kozlowski , Rob Herring Cc: Alim Akhtar , devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20220707005554.98268-1-chanho61.park@samsung.com> From: Krzysztof Kozlowski In-Reply-To: <20220707005554.98268-1-chanho61.park@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220706_231915_453243_3870A22F X-CRM114-Status: GOOD ( 15.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 07/07/2022 02:55, Chanho Park wrote: > Below error is detected from dtbs_check. exynos7-ufs-phy is required > symbol clocks otherwise only PLL ref clock is required. > > clock-names: ['ref_clk'] is too short Thank you for your patch. There is something to discuss/improve. > > Reported-by: Krzysztof Kozlowski > Suggested-by: Krzysztof Kozlowski > Suggested-by: Alim Akhtar > Signed-off-by: Chanho Park > --- > .../bindings/phy/samsung,ufs-phy.yaml | 47 +++++++++++++++---- > 1 file changed, 37 insertions(+), 10 deletions(-) > > diff --git a/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml b/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml > index 8da99461e817..3b04f31d9f21 100644 > --- a/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml > @@ -27,18 +27,12 @@ properties: > - const: phy-pma > > clocks: > - items: > - - description: PLL reference clock > - - description: symbol clock for input symbol ( rx0-ch0 symbol clock) > - - description: symbol clock for input symbol ( rx1-ch1 symbol clock) > - - description: symbol clock for output symbol ( tx0 symbol clock) > + minItems: 1 > + maxItems: 4 > > clock-names: > - items: > - - const: ref_clk > - - const: rx1_symbol_clk > - - const: rx0_symbol_clk > - - const: tx0_symbol_clk > + minItems: 1 > + maxItems: 4 > > samsung,pmu-syscon: > $ref: '/schemas/types.yaml#/definitions/phandle-array' > @@ -53,6 +47,39 @@ properties: > It can be phandle/offset pair. The second cell which can represent an > offset is optional. > > +allOf: The allOf block should go after "required" block. > + - if: > + properties: > + compatible: > + contains: > + const: samsung,exynos7-ufs-phy > + > + then: > + properties: > + clocks: > + items: > + - description: PLL reference clock > + - description: symbol clock for input symbol ( rx0-ch0 symbol clock) > + - description: symbol clock for input symbol ( rx1-ch1 symbol clock) > + - description: symbol clock for output symbol ( tx0 symbol clock) While moving drop space after '('. > + > + clock-names: > + items: > + - const: ref_clk > + - const: rx1_symbol_clk > + - const: rx0_symbol_clk > + - const: tx0_symbol_clk > + > + else: > + properties: > + clocks: > + items: > + - description: PLL reference clock > + > + clock-names: > + items: > + - const: ref_clk > + > required: > - "#phy-cells" > - compatible Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel