[PATCH] arm64: dts: imx8mm: Add SNVS LPGPR on Data Modul i.MX8M Mini eDM SBC

[PATCH] arm64: dts: imx8mm: Add SNVS LPGPR on Data Modul i.MX8M Mini eDM SBC

[Marek Vasut]

Add SNVS LPGPR bindings on this system, the LPGPR is used to store
boot counter.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Fabio Estevam <festevam@denx.de>
Cc: Peng Fan <peng.fan@nxp.com>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: NXP Linux Team <linux-imx@nxp.com>
To: linux-arm-kernel@lists.infradead.org
---
NOTE: Depends on
      https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git/commit/?h=for-next&id=fee6de80bdd3df976a43f3092a165cb43c072f20
---
 arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts b/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts
index 778bdbe228d31..93f14afc1f8a9 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts
@@ -928,6 +928,12 @@ &sai5 {
 	status = "disabled";
 };
 
+&snvs {
+	snvs-lpgpr {
+		compatible = "fsl,imx8mm-snvs-lpgpr", "fsl,imx7d-snvs-lpgpr";
+	};
+};
+
 &uart1 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_uart1>;
-- 
2.35.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] arm64: dts: imx8mm: Add SNVS LPGPR on Data Modul i.MX8M Mini eDM SBC

[Fabio Estevam]

On 22/05/2022 14:57, Marek Vasut wrote:
> Add SNVS LPGPR bindings on this system, the LPGPR is used to store
> boot counter.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Fabio Estevam <festevam@denx.de>
> Cc: Peng Fan <peng.fan@nxp.com>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: NXP Linux Team <linux-imx@nxp.com>
> To: linux-arm-kernel@lists.infradead.org
> ---
> NOTE: Depends on
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git/commit/?h=for-next&id=fee6de80bdd3df976a43f3092a165cb43c072f20

Reviewed-by: Fabio Estevam <festevam@denx.de>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: (EXT) [PATCH] arm64: dts: imx8mm: Add SNVS LPGPR on Data Modul i.MX8M Mini eDM SBC

[Alexander Stein]

Hi Marek,

Am Sonntag, 22. Mai 2022, 19:57:23 CEST schrieb Marek Vasut:
> Add SNVS LPGPR bindings on this system, the LPGPR is used to store
> boot counter.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Fabio Estevam <festevam@denx.de>
> Cc: Peng Fan <peng.fan@nxp.com>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: NXP Linux Team <linux-imx@nxp.com>
> To: linux-arm-kernel@lists.infradead.org
> ---
> NOTE: Depends on
>      
> https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git/commit/?h=fo
> r-next&id=fee6de80bdd3df976a43f3092a165cb43c072f20 ---
>  arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts
> b/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts index
> 778bdbe228d31..93f14afc1f8a9 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts
> @@ -928,6 +928,12 @@ &sai5 {
>  	status = "disabled";
>  };
> 
> +&snvs {
> +	snvs-lpgpr {
> +		compatible = "fsl,imx8mm-snvs-lpgpr", "fsl,imx7d-snvs-
lpgpr";
> +	};
> +};
> +
>  &uart1 {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_uart1>;

Shouldn't this go into imx8mm.dtsi?

Best regards,
Alexander




_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: (EXT) [PATCH] arm64: dts: imx8mm: Add SNVS LPGPR on Data Modul i.MX8M Mini eDM SBC

[Marek Vasut]

On 5/23/22 13:08, Alexander Stein wrote:

Hi,

[...]

>> +&snvs {
>> +	snvs-lpgpr {
>> +		compatible = "fsl,imx8mm-snvs-lpgpr", "fsl,imx7d-snvs-
> lpgpr";
>> +	};
>> +};
>> +
>>   &uart1 {
>>   	pinctrl-names = "default";
>>   	pinctrl-0 = <&pinctrl_uart1>;
> 
> Shouldn't this go into imx8mm.dtsi?

No, not everyone uses this register for boot counter or wants to expose 
it to Linux that way. This is board-specific behavior.

(the other SNVS related entries should be in the SoC common file 
however, those are SoC-specific).

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: (EXT) [PATCH] arm64: dts: imx8mm: Add SNVS LPGPR on Data Modul i.MX8M Mini eDM SBC

[Alexander Stein]

Am Montag, 23. Mai 2022, 13:18:01 CEST schrieb Marek Vasut:
> On 5/23/22 13:08, Alexander Stein wrote:
> 
> Hi,
> 
> [...]
> 
> >> +&snvs {
> >> +	snvs-lpgpr {
> >> +		compatible = "fsl,imx8mm-snvs-lpgpr", "fsl,imx7d-snvs-
> > 
> > lpgpr";
> > 
> >> +	};
> >> +};
> >> +
> >> 
> >>   &uart1 {
> >>   
> >>   	pinctrl-names = "default";
> >>   	pinctrl-0 = <&pinctrl_uart1>;
> > 
> > Shouldn't this go into imx8mm.dtsi?
> 
> No, not everyone uses this register for boot counter or wants to expose
> it to Linux that way. This is board-specific behavior.

Sure the actual usage of the general purpose registers is very much board-
specific. Nevertheless the DT describes the hardware and there is snvs-lpgpr 
in all imx8mm. IMHO there is no harm exposing those GPR unconditionally.

Best regards,
Alexander

> 
> (the other SNVS related entries should be in the SoC common file
> however, those are SoC-specific).






_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: (EXT) [PATCH] arm64: dts: imx8mm: Add SNVS LPGPR on Data Modul i.MX8M Mini eDM SBC

[Marek Vasut]

On 5/23/22 13:43, Alexander Stein wrote:
> Am Montag, 23. Mai 2022, 13:18:01 CEST schrieb Marek Vasut:
>> On 5/23/22 13:08, Alexander Stein wrote:
>>
>> Hi,
>>
>> [...]
>>
>>>> +&snvs {
>>>> +	snvs-lpgpr {
>>>> +		compatible = "fsl,imx8mm-snvs-lpgpr", "fsl,imx7d-snvs-
>>>
>>> lpgpr";
>>>
>>>> +	};
>>>> +};
>>>> +
>>>>
>>>>    &uart1 {
>>>>    
>>>>    	pinctrl-names = "default";
>>>>    	pinctrl-0 = <&pinctrl_uart1>;
>>>
>>> Shouldn't this go into imx8mm.dtsi?
>>
>> No, not everyone uses this register for boot counter or wants to expose
>> it to Linux that way. This is board-specific behavior.
> 
> Sure the actual usage of the general purpose registers is very much board-
> specific. Nevertheless the DT describes the hardware and there is snvs-lpgpr
> in all imx8mm. IMHO there is no harm exposing those GPR unconditionally.

Imagine someone is storing information which shouldn't be exposed to 
Linux in those registers, in any way.

I see (in git grep) other SoCs already did add it unconditionally into 
their DTSI though, hummmmm. Then maybe we should be consistent and just 
add it to them all.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel