From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E520C4338F for ; Tue, 10 Aug 2021 10:10:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5EB3860E97 for ; Tue, 10 Aug 2021 10:10:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5EB3860E97 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DSMWmMPdMsMRedLbew8ydBNgjuyQZdKw+VXF3PvrJ4c=; b=rMHWK0mxq/SGoqB5UxpAorN//F 3d2JC2uih/F87dtyTJ0dj+pBvGR2EsykAssWd2gyUm3b5jTZqiN9K3uHDoK+IpQvfhIocGSDgo7CA 5zwGhChmtfLNqCwSwHTNMrIKBJbjfe0j4sXJIBCCTyhtb6xGLguD4Eij02D07/ZT22Ru8iLdJ5Yhy qB+IT6RnuRfvKJ23P644/fNAdM4E7G7epmXBpiysq1CQktpATsU4uQmEL/nB43ySxeCy4t2GvG4Ps 4TcCMRCzTuRO5VahNDHTYJBA2eA9RGIFnT0wMxKOFgTZYQSTae2uk+QUYlFvlX6wNolp43PvXUmTp +sBrc+Rg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mDOfN-003SOB-FE; Tue, 10 Aug 2021 10:07:25 +0000 Received: from mail-pj1-x102b.google.com ([2607:f8b0:4864:20::102b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mDOfI-003SMs-Eq; Tue, 10 Aug 2021 10:07:21 +0000 Received: by mail-pj1-x102b.google.com with SMTP id oa17so7436424pjb.1; Tue, 10 Aug 2021 03:07:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=/WTc/jRXHtXJWj+Wad8h2vDSBuhiirpHVCKMKslUCDg=; b=TNzlV9OG9ouGtp33JYXV2CuqznwDNP+DLbiBbjPq10lw0tgYJQrVP/+stIoYG4DXet B87oFA8bW29TZO5VXi2mOwA9Rk3vZXkZ80ISTqoP0SE3+1OxsVzP9hTM+rLn0uz/LCGE +MKiFdsXZ6HFdR5FJTNDZ0dLjDLyMeSu0qmO+2oP7qzz1NQFdYQ0mo7CslWrZtMDxYqk ww0SI0/bW4NQaPo5cOCiMiay3F5TWMZkyzimhZYDYpzGde+9z0BW+PP61iFT1w1ZNLb+ J54pBg8f8UjIP6T0Cmb9kBMSs2oddz0yD3GyW0JYhavYjirW7xymU0js/JVMWdw/eYe+ EXyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=/WTc/jRXHtXJWj+Wad8h2vDSBuhiirpHVCKMKslUCDg=; b=kZSpINPbjv8eXz1ozpsYVPFJNlzzDcpcjVTKKP+ASnfbLES6NFnc1o7+t0Maaygn6z Xmi7PZwpjZJchDkLEqOlwmODdOuwURZDP8Gk8jh0q36CaneKbf+RYnEtSk73ViT2yg2c Gb+rLnI+oV+CaPbqMyhwuMTng2ATSJ5u62uaGep1YLaWfOpCdrujNFx5QdUhjb4bHPin 8dZdC2afpOosjgGaq/fUWJZqkDzFmBC9JxYrh6v7WiyIiSZWloxMSVnpd+ZpSAcOJ7VE ZS79IzLY0xxHHaudoLoTZdOTk3C4nY0ycWcfif1BU1G/6ZC4rG3NYCzV3tGOOAlw3fkQ bRmg== X-Gm-Message-State: AOAM533Nk0sY0R/QSwa+iXgIDEfcxp3GFuO8cHNOzxzDMaUTCf8O3pSE kBGdWi+eLeRzGUyEM4kfTDQ= X-Google-Smtp-Source: ABdhPJzQFOqSq8XNRMUD+FN2uxXqX1t0SFajo0UanRiC2+h2uFmQlLC6oXYrIbW9iIs84t6N9EOIAA== X-Received: by 2002:a62:ea0f:0:b029:319:8eef:5ff1 with SMTP id t15-20020a62ea0f0000b02903198eef5ff1mr28642049pfh.74.1628590039333; Tue, 10 Aug 2021 03:07:19 -0700 (PDT) Received: from [192.168.1.22] (amarseille-551-1-7-65.w92-145.abo.wanadoo.fr. [92.145.152.65]) by smtp.gmail.com with ESMTPSA id bk24sm2421518pjb.26.2021.08.10.03.07.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Aug 2021 03:07:18 -0700 (PDT) Subject: Re: [PATCH 1/3] PCI: brcmstb: Break register definitions into separate header To: Jeremy Linton , linux-pci@vger.kernel.org Cc: lorenzo.pieralisi@arm.com, nsaenz@kernel.org, bhelgaas@google.com, rjw@rjwysocki.net, lenb@kernel.org, robh@kernel.org, kw@linux.com, f.fainelli@gmail.com, bcm-kernel-feedback-list@broadcom.com, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20210805211200.491275-1-jeremy.linton@arm.com> <20210805211200.491275-2-jeremy.linton@arm.com> From: Florian Fainelli Message-ID: Date: Tue, 10 Aug 2021 03:07:13 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210805211200.491275-2-jeremy.linton@arm.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210810_030720_545727_1F3ED65A X-CRM114-Status: GOOD ( 15.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 8/5/2021 2:11 PM, Jeremy Linton wrote: > We are about to create a standalone ACPI quirk module for the > bcmstb controller. Lets move the register definitions into a separate > file so they can be shared between the APCI quirk and the normal > host bridge driver. > > Signed-off-by: Jeremy Linton > --- > drivers/pci/controller/pcie-brcmstb.c | 179 +------------------------ > drivers/pci/controller/pcie-brcmstb.h | 182 ++++++++++++++++++++++++++ > 2 files changed, 183 insertions(+), 178 deletions(-) > create mode 100644 drivers/pci/controller/pcie-brcmstb.h You moved more than just register definitions into pcie-brcmstb.h you also moved internal structure definitions, enumerations, etc. which are not required since pcie-brcmstb-acpi.c does not access the brcm_pcie structure but open codes accesses to the MISC_STATUS register instead. There are no include guards added to this file (it is debatable whether we should add them), and it is also not covered by the existing BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE MAINTAINERS file entry. Given that there can be new platforms supported by this PCIe controller in the future possibly with the same limitations as the 2711, but with a seemingly different MISC_STATUS layout, you will have to think about a solution that scales, maybe we cross that bridge when we get there. -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel