Re: [PATCH] arm64: dts: renesas: sparrow-hawk: Add overlay for WaveShare 2CH CANFD HAT

[Marek Vasut <marek.vasut@mailbox.org>]

On 9/8/26 2:02 PM, Geert Uytterhoeven wrote:

Hello Geert,

>> +&pfc {
>> +       msiof0_pins: spi-ws-2ch-canfd0 {        /* SPI_0 */
> 
> Node name should be "msiof0".

Do we also have to fix up 
arch/arm64/boot/dts/renesas/r8a779g3-sparrow-hawk.dts this:

"
  755         msiof1_pins: sound {
                           ^^^^^
"
?

But I wonder, shouldn't the DTOs contain unique pinmux node names, which 
cannot accidentally overlap with the base DT or other DTO node names ?

>> +               groups = "msiof0_clk", "msiof0_txd", "msiof0_rxd";
>> +               function = "msiof0";
>> +       };
>> +};
>> +
>> +/*
>> + * PWM1 uses PWM1_B pin configuration for pin GP2_13. This conflicts
>> + * with SPI_1 CE_1 signal which is also on pin GP2_13. Disable PWM1
>> + * in case this hat is in use.
>> + */
>> +&pwm1 {
>> +       status = "disabled";
>> +};
> 
> Please move this node disabling pwm1 to the top, for compatibility
> with dynamic DT overlays.
Could you expand on that a bit ? What difference does the placement of 
this node make within the DTSO ? Please pardon my ignorance.

The rest of the review items are addressed in V2.

Thank you for your help!

-- 
Best regards,
Marek Vasut