From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E5C2C43381 for ; Mon, 4 Mar 2019 12:01:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C76BE20645 for ; Mon, 4 Mar 2019 12:01:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="riYQUXXS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C76BE20645 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HUi35Ip8zGQzYOnwKsGmEYx6BXcQk2UO8pWKSu/h1lE=; b=riYQUXXSESXwLa UlP5H+I3yDKyUQ2slVkrjswYlm3h0i0Ox79bimu3LOAPb+1n00eLO5tTt0X2NbeZThEamUgdtqHbT W7XpaimC38/1uZ+kcFVL0T3aXWGcOAUDb6MnYh5XMysCua1YVp3Wkx30ygWWHtfmPDSkZZlrH9Kcz kbJNKZykGELkjXHfBW+dFjWW2fGYemJc6e1j9T3VElm9G5PR4p4vtaKRedo+HLRGFsjnhE8YQKXc4 +KWAVSAOJMURlxAfmjr6GOdRzIIdWVF5tGPx1PBTy3m3u0tonZgbFO9EZsL4k2w17SiVEM63tOp+R bORFWg5GzgkDT4MGzSvA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h0mI0-0005bV-As; Mon, 04 Mar 2019 12:01:48 +0000 Received: from foss.arm.com ([217.140.101.70]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h0mHw-0005bA-PP for linux-arm-kernel@lists.infradead.org; Mon, 04 Mar 2019 12:01:46 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 73ED6A78; Mon, 4 Mar 2019 04:01:43 -0800 (PST) Received: from [10.1.196.69] (e112269-lin.cambridge.arm.com [10.1.196.69]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A32AD3F703; Mon, 4 Mar 2019 04:01:39 -0800 (PST) Subject: Re: [PATCH v3 05/34] c6x: mm: Add p?d_large() definitions To: "Kirill A. Shutemov" References: <20190227170608.27963-1-steven.price@arm.com> <20190227170608.27963-6-steven.price@arm.com> <20190301214851.ucems2icwt64iabx@kshutemo-mobl1> From: Steven Price Message-ID: Date: Mon, 4 Mar 2019 12:01:37 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <20190301214851.ucems2icwt64iabx@kshutemo-mobl1> Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190304_040144_832238_8159C4E5 X-CRM114-Status: GOOD ( 14.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Peter Zijlstra , Catalin Marinas , Dave Hansen , Will Deacon , linux-mm@kvack.org, "H. Peter Anvin" , "Liang, Kan" , linux-c6x-dev@linux-c6x.org, x86@kernel.org, Ingo Molnar , Mark Salter , Arnd Bergmann , Aurelien Jacquiot , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Borislav Petkov , Andy Lutomirski , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Ard Biesheuvel , linux-kernel@vger.kernel.org, James Morse Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 01/03/2019 21:48, Kirill A. Shutemov wrote: > On Wed, Feb 27, 2019 at 05:05:39PM +0000, Steven Price wrote: >> walk_page_range() is going to be allowed to walk page tables other than >> those of user space. For this it needs to know when it has reached a >> 'leaf' entry in the page tables. This information is provided by the >> p?d_large() functions/macros. >> >> For c6x there's no MMU so there's never a large page, so just add stubs. > > Other option would be to provide the stubs via generic headers form !MMU. > I agree that could be done, but equally the definitions of p?d_present/p?d_none/p?d_bad etc could be provided by a generic header for !MMU but currently are not. It makes sense to keep the p?d_large definitions next to the others. I'd prefer to stick with a (relatively) small change here - it's already quite a long series! But this is certainly something that could be tidied up for !MMU archs. Steve _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel