From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CF8B2C433F5 for ; Mon, 21 Feb 2022 10:46:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=q+/mTgWkcAb2z2a86B5NZrCfPV1n7AUgQmsMAgAIRpU=; b=Fdkc0Sc3dNyCMn tyAVV3YTsyuRQrjXRQGUVhCcXosdwCZRVRIbT/ojfVXbpwSfuhA+p5DMAgumoOGl0hrRfFoR4smI/ KmF9H9IqZ6cnaNi4lxKUa+zk901BP8wvhxOnQbHlzR8p6md6IDgdA9h3dd93EvlXdN/YeAaaSuc8U tQd7DyOf0KidgxbKhwTpADIH7Qeyzztn5DBfqP//702bahF+ur3mSLppSO5TMGWsgYVTQrMS1ISCw GEsJgv1oy9lcUati7PZgHjtlfCvGV3vUE0qFSgxBeijVL8If/rJHQzMYy/IUt7TrtByWNpUZJld42 ta2dKk7dOITZ1Lm9KQww==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nM6BL-0053k8-SY; Mon, 21 Feb 2022 10:44:41 +0000 Received: from mail-ed1-x533.google.com ([2a00:1450:4864:20::533]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nM5W8-004kJD-CB for linux-arm-kernel@lists.infradead.org; Mon, 21 Feb 2022 10:02:06 +0000 Received: by mail-ed1-x533.google.com with SMTP id u18so28180681edt.6 for ; Mon, 21 Feb 2022 02:02:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monstr-eu.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=kMIEQ6EmXrcKF9QOgwi4JP+rN/GpqbWH/lqcMa8liiA=; b=QQbUtc7TFLde+vu666fP1jpn3ZV0FX04icLIemzeQRGi911a0jMrdL8vJdmL3pepEi 6okCY+lM3vY8PCpbLkL0CN1RQ4ccaCqElG9sY+NLCKb3+FcPSFZopQ52JY04uQApqnML Q4cY5EH3iUC6W+Su0VttBmEwgrjlKWAQYvTGBsWINSb5FBW79dNR5AY4+0ePzW4cOSBz Q0sUk5AIW65Wwz/1e5NuOnsKKgKEjkWiLU4zNXi8yPSJJtSQpBUtIyP/KtVR7SCVX7xF /nGHil8Eqxvg9T8QZOz9HbijZq4GNAT7JXWKEOQyr7dui6njbDWHiKdx9LVYzym+qEK1 yy+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=kMIEQ6EmXrcKF9QOgwi4JP+rN/GpqbWH/lqcMa8liiA=; b=TXT8apKkwL//9xC5fQBLhTMPWY/nmlTU7Ib6TTwCmVCArLl0EbWPnn9POi5jc2lJDD zIbBsWNkrUHncPcEicfwQw39uw8lbGmZT8t6V7pKw23WVRaZ2gy43tqMJnWwJbnuSRIU S6XydMVFlXyHAMTiHgAiojMzwtcHIHMPZArfndkMi4Ln8OGojz6qhykcQc4FCo52UZbx Bxo1dJXWObbfQWsK6cSC0z8M0YVhQ3iqA1OPm0BETAd61n0GPJEruFUSVgmooZKXu2nN IW7/QANpbtSnfegb6AOPWMqFkh7PpzuVphukwBYYZo8jibc10W0iGyVdDAJG1BgAbbGD HXXQ== X-Gm-Message-State: AOAM531vS3hJiyBOO78XSRoQKjCZa77Lk1dyGR8LEc9EOB3DtZD3eXDW nm3BncsYqMHUOzfl62/me9Cueg== X-Google-Smtp-Source: ABdhPJwoxhTQ66ov81uyxAEEkMdXe2eNB3Eu5awgfYyKsjlTo0UYbaWCPMaaN9gxOKo3lAv87zWjkw== X-Received: by 2002:a50:f686:0:b0:410:e352:e61a with SMTP id d6-20020a50f686000000b00410e352e61amr19883345edn.23.1645437721836; Mon, 21 Feb 2022 02:02:01 -0800 (PST) Received: from ?IPV6:2a02:768:2307:40d6::f9e? ([2a02:768:2307:40d6::f9e]) by smtp.gmail.com with ESMTPSA id gs6sm702985ejb.17.2022.02.21.02.02.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Feb 2022 02:02:01 -0800 (PST) Message-ID: Date: Mon, 21 Feb 2022 11:02:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH] iio: adc: xilinx-ams: Use devm_delayed_work_autocancel() to simplify code Content-Language: en-US To: Jonathan Cameron , Christophe JAILLET Cc: Anand Ashok Dumbre , Lars-Peter Clausen , Michal Simek , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <2626e6a057e40cd2271ef0e5f81d12e607bad5b4.1644776929.git.christophe.jaillet@wanadoo.fr> <20220220114552.53fedd33@jic23-huawei> From: Michal Simek In-Reply-To: <20220220114552.53fedd33@jic23-huawei> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220221_020204_545043_2D206444 X-CRM114-Status: UNSURE ( 9.79 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On 2/20/22 12:45, Jonathan Cameron wrote: > On Sun, 13 Feb 2022 19:29:05 +0100 > Christophe JAILLET wrote: > >> Use devm_delayed_work_autocancel() instead of hand writing it. This is >> less verbose and saves a few lines of code. >> >> devm_delayed_work_autocancel() uses devm_add_action() instead of >> devm_add_action_or_reset(). This is fine, because if the underlying memory >> allocation fails, no work has been scheduled yet. So there is nothing to >> undo. >> >> Signed-off-by: Christophe JAILLET > Looks good to me, but I'd ideally like some input from someone familiar with > the driver. Anand told me that the change is fine that's why here is my Acked-by: Michal Simek Jonathan: Anand decided to do change in his carrier that's why that emails won't go through. But I am still around if you need something xilinx/amd to test. Thanks, Michal _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel