From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5678BC43381 for ; Mon, 1 Apr 2019 21:35:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1C34E20651 for ; Mon, 1 Apr 2019 21:35:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="oOZmDzsd"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="ZuCNYAXm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1C34E20651 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JXnHv5rzHQIEq3vOJr4rUPJxPeMqoNBjB/mQTux0hdQ=; b=oOZmDzsdFGwYij WpK2faqtpgp0O034V/x8iYsmQdRWIPBbHtmge8Jca4H5ePfS9BK1+r7dMLG9ntaSss+n5b2Dpd0kv OREIiOY3NV/IcM09C+3BW/owRM4X2/GK04DWBVSrkQhrFP9hPBRk9wGXvxfiH4AHmRfz5b0k0R13J 4K+L5gYsIdqBsx2GShajKV1okJRGPZyIwXIwJfdROpC8hoaitWe1W4ffruKI4Lt4/85iuxaCPgjwI 6SqbGMNi1En1bMoa9VnS/YDnVt2wUSY8STGMktJMAge/4bbnPAGKSub1B/FiE+2d+myH+DF2ag1uH PsRd7BFRuDlLvndFex5A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hB4aV-0002eb-O2; Mon, 01 Apr 2019 21:35:27 +0000 Received: from mail-pl1-x643.google.com ([2607:f8b0:4864:20::643]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hB4aP-0002ds-KR for linux-arm-kernel@lists.infradead.org; Mon, 01 Apr 2019 21:35:24 +0000 Received: by mail-pl1-x643.google.com with SMTP id g12so5115334pll.11 for ; Mon, 01 Apr 2019 14:35:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=WcYFxlU9bdthLYIkwreKbLvVDGvlwPgcLrSJxtq5PvM=; b=ZuCNYAXmRwsdaf7E4pB8EAuHKWU8sS9BDaU96TmHruCZs8ICFPddXXrWlo6n1ef106 Xxom8f9twErNRrX8UXiCQ2owTE5vTpxNFuVe4yG5UejCoYA3zFlorleQX2tsrUooZNWk pP19B1AFFRGBOHtQmEpe+bUfA6eDSrj1bGvus= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=WcYFxlU9bdthLYIkwreKbLvVDGvlwPgcLrSJxtq5PvM=; b=GryXeJqB9HZJ6co4prQd+PIEpEjftuqdpUyw70Vh8gbR+9aTOsjKoCTG5WxJDsMSb0 8Lln9Nqg44aOtNuTAMf53XVmUvLoJ7SHqIxgMa1165QzGXSHKJnjb2PT+Z+KMVvwR5u7 nnrF0VVeRHAD1YHOfuUAUj3mvmTnOCw8uaI/XWOnBD+WyS1RNA+fyM2pZR+zP3AyYUXc Z5t/oYbi8edIkmfTJ3HbWr8GkMfJ8VG/1RXs7CkIydqhOgaP5YipbcqNjhDhZikOlx2A mTdJ4F8HHmr8jssKHhHrmOn8Mth5uvpyiXngwJbemlJiCqy/fhFLZ1RJLeknvO30LRyj DxuA== X-Gm-Message-State: APjAAAWmb7ISBbZH1imuOCV5L1WVQOmz3dUc67zKZuGmnaBpXTge96P+ ORTcShn3M1YO3UGxy3YJWUuA9g== X-Google-Smtp-Source: APXvYqxTnN8N5rOXmCL3+pi2oWMFl+3RAiQki+UkOW90rnj89z+1hlClz2rvkBJhkoIo/tim8dWU5A== X-Received: by 2002:a17:902:7589:: with SMTP id j9mr1627952pll.287.1554154520714; Mon, 01 Apr 2019 14:35:20 -0700 (PDT) Received: from [10.136.8.252] ([192.19.228.250]) by smtp.gmail.com with ESMTPSA id c134sm22369287pfc.87.2019.04.01.14.35.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 01 Apr 2019 14:35:19 -0700 (PDT) Subject: Re: [PATCH v5 1/8] i2c: iproc: Extend I2C read up to 255 bytes To: Wolfram Sang References: <20190214175725.60462-1-ray.jui@broadcom.com> <20190214175725.60462-2-ray.jui@broadcom.com> <20190327221732.GB15396@kunai> From: Ray Jui Message-ID: Date: Mon, 1 Apr 2019 14:35:16 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.0 MIME-Version: 1.0 In-Reply-To: <20190327221732.GB15396@kunai> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190401_143521_673959_4E2BF447 X-CRM114-Status: GOOD ( 13.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Shreesha Rajashekar , Rayagonda Kokatanur , linux-kernel@vger.kernel.org, Rob Herring , bcm-kernel-feedback-list@broadcom.com, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3/27/2019 3:17 PM, Wolfram Sang wrote: > >> + if (!((readl(iproc_i2c->base + >> + M_FIFO_CTRL_OFFSET) >> >> + M_FIFO_RX_CNT_SHIFT) & >> + M_FIFO_RX_CNT_MASK)) > > Don't be too strict with the 80 char limit. I think the above is hardly > readable... > Right, that makes sense. Will change to make it more readable than trying to be compliant to the < 80 chars rule. >> + break; >> + >> + msg->buf[iproc_i2c->rx_bytes] = >> + (readl(iproc_i2c->base + M_RX_OFFSET) >> >> + M_RX_DATA_SHIFT) & M_RX_DATA_MASK; > > ... this here is MUCH better. > > Rest looks good. > Thanks, Ray _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel