From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D20D3EB64DE for ; Tue, 10 Sep 2024 03:37:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From :Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ycTE8+/JU0ozVfwLfJkVUkbDQjHqEmfJiIS4bw0m4rI=; b=TU66ac/yiVo305ulqLZqndDuqk 1i2stD4rZUi8aJCT5rJbeiapgnob28pgGhwD/+Frjd8LhxIBh2UVZ+p05e2KOIz6x0ApVslzqUs8v KrD4vCbD1jboIZQ4hwi3znSiSLVSYJSo+ioyOnS4+XH5KldSsuOdfeRI/72WYxm99oindJyGXdYlN DlbBdTLUfL8ao+ok1U3L4QEPKL3Um4HjPLdunLbtujC/0MqEJ3KyD9HZap4nJ+gv95yvVa/LS+mq+ Fo2e52yTelUBi+47sVUweP27ZC5juavko9twE4HtoBo5IQkGMxWxTG+MLqkrM7s0j5kX6IU06ZOV1 dMNeNhsg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1snrgu-000000045X4-01JB; Tue, 10 Sep 2024 03:37:20 +0000 Received: from mail-pf1-x42d.google.com ([2607:f8b0:4864:20::42d]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1snrft-000000045FV-1Poz for linux-arm-kernel@lists.infradead.org; Tue, 10 Sep 2024 03:36:18 +0000 Received: by mail-pf1-x42d.google.com with SMTP id d2e1a72fcca58-718d704704aso279709b3a.3 for ; Mon, 09 Sep 2024 20:36:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725939375; x=1726544175; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=ycTE8+/JU0ozVfwLfJkVUkbDQjHqEmfJiIS4bw0m4rI=; b=FKqIBhmBP95IunOaD0GzVXVP0CnlNFrW9UUuoj7XUk7y6jr5tmx9OIdrqDb1Niua3M VZ714BsfSbnvZcG+VOznTAHj6YESL6xEXPy0OrLBtky5cJaO6vWyqkUyA8C+G3Dv6dv5 Iu75RbCY9GHMITZeN+v/kmvg/LULwK6/ktiir/3Gwsv10VKirMHK86W0SD4Iwr+3sBiI 8FRRKDanRBlKJir3yBChfnFDxJs9F7xx3AiYnUT2NJ85aW3tYME8jTAo5QEroCy+ZcJ1 bpk/pf4/UH3+mvHBe/2udwala62ZZqX1CRL4eyFWHlI68FBpmLySdujlCUaSvZmhNnuT 0VzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725939375; x=1726544175; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:sender:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ycTE8+/JU0ozVfwLfJkVUkbDQjHqEmfJiIS4bw0m4rI=; b=cUAoRO2E2xnUoynNXA8V55IAycIHEP6Agz/WZrfXAE80P9SDxeOBUBW8MwHIzdW9ie IG47x0xsOB1XQN/dcP2nKFIRlAC2vrelaa3J3Uspwjxnp6r4Ryq4qIV+NA+xT/vp+QsK q5ayjKbRL/zpaMaTnpUn5IoQRoO/q0qvPr49tmksqQSADn8QdorBJTXRydOvHXvwiIsN SsbyiJba4fTqic9YiYGqmAircWGTycisyk1GdQWuMBPKefqb2wjUuJh8s+zQvRlw7wbP OZSZFZlTkIerJd4R4RvmXSOnraguMfES9OfTQrtNfyQQbKcojXqlvH1CFV2AhdQMWIWn RfCg== X-Forwarded-Encrypted: i=1; AJvYcCWKOLsNSTbh79ujm3mJaZapOjNrLo8Yrh8lFIrMFF00yPeoKmsXLfdtvBnuhhUEfCkX/+TsSgUrO18P3AbzJ7/s@lists.infradead.org X-Gm-Message-State: AOJu0YwMtjRDyfBRIshkpGzg7wKlNzw7wyZEpXlqbpWEezBE96PI59BE Rt2xk8xjApI3xK7EVkNF7e5cnCH6zeAcv/nYk2JyMHWvlNYZ+/Qt X-Google-Smtp-Source: AGHT+IE8uPyBvwmlyRx9OPr5CkYfbUQ6f8tDN4MdlsjG2Xd94dO4JKbY2wufCn9UKDbnbRSprbW6Qw== X-Received: by 2002:a05:6a00:2e0d:b0:718:d942:3475 with SMTP id d2e1a72fcca58-718e3368830mr14029681b3a.7.1725939375009; Mon, 09 Sep 2024 20:36:15 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:329c:23ff:fee3:9d7c? ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-719090c9b08sm437746b3a.207.2024.09.09.20.36.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Sep 2024 20:36:14 -0700 (PDT) Message-ID: Date: Mon, 9 Sep 2024 20:36:09 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 00/15] Tool and hwmon PMUs To: Ian Rogers , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Adrian Hunter , Kan Liang , John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Ravi Bangoria , Weilin Wang , Jing Zhang , Xu Yang , Sandipan Das , Benjamin Gray , Athira Jajeev , Howard Chu , Dominique Martinet , Yang Jihong , Colin Ian King , Veronika Molnarova , "Dr. David Alan Gilbert" , Oliver Upton , Changbin Du , Ze Gao , Andi Kleen , =?UTF-8?Q?Cl=C3=A9ment_Le_Goffic?= , Sun Haiyong , Junhao He , Tiezhu Yang , Yicong Yang , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hwmon@vger.kernel.org References: <20240907050830.6752-1-irogers@google.com> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAlVcphcFCRmg06EACgkQyx8mb86fmYFg0RAA nzXJzuPkLJaOmSIzPAqqnutACchT/meCOgMEpS5oLf6xn5ySZkl23OxuhpMZTVX+49c9pvBx hpvl5bCWFu5qC1jC2eWRYU+aZZE4sxMaAGeWenQJsiG9lP8wkfCJP3ockNu0ZXXAXwIbY1O1 c+l11zQkZw89zNgWgKobKzrDMBFOYtAh0pAInZ9TSn7oA4Ctejouo5wUugmk8MrDtUVXmEA9 7f9fgKYSwl/H7dfKKsS1bDOpyJlqhEAH94BHJdK/b1tzwJCFAXFhMlmlbYEk8kWjcxQgDWMu GAthQzSuAyhqyZwFcOlMCNbAcTSQawSo3B9yM9mHJne5RrAbVz4TWLnEaX8gA5xK3uCNCeyI sqYuzA4OzcMwnnTASvzsGZoYHTFP3DQwf2nzxD6yBGCfwNGIYfS0i8YN8XcBgEcDFMWpOQhT Pu3HeztMnF3HXrc0t7e5rDW9zCh3k2PA6D2NV4fews9KDFhLlTfCVzf0PS1dRVVWM+4jVl6l HRIAgWp+2/f8dx5vPc4Ycp4IsZN0l1h9uT7qm1KTwz+sSl1zOqKD/BpfGNZfLRRxrXthvvY8 BltcuZ4+PGFTcRkMytUbMDFMF9Cjd2W9dXD35PEtvj8wnEyzIos8bbgtLrGTv/SYhmPpahJA l8hPhYvmAvpOmusUUyB30StsHIU2LLccUPPOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAlVcpi8FCRmg08MACgkQyx8mb86fmYHNRQ/+ J0OZsBYP4leJvQF8lx9zif+v4ZY/6C9tTcUv/KNAE5leyrD4IKbnV4PnbrVhjq861it/zRQW cFpWQszZyWRwNPWUUz7ejmm9lAwPbr8xWT4qMSA43VKQ7ZCeTQJ4TC8kjqtcbw41SjkjrcTG wF52zFO4bOWyovVAPncvV9eGA/vtnd3xEZXQiSt91kBSqK28yjxAqK/c3G6i7IX2rg6pzgqh hiH3/1qM2M/LSuqAv0Rwrt/k+pZXE+B4Ud42hwmMr0TfhNxG+X7YKvjKC+SjPjqp0CaztQ0H nsDLSLElVROxCd9m8CAUuHplgmR3seYCOrT4jriMFBtKNPtj2EE4DNV4s7k0Zy+6iRQ8G8ng QjsSqYJx8iAR8JRB7Gm2rQOMv8lSRdjva++GT0VLXtHULdlzg8VjDnFZ3lfz5PWEOeIMk7Rj trjv82EZtrhLuLjHRCaG50OOm0hwPSk1J64R8O3HjSLdertmw7eyAYOo4RuWJguYMg5DRnBk WkRwrSuCn7UG+qVWZeKEsFKFOkynOs3pVbcbq1pxbhk3TRWCGRU5JolI4ohy/7JV1TVbjiDI HP/aVnm6NC8of26P40Pg8EdAhajZnHHjA7FrJXsy3cyIGqvg9os4rNkUWmrCfLLsZDHD8FnU mDW4+i+XlNFUPUYMrIKi9joBhu18ssf5i5Q= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240909_203617_401658_BBC0A0CC X-CRM114-Status: GOOD ( 14.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/9/24 19:21, Ian Rogers wrote: > On Fri, Sep 6, 2024 at 10:08 PM Ian Rogers wrote: >> >> Rather than have fake and tool PMUs being special flags in an evsel, >> create special PMUs. This allows, for example, duration_time to also >> be tool/duration_time/. Once adding events to the tools PMU is just >> adding to an array, add events for nearly all the expr literals like >> num_cpus_online. Rather than create custom logic for finding and >> describing the tool events use json and add a notion of common json >> for the tool events. >> >> Following the convention of the tool PMU, create a hwmon PMU that >> exposes hwmon data for reading. For example, the following shows >> reading the CPU temperature and 2 fan speeds alongside the uncore >> frequency: >> ``` >> $ perf stat -e temp_cpu,fan1,hwmon_thinkpad/fan2/,tool/num_cpus_online/ -M UNCORE_FREQ -I 1000 >> 1.001153138 52.00 'C temp_cpu >> 1.001153138 2,588 rpm fan1 >> 1.001153138 2,482 rpm hwmon_thinkpad/fan2/ >> 1.001153138 8 tool/num_cpus_online/ >> 1.001153138 1,077,101,397 UNC_CLOCK.SOCKET # 1.08 UNCORE_FREQ >> 1.001153138 1,012,773,595 duration_time >> ... >> ``` > > +linux-hwmon@vger.kernel.org as a heads up. > No idea what you are doing, or why. I am not sure if I care, unless you introduce dependencies on hwmon internals (or, in other words, define undocumented APIs into hwmon). Which I'd argue would be a no-go. Guenter