From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D6DC2ECD996 for ; Thu, 5 Feb 2026 18:59:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:References:Cc:To:Subject:From:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/L8V48fLzH9aRCH7Nea6iAI0WZgmA1eS1Wyz5+i1wYs=; b=pejNegWpTIdZIOhdwJ/zIQROpT OIYEpJLpAvGKgf6W3gRjmKGdOJa2iqGQ6YV6hnzg2nvt9vjrxEOmxlHTOU+/KZ/HK8KxiLJXaHpvW JeNI9b34tN2Lr9Sk5AJm0HFhyE8Esf7DfExZER/Lk+14aNR3ChgWgj3qZeiTSTuf0VlfrozKEXAnK Q6vXj0HJnpZV9/EfJ+Cvyjq/IYzVEo1RfFH/z8wJjJkwsSf61xYMbujmVbgQrP6lBdjvS4KigKvkh QhGhWlceDDRTdkVxdopY4rg12BgPTnWbEJJAjb4TeAsC2Cp7Z+3hAY25ZH2hMp0bFtMxHz0Awfhtn Uh3EmuYw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vo4ZK-0000000AOvz-0air; Thu, 05 Feb 2026 18:59:10 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vo4ZI-0000000AOvm-20Qm for linux-arm-kernel@lists.infradead.org; Thu, 05 Feb 2026 18:59:08 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id AC6A6600AD; Thu, 5 Feb 2026 18:59:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 92ED0C116D0; Thu, 5 Feb 2026 18:59:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770317947; bh=0RWLUwXfgwzIMMkOAdU1B8lsx67mPW8DTRDIndEvfSs=; h=Date:From:Subject:To:Cc:References:In-Reply-To:From; b=prbKmWYrFpMvqasb32pcUS8cjqHhTn6Z9NicQE0XYphmUGT2dunMu4OXGjaJ9cINw ixm4VWUuUJBsPQM8X5kK5OQQTaVATATthCxtChyJCRdGU2HmQBFISaNiTX2nHNdf0M se6NkAHEcIjFhYM2oDkPCmqTTbTBM23U3WozwcfNio6jwoo8BlNJHCB3YFqULniKhE ag/5i9Zh1XkErQ92CE/4ngQOKkoOti3Cjffns6gqb7EkGhhMIhhg09Q2HibJBKb3Xx 8K/ncM8VdQp1e9RJYe1sVecmkNJLE8v4fqajJJwPE5kq2eY6nshwfdEZDlPYC/IGg+ Daml0T9f6M1mQ== Message-ID: Date: Thu, 5 Feb 2026 19:59:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Krzysztof Kozlowski Subject: =?UTF-8?B?UmU6IOWbnuWkjTogW1BBVENIIHY3IDEvM10gZHQtYmluZGluZ3M6IHNv?= =?UTF-8?Q?c=3A_cix=3A_document_the_simple-mfd_syscon_on_Sky1_SoC?= To: Gary Yang Cc: "robh@kernel.org" , "krzk+dt@kernel.org" , "conor+dt@kernel.org" , "p.zabel@pengutronix.de" , Peter Chen , "unicorn_wang@outlook.com" , "inochiama@gmail.com" , "alchark@gmail.com" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , cix-kernel-upstream References: <20260204020644.155094-1-gary.yang@cixtech.com> <20260204020644.155094-2-gary.yang@cixtech.com> <20260205-noisy-fabulous-bumblebee-e0cb32@quoll> Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 05/02/2026 11:39, Gary Yang wrote: > Hi Krzysztof: > > I'm glad to see your comments > >> EXTERNAL EMAIL >> >> On Wed, Feb 04, 2026 at 10:06:42AM +0800, Gary Yang wrote: >>> There are two system control on Cix sky1 Soc. One is located in S0 >>> domain, and the other is located in S0 and S5 domain. The system >>> control contains resets, usb typeC and more. At this point, only the >>> reset controller child is described as usb typeC uses it by phandle. >>> >>> Signed-off-by: Gary Yang >>> --- >>> .../soc/cix/cix,sky1-system-control.yaml | 49 ++++++ >>> include/dt-bindings/reset/cix,sky1-rst-fch.h | 42 +++++ >>> include/dt-bindings/reset/cix,sky1-rst.h | 164 >> ++++++++++++++++++ >>> 3 files changed, 255 insertions(+) >>> create mode 100644 >>> Documentation/devicetree/bindings/soc/cix/cix,sky1-system-control.yaml >>> create mode 100644 include/dt-bindings/reset/cix,sky1-rst-fch.h >>> create mode 100644 include/dt-bindings/reset/cix,sky1-rst.h >>> >>> diff --git >>> a/Documentation/devicetree/bindings/soc/cix/cix,sky1-system-control.ya >>> ml >>> b/Documentation/devicetree/bindings/soc/cix/cix,sky1-system-control.ya >>> ml >>> new file mode 100644 >>> index 000000000000..5fb6b97c3c00 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/soc/cix/cix,sky1-system-contro >>> +++ l.yaml >>> @@ -0,0 +1,49 @@ >>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause %YAML 1.2 >>> +--- >>> +$id: >>> +http://devicetree.org/schemas/soc/cix/cix,sky1-system-control.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Cix Sky1 SoC system control register region >>> + >>> +maintainers: >>> + - Gary Yang >>> + >>> +description: >>> + An wide assortment of registers of the system controller on Sky1 >>> +SoC, >>> + including resets, usb, wakeup sources and so on. >>> + >>> +properties: >>> + compatible: >>> + items: >>> + - enum: >>> + - cix,sky1-system-control >>> + - cix,sky1-s5-system-control >>> + - const: syscon >>> + - const: simple-mfd >> >> Drop simple-mfd, no children >> > > Yes, just now there is no child nodes. We want to reserve it for further. > If you feel confuse, we can also delete this strings. Sorry, you cannot reserve it. Bindings should be complete (see writing bindings), so you should post a COMPLETE binding for this device now. Adding ABI for "reserved case" is poor idea, because you will have to support it forever. > >>> + >>> + reg: >>> + maxItems: 1 >>> + >>> + '#address-cells': >> >> Drop, no children > > The same as above > >> >>> + const: 1 >>> + >>> + '#size-cells': >> >> Drop >> > > same > >> Do you see any recent simple-mfd binding written like this? There are no. Did >> you read any of other bindings before sending this? Or at least my slides or >> amny other resources from vast documentation from elinux.org? >> > > This yaml comes from microchip,mpfs-mss-top-sysreg.yaml as conor's suggestions on V3. > More info: https://patchwork.kernel.org/project/linux-arm-kernel/patch/20251124063235.952136-2-gary.yang@cixtech.com/ Please point to a specific message, not entire thread of 8 untrimmed replies. > If you have the different views, please give more information. Thanks These are simply wrong in this context. If you claim you might need it, it means you actually need to finish the binding with missing pieces. Look, do you write such Cc code: int some_probe() { ... if (0) { /* Code reserved for future */ } return 0; } No. Creating unused code means more maintenance, wasted review, wasted cycles of preprocessor or compiler. We NEVER write such code. > > If miss any information, please remind me. Yeah, please post COMPLETE bindings for this device. Best regards, Krzysztof