From: Krzysztof Kozlowski <krzk@kernel.org>
To: Vikram Sharma <quic_vikramsa@quicinc.com>,
bryan.odonoghue@linaro.org, mchehab@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, andersson@kernel.org,
konradybcio@kernel.org, hverkuil-cisco@xs4all.nl,
cros-qcom-dts-watchers@chromium.org, catalin.marinas@arm.com,
will@kernel.org
Cc: linux-arm-kernel@lists.infradead.org, quic_svankada@quicinc.com,
linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
quic_nihalkum@quicinc.com, stable@vger.kernel.org
Subject: Re: [PATCH v5 1/2] dt-bindings: media: qcom,qcs8300-camss: Add missing power supplies
Date: Fri, 7 Nov 2025 14:42:51 +0100 [thread overview]
Message-ID: <f8bc25b7-12eb-4e3c-aa47-8c949f43711b@kernel.org> (raw)
In-Reply-To: <20251107132154.436017-2-quic_vikramsa@quicinc.com>
On 07/11/2025 14:21, Vikram Sharma wrote:
> Add support for vdda-phy-supply and vdda-pll-supply in the QCS8300
> CAMSS binding.
You cannot add support for something in the binding, but regardless of
the wording - why adding support is a fix? Please describe the bug,
because adding support does not sound like a fix at all.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-11-07 13:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-07 13:21 [PATCH v5 0/2] qcom: qcs8300: Add qcs8300 camss support Vikram Sharma
2025-11-07 13:21 ` [PATCH v5 1/2] dt-bindings: media: qcom,qcs8300-camss: Add missing power supplies Vikram Sharma
2025-11-07 13:42 ` Krzysztof Kozlowski [this message]
2025-11-07 13:21 ` [PATCH v5 2/2] arm64: dts: qcom: qcs8300: Add support for camss Vikram Sharma
2025-11-07 13:49 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8bc25b7-12eb-4e3c-aa47-8c949f43711b@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=quic_nihalkum@quicinc.com \
--cc=quic_svankada@quicinc.com \
--cc=quic_vikramsa@quicinc.com \
--cc=robh@kernel.org \
--cc=stable@vger.kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).