From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0ED96C43463 for ; Fri, 18 Sep 2020 16:13:06 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8F36123888 for ; Fri, 18 Sep 2020 16:13:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="uVJY5Nft" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8F36123888 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:References: To:Subject:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wZUBktmKDX6AI6tsBYSEdZJFUsdCQXBwnszJ/auAz+c=; b=uVJY5NftKpWhsQly4wkp32GKf 8e0Y6Xy4m0pkD6UHwu004T5IlwZH5ZW5x9mUfyyer9kn13ltnvejgmfEYcTXJNuwobN8E6tmaMDiX ueoX/Yje/c1ujLOlUjMxVV1lGY+SPJ744Jyy4ucV/fpHy6Y5Wnj7Hnx1dw3nyqEFIAbqLmt4v7lIY CwS2B+vKAqRC8Hf3tVk5ngK32bJlAZXVaB03ycsvt2AHVmOMVmz/pVim8zaEpYOalUrgTdatUgxne NQfWav4XGOT94ARsehktYHeLTpQeyGyYppRbowczrmD7jGPngnIIYcwM6xJdPCr9ovSyBDvsxqOU+ tukIcNlqg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kJIyK-0007jn-95; Fri, 18 Sep 2020 16:10:52 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kJIyH-0007j5-1h for linux-arm-kernel@lists.infradead.org; Fri, 18 Sep 2020 16:10:50 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D731230E; Fri, 18 Sep 2020 09:10:47 -0700 (PDT) Received: from [172.16.1.113] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8F46C3F73B; Fri, 18 Sep 2020 09:10:46 -0700 (PDT) From: James Morse Subject: Re: [PATCH v4 02/15] drivers/firmware/sdei: Common block for failing path in sdei_event_create() To: Gavin Shan , linux-arm-kernel@lists.infradead.org References: <20200730014531.310465-1-gshan@redhat.com> <20200730014531.310465-3-gshan@redhat.com> Message-ID: Date: Fri, 18 Sep 2020 17:10:36 +0100 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200730014531.310465-3-gshan@redhat.com> Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200918_121049_142322_B58A5081 X-CRM114-Status: GOOD ( 11.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, catalin.marinas@arm.com, will@kernel.org, shan.gavin@gmail.com, Jonathan.Cameron@huawei.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Gavin, (Suject Nit: almost all of the commits to this file begin 'firmware: arm_sdei:') On 30/07/2020 02:45, Gavin Shan wrote: > There are multiple calls of kfree(event) in the failing path of > sdei_event_create() to free the SDEI event. > It means we need to > call it again when adding more code in the failing path. It's > prone to miss doing that and introduce memory leakage. If there is another things that needs adding here, sure. (otherwise there is no unwinding that needs to happen.) > This introduces common block for failing path in sdei_event_create() > to resolve the issue. This shouldn't cause functional changes. Acked-by: James Morse Thanks, James _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel