From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5417BC001CC for ; Wed, 17 Apr 2024 08:31:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AmkGynxCdylFeDU4TJhKdTZPADcBbtYN7Otrd2G7cBU=; b=U8HCbVfFCT+TAE JAtCyKsIpzBMlasrSoruv2UhCmeG3bVp3u9hYL7IRppj50Gb+J1u+eoFZIas6bGG36mKxVa6TMAwq C0VbioR4gP4NxCJ4rqY834+7FodGByhIu2cDgg4WtVqrsJrkUKL3NJkfPt+GaFf7qrlOe5Q8OWRu/ IhGZtspnRWPIWeCJ3owwZWGlVPlo+gJBnyqtlASfCAQ/4K6x8WV5trsgGxhuCcK8uhZMDZ6JNqzVl J+31eIlCNlXdQjWo6NSX+qk1ytcgcrTgWA5fhGwEwfuZ9sOTfoFpP2MMT6hKexL2sDe3UWBFMN/uH lMzVWpOAhnn2ZKfbziJA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rx0h4-0000000FDJG-0qki; Wed, 17 Apr 2024 08:31:02 +0000 Received: from madrid.collaboradmins.com ([2a00:1098:ed:100::25]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rx0h0-0000000FDIQ-3dwS; Wed, 17 Apr 2024 08:31:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1713342657; bh=hAKoZHGRwe5oOR+gYjYRmI7U+/iTL7eq3fs9/Xu1aqU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=PEot3oHSw4wT5loY0dZpFv8eiXYny753dDhAVZKZBGyksPkHRuacYII0BK9ALD0dD DebbtnNXmKla5szZK45nxT4sWD+rEyD4i59/JWeB6LEm+tMmwFCDN8U+WBdE5u2ucG mQ5JTOJc2nZ3tbCbv3AZiLwhUvnXVy5YGB8PDm8dkiPy/CdsiWReM+8GjXTcMMw+Dq oETXqmldu52IL/9sXB0/+QjrP3ZevN8A75ItxzP47rmkYzKdxuaTDyKlom+s0jpeI/ FuzSDf9TYqz+dVDbKulHemdsjmr9wnMrrGxqDA55pPMnlEO2vEWYEvbLpHp+qemspe pfNE+h722qR9A== Received: from [100.113.186.2] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 713E537820F9; Wed, 17 Apr 2024 08:30:56 +0000 (UTC) Message-ID: Date: Wed, 17 Apr 2024 10:30:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 5/6] regulator: mtk-dvfsrc-regulator: Refactor and add MT8192/MT8195 vregs To: Mark Brown Cc: djakov@kernel.org, robh@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, matthias.bgg@gmail.com, lgirdwood@gmail.com, keescook@chromium.org, gustavoars@kernel.org, henryc.chen@mediatek.com, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, kernel@collabora.com, wenst@chromium.org, amergnat@baylibre.com References: <20240416153805.431118-1-angelogioacchino.delregno@collabora.com> <20240416153805.431118-6-angelogioacchino.delregno@collabora.com> From: AngeloGioacchino Del Regno Content-Language: en-US In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240417_013059_199335_4FDFE883 X-CRM114-Status: UNSURE ( 9.54 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Il 17/04/24 02:52, Mark Brown ha scritto: > On Tue, Apr 16, 2024 at 05:38:04PM +0200, AngeloGioacchino Del Regno wrote: >> This driver never worked, and never got even compiled, because it was >> missing the DVFSRC driver entirely, including headers it relies on! >> >> Perform a full (or nearly full) refactoring of the MediaTek DVFSRC >> controlled Regulators driver: this retains support for the MT6873, >> MT8183 and MT8192 SoCs, and adds MT8195. >> >> As part of the refactoring, this driver is now probed using its own >> devicetree compatible, as this is a child of the main DVFSRC driver >> and gets probed as a subnode of that. > > Given what you're doing this would probably be easier to review as > two commits, one removing the existing driver and another adding the new > code. Yeah, definitely.... I'll do that for v2. Cheers, Angelo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel