From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BB992C19F32 for ; Fri, 7 Mar 2025 06:34:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version: Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:Cc:To: Subject:Date:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Ry20+r04sphzoiaaJTb3EB2Hrifw18CbXXy2cx7GHzI=; b=idOYmRt9nAxlgFRV8efe/RDQsp E7Ppr4ALC2TBibZUz6fE7jbQPGA6BzFMMh/GTOe7LbYuDaudxqFUu1Jxq7cF12znRhebBwLyqp3wn g8+PTHqWFggAdiSmAv086sEJMMYcXBKz4WaTel7z5cFJg3IPd5sk8iZeM5W6Bwx6YKZ6UErBHpyOJ X7yaY10qNIPQ1IJcqPx6nYXK3FnXOroTt8IguXb6i7cQ7kXnW7/Ll+64gCWOCqfR9A2WNM5FuH8+4 eaLO4zBuS9w7zugaRQsHBaN2mvkdfg0gL3WooUUx7LS/8xxg0cvUMd6iDqkMYvqGunOexkr3IDS/I KnxJzggw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tqRHd-0000000DJgR-2wBX; Fri, 07 Mar 2025 06:34:09 +0000 Received: from mail-db8eur05on20620.outbound.protection.outlook.com ([2a01:111:f403:2614::620] helo=EUR05-DB8-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tqRG1-0000000DJVZ-1Tsy for linux-arm-kernel@lists.infradead.org; Fri, 07 Mar 2025 06:32:30 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=YK8UZYjfmEOiUla2KYMeZO7X2vJGHPMDq79lLOBuvOIWAUXiaFL6TNP+pL4oGPJwDFaazVgBFTbdIo3z9cTA8LAP2aM1UJJ1rRDXQ4ONyHp5GNej6ikgUQLP0MQpeq41NVpacl0WOVc1gz1Dh22XkHeABCA2xV5vKeYgSCrft6li66DKE08MVz9eaMDQQiR9Kk81SZnZCa1/u4YhrggnuvUfBbcmzt/splfBHQ3E2ATSk8DdqQrMzpMq/7HZhauWHS7Lyy4PvjIqAONFDYdc7RUpbOYJSAQYJoK4nxrp5PaiO4sIUnhuHzt2oMK6/1n6OGRbQzkmfQwvgP4jyt7P/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ry20+r04sphzoiaaJTb3EB2Hrifw18CbXXy2cx7GHzI=; b=MA1T2r/BTGpGckV04jJZOoKq1gUXC+2uhFPMH5qUx+/CUVf+eoZPifrX4eGIgV5Hul7UX2eKDzk+xFJfU7etsfil3iRoFZNNE1Hsi7Asz4Q3iQh+LamSNOCOtx5X2H7AtRUYboaOTSBmT8dzHSExE2andgOzFFFCdiIUGvRPDYdSA//9ZsIzic2RhP7a3vK236Cp40joO1Xitdf6y5BGct6oFjiPweWCLFGKT0t9TG0x8ACVI1qFiwBqsqQ8NcWMPUctpNt9vki43xulwl6zjoSpEOkVdoARaV86pdoy6xO1J751NXbxMLTzyD5MrH6Rxe33yOoLYICFdyP7b44iPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ry20+r04sphzoiaaJTb3EB2Hrifw18CbXXy2cx7GHzI=; b=Yulqrtdy9MKwh6XeZauVzniVKcPa++Em9WC5Q6EHLuJjNIOqruFes/nadwV+BvRS2V5zdQLq9jbcP05PTAy8oNPThv88DUDyBEQrwVTIWAL8QuqhsjwHooVo6HbnpmI/qahu8Tns/IRVDQpTX5Yq1yW7o03vdS/Yebmroldkymo889EAzEaVzf31rcqQS8dqH6erZOFE41DxpUS6Dg29HtVIM3r1/K+JFDgrvoawvix+XgxnpKssv4nznshmWNTFtq91/ts0wgu6JV0b0nj6M7v6DEMHEPIIrRyNZl0OcoFhiAKjzDfUQr38DIH7rKjrPJjH08PzzQ+lU2erPf/oJQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM7PR04MB7046.eurprd04.prod.outlook.com (2603:10a6:20b:113::22) by AS5PR04MB9972.eurprd04.prod.outlook.com (2603:10a6:20b:682::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8511.17; Fri, 7 Mar 2025 06:32:25 +0000 Received: from AM7PR04MB7046.eurprd04.prod.outlook.com ([fe80::d1ce:ea15:6648:6f90]) by AM7PR04MB7046.eurprd04.prod.outlook.com ([fe80::d1ce:ea15:6648:6f90%4]) with mapi id 15.20.8511.017; Fri, 7 Mar 2025 06:32:25 +0000 Message-ID: Date: Fri, 7 Mar 2025 14:33:37 +0800 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] drm/bridge: fsl-ldb: make warning message more informative To: Luca Ceresoli , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam Cc: Thomas Petazzoni , dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20250306-drm-two-ldb-improvements-v1-0-f139d768b92c@bootlin.com> <20250306-drm-two-ldb-improvements-v1-2-f139d768b92c@bootlin.com> From: Liu Ying Content-Language: en-US In-Reply-To: <20250306-drm-two-ldb-improvements-v1-2-f139d768b92c@bootlin.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SI2PR02CA0013.apcprd02.prod.outlook.com (2603:1096:4:194::21) To AM7PR04MB7046.eurprd04.prod.outlook.com (2603:10a6:20b:113::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM7PR04MB7046:EE_|AS5PR04MB9972:EE_ X-MS-Office365-Filtering-Correlation-Id: 6c37c6f8-68c4-4d8d-62e0-08dd5d41d2dd X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|366016|1800799024|921020|7053199007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?WHdIM0d3YmJSNXg3VTQ1RVk3R21YQ1VBTzZXWHIxUnB3NTMwZnF1UFpaRFVH?= =?utf-8?B?WCtRbzlDckMwbzIxSEg5MVFqV2RFbFdTR2FheU5UdXhvVGM3cmJMRVl4US9I?= =?utf-8?B?TUlQQ2c0VDlacUlhOTFKLzRyeHJvZUFzd1JIa2JSRzhLamhTQnA4dVBrbXUz?= =?utf-8?B?NVo4OW0yV21hclI4ekRib0dIVlpyMTUvMUZpeGxOOG1GV0oyeXpHK2prNThr?= =?utf-8?B?N1VrelRxT0hDVE81Q1BvUmZWQ3cvenlESXlpRmVpQU5taFIvdjE0U3Y4Y0Q3?= =?utf-8?B?NzQvenUyVWxjRFczMURZaWdmbmIzemZRdmhRcVU2bFplRG8vTWNYZHVuRnB1?= =?utf-8?B?dUF2TGdwLzBMakFDeUt3MEZHMk9xaUZZVk9IbnpsZjhLdVkxd1d4aDU1SlVh?= =?utf-8?B?ejJtVjRjeGE4VDNvWVdDQVRFVHYrcERLUnU2OGhmMnZlRmxLRG5OVFhyNE53?= =?utf-8?B?RnRWQlJFUnVJSUlid3VSeFZsSzNuT2dTcitOYkZpcU1DcGpOSlcrUkllVHhu?= =?utf-8?B?YmZTaDNHUnBXbSt3aVNDZWdnZW92MU90WndqVjhCdjF0SmdqMTEyeWpBY2Rx?= =?utf-8?B?S29wUjJNNjBqRlZUcWYwakdWN2sxenUyZi9mMjErb2RtTkt3OEFnTTNuSmwz?= =?utf-8?B?V2RIQnhZZzFXNmxuSVJJNUVza0ljN3p3OEFRckFmY2NpcXR4ejBHRkpIQUxq?= =?utf-8?B?b3JkN2RkOXZ5dWxsZWtYcGIzWXpWZDZZQXU5VkZra0hGdHRzR0VGOGREMTJm?= =?utf-8?B?WEEwK3M4WTdHMHI3eE5MZys4M1d4ZUZ2ZjdrYWRXaHNoZDN1Ukk0NkNVNGtn?= =?utf-8?B?LzlLRFVQTkc1RldYT0kxR2wrKzZ5VW9rcHN2bUYvd0EycE5DKzJSeGROa3Rp?= =?utf-8?B?Ui82TkJjZDB6UWFsRnBmR2JsVlJKa0s0ZXJIUGJESmtEblk1Wlgydm1VdnA5?= =?utf-8?B?Z3BQVUMzOUtEbGhvY0FDWkxiL1RyeEt4amZienFBVXNWVHVKVnlkSnlhUTZ5?= =?utf-8?B?SzVDSEs4VE5vOHJWYmp6OTVyRTBpNVN5aEVEaExlZ0EwdTU2UndBeENtbVpZ?= =?utf-8?B?S0lWMDBvZ3dxVi9OZGJuaFc4V1JKdmQrYUwrTUdHNTdSOUNKOWMxUmpDRWtt?= =?utf-8?B?L3Njb2xKbjJlV0wzZExGTTNkNG9vUnZ2T3hGdWJuR3dMSnVvckN0ZStjRGU5?= =?utf-8?B?OCtyY2Nzekt0MGdlWDBMditwVjRLVDdPOWxWbnJpdDFTc2VoSUxiUy96QzRj?= =?utf-8?B?YU1tWkZqQ2V6aG9WaDhvYVE5ZzRmQ1FsSzhWcitybkl1WHk1NFJSdk1YSUVo?= =?utf-8?B?OEVia3dPdHpnd3hsbTkyWmoyU0dxaFFSdWlIWWdiUUFjQmZ5MW8yN2JWU2FG?= =?utf-8?B?QndQM0J6aUVWdU5KbGl4US9EWlQzcWtlaTJ5UVBmdHlJRmU5WmRHdkg2NGN1?= =?utf-8?B?eE05R20xVUVpSmhzSnhoUmh4YlNlc0N5MjAyNmZjL0NRVFlWZG1WejEyU21p?= =?utf-8?B?b0pQRHowRm1hMXgrUjJTUHl0VW5ITUJkUXByazRRcnY0YktXdWpDb09aaGFj?= =?utf-8?B?ckk4bWY3Rlgvak9seHRvZ2EwWnhrTlhYWU9LamU5anJkZk5Gck1FODl3SmhJ?= =?utf-8?B?TnJWRWt2b2kwb05lYTVVdTlpcnNzTFVLeDhzeXZjRGQwWGtiSk41Vmpwbld5?= =?utf-8?B?c3duejRCSzJsSkVXZ21TV3ZhTzdvTGIvajhzdFgvdEpzbFNlNElBNDZLYXN3?= =?utf-8?B?V3ZiRVB1V1FGOWJ1Y3g3aUhDN1VJd0g3cWg5bzZkQ1djVzY2RFlwYzJETHpo?= =?utf-8?B?SzlKb2phTkYvM0JUQ3duUms4NTdxRTVnT1VJZ0c5bW9HOWgwM1owYXZDSzda?= =?utf-8?B?M3N4NGRsUjJGTWMxNGEzcTI5REVxazdCWGxMMUVWeml3MEE9PQ==?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM7PR04MB7046.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(366016)(1800799024)(921020)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UW1PWVVoN21HOVB5TzZFdEZ4RVhucHZqcGNNUVpwM0hxNkhSVDc3U2RBUDlw?= =?utf-8?B?UkxiYjQrZDJrbFNtQ1JzVXRGZEZ1bmFmdUE4RUZPZnJEZ1NOKy9VdkludE56?= =?utf-8?B?SE5sV21SZTk5MU51RmJtNVRGWnNJMmovNDF3WFdGc24zYWxGY3ltNHpabGdI?= =?utf-8?B?c1FPalM4bjhjWlNMa25jeUx1U1F2NUVRc1lMNGlKL2ZGdEI0UWZGUkdneUIr?= =?utf-8?B?Zm5YZTJIQkhkRlJLUUpVbGNKaU5EcUljbGtxVWVnT0N0MlVIa2lYWC85eVlR?= =?utf-8?B?cU10aHdkbVM0dGkvSEVIYjQ0aGxZOUJLTU1CRnVNUFpWSGZoZEt6S04yeE5U?= =?utf-8?B?NDIrZGUzWVUvbnhnb1VsU1lGWmVacjhPdVRPQi8xaFlNS2hyY1BYMlJBeERM?= =?utf-8?B?d21vYkhrSU9rNkxwQWNRem1pSnZrTkx1VGtMVEVISzhOZml1Vk0zblROUkRu?= =?utf-8?B?cCtxbTFIU3VLMjdkd0JzZkdUczZBOEJCTDBQZWFFWjlxK1N4L1h3UUl6K1gx?= =?utf-8?B?c0Y1WjBXR3VHQW12cTJLYUp1ZzZ1RzNoK09lajVuTmtmWTNEdURXaGZnV0dm?= =?utf-8?B?bW9BN0RDRU41ZDFRaTBTb3h0MkZreXRmNFZZZTdvU1BPVWx6U3lNVkdVOWgr?= =?utf-8?B?RHlNRHY0cHlGNGZuakFjV2hrL0d1aTRCNGxXcEMrQndpa3ZzZW9PQktZc2NM?= =?utf-8?B?UGx1WGNncGRxeFBjK0V1TFFTVW9ZVmRKNkxmaFBJVnB5QUNrcm5KNGVoeXg3?= =?utf-8?B?ZjFRbG9nL1BJWmxBWnUwQkhvaXZHb1pYbEpjSjg5SmhMbmxJdjQzckZTVmor?= =?utf-8?B?MjY5VVY2aG5LYnFYMmRNWmdkYU5uM0FYT0ZuemY0VFBRRERaeDhBSkd2N09a?= =?utf-8?B?czBmNXNnVVcxVUpMZzlVY0RuNWpxUW5VRFZ3TDJ6UlNWeHd4eW5VemFScThr?= =?utf-8?B?emQ5RXBhYWtlK1B4Ung2djZGakdoU21lY3hZNTNUaGkxd3IwMDhobkNURitN?= =?utf-8?B?YU1weWloVE1jWDJVS3ZJQXpRSlJXU0Z2dTh0SG9aRzlmaHNWbjdwMENBNFNN?= =?utf-8?B?aXpDNFZzL0pTTkhHVTdpODZiUEFNemlqNWk1ZTJpdHhxMWFQSVRha1NTU1FZ?= =?utf-8?B?WUo3bUZJeTBGUWZueEtZNkMrNXBRamNDai9BVUtEQWV4NFpMZm5aR1JLdEpr?= =?utf-8?B?NWZUck5XdUVwZHZxRzM4VlVkdC9VQlBLcEkxWm1UMCtOclUvZHBCNGRnNXVk?= =?utf-8?B?eHZrMnJqSlFFcjUvbTk2Z2xxQytSOCtFb1ZjTnUySDkxR084TWpPYnVSMjlN?= =?utf-8?B?OEM0OHJaMEdvYWhYV2dUa21YckdsU0VRZUlJTjdmdG0vQk50cHhFZlkzYkxk?= =?utf-8?B?VXU0Z0l3QnM5MjZBcmRPMXZIRUI0UXpWd3E2cHBLNldJZlFHcDM1enlVZEZF?= =?utf-8?B?RGVmNWVXeVpKcmtpRjVmSFl5MWF2WVU5c0QrcnJ3VFVSQU9rMGxzTWFjdm1r?= =?utf-8?B?ODM2Z1JoSUdXYWhxRjUzb00vbU5UcVY5MU5sSDY2bUpDU1M1VWhUdkN0ZGd6?= =?utf-8?B?dGxHMEtxTWJsYm5PN0VHQlhCQmZPSjRQbjhvVFBqUmhXbDBWMmdxWk1GZmZS?= =?utf-8?B?Z3NUUFB4RU9odkE5VXlyR1RxS21IeStKVFA0Tkw1cmRuVE9XR2NzQXFsaE1T?= =?utf-8?B?OTJ2RS9mRkVCTUtYSVZhZWRaSEVEbURTNk4vMTBHSzNoK2RQbEpTaEVZZkxJ?= =?utf-8?B?dFFLOWwwdTVSZUErUzczZU9aN1psSWhhZlF1Y01wQ0NTdGkzTGErVHJFdDlV?= =?utf-8?B?QmJsU0pJQzM3OVYvTDJacTFLWFNHY1J1dnFrT21SNE1CUHNIaGkwak1aRWI4?= =?utf-8?B?cVVsenB2Z29WWU9zUVhTSnQ1ZldUY3pCRWdxSngxYXdXaUlmZ0w2UFZDaS9r?= =?utf-8?B?RjZCejZvUlVYSTQ5dUhXQ1QwRFlXMFJWVjJvY1gxeDd0ZGtTZVhXWEROTnFM?= =?utf-8?B?QmFNaXAxcTVmdjY5cGlKYnVtUk1SMTA4TUhndWRyVnp3Sk9Ienk2d200WmNB?= =?utf-8?B?bGlhM0N2clZNZXlpMXcwaVRNc0lVNC90VGVCdHkreGh5aWphSFBXc042Y3Y0?= =?utf-8?Q?uV5c4LelxNI+UTtQvkGGnjZVS?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6c37c6f8-68c4-4d8d-62e0-08dd5d41d2dd X-MS-Exchange-CrossTenant-AuthSource: AM7PR04MB7046.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Mar 2025 06:32:25.0226 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: K24V+tQiXFILriBj3mhnfgpHPaSIdSoQ9xhAl8e2yvFtxHZGF0oTPIxdAhyX2Z7bpv0JyIwwias9gkDG2Y228w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS5PR04MB9972 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250306_223229_407940_C73398F0 X-CRM114-Status: GOOD ( 18.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 03/07/2025, Luca Ceresoli wrote: > This warning notifies a clock was set to an inaccurate value. Modify the > string to also show the clock name. > > While doing that also rewrap the entire function call. > > Signed-off-by: Luca Ceresoli > --- > drivers/gpu/drm/bridge/fsl-ldb.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/fsl-ldb.c b/drivers/gpu/drm/bridge/fsl-ldb.c > index 0fc8a14fd80062248a43b8b93272101a7ca6158a..c7c899a9644bb827845fb3fe96a9695d79a91474 100644 > --- a/drivers/gpu/drm/bridge/fsl-ldb.c > +++ b/drivers/gpu/drm/bridge/fsl-ldb.c > @@ -181,9 +181,9 @@ static void fsl_ldb_atomic_enable(struct drm_bridge *bridge, > > configured_link_freq = clk_get_rate(fsl_ldb->clk); > if (configured_link_freq != requested_link_freq) > - dev_warn(fsl_ldb->dev, "Configured LDB clock (%lu Hz) does not match requested LVDS clock: %lu Hz\n", > - configured_link_freq, > - requested_link_freq); > + dev_warn(fsl_ldb->dev, > + "Configured %pC clock (%lu Hz) does not match requested LVDS clock: %lu Hz\n", > + fsl_ldb->clk, configured_link_freq, requested_link_freq); Though this slightly changes the warning message userspace sees, I guess it is acceptable. Does it make sense to s/%pC/%pCn/ so that the clock name is printed in lower case instead of upper case, since it seems that all i.MX specific clock names are in lower case? > > clk_prepare_enable(fsl_ldb->clk); > > -- Regards, Liu Ying