linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v4 0/3] Add mediatek,gce-props.yaml for other bindings reference
@ 2024-01-24  1:14 Jason-JH.Lin
  2024-01-24  1:14 ` [PATCH v4 1/3] dt-bindings: mailbox: Add mediatek,gce-props.yaml Jason-JH.Lin
                   ` (2 more replies)
  0 siblings, 3 replies; 13+ messages in thread
From: Jason-JH.Lin @ 2024-01-24  1:14 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
	AngeloGioacchino Del Regno, Chun-Kuang Hu
  Cc: devicetree, linux-kernel, linux-arm-kernel, linux-mediatek,
	dri-devel, linux-media, linaro-mm-sig, Jason-ch Chen,
	Johnson Wang, Jason-JH . Lin, Singo Chang, Nancy Lin, Shawn Sung,
	Project_Global_Chrome_Upstream_Group, Fei Shao, Jason-jh Lin

From: Jason-jh Lin <jason-jh.lin@mediatek.corp-partner.google.com>

The property "mediatek,gce-events" is used for GCE event ID corresponding
to a hardware event signal sent by the hardware or a software driver.
If the mailbox providers or consumers want to manipulate the value of
the event ID, they need to know the specific event ID.

Since mediatek,gce-events property is used for both mailbox producers
and consumers, we add a mediatek,gce-props.yaml to place the common GCE
properties like mediatek,gce-events.

Change in v4:
1. Fix some typo.
2. Change maxItems of gce-events from 1024 to 32.

Change in v3:
1. Add more description and fix typo and grammar.
2. Fix $ref as full path.

Change in v2:
1. Add mediatek,gce-props.yaml for other binding reference.

Jason-JH.Lin (3):
  dt-bindings: mailbox: Add mediatek,gce-props.yaml
  dt-bindings: media: mediatek: mdp: Change mediatek,gce-events to
    reference
  dt-bindings: soc: mediatek: Change mediatek,gce-events to refernece

 .../bindings/mailbox/mediatek,gce-props.yaml  | 52 +++++++++++++++++++
 .../bindings/media/mediatek,mdp3-rdma.yaml    | 11 ++--
 .../bindings/media/mediatek,mdp3-rsz.yaml     | 12 ++---
 .../bindings/media/mediatek,mdp3-wrot.yaml    | 12 ++---
 .../bindings/soc/mediatek/mediatek,ccorr.yaml | 12 ++---
 .../bindings/soc/mediatek/mediatek,mutex.yaml | 11 ++--
 .../bindings/soc/mediatek/mediatek,wdma.yaml  | 12 ++---
 7 files changed, 74 insertions(+), 48 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/mailbox/mediatek,gce-props.yaml

-- 
2.18.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [PATCH v4 1/3] dt-bindings: mailbox: Add mediatek,gce-props.yaml
  2024-01-24  1:14 [PATCH v4 0/3] Add mediatek,gce-props.yaml for other bindings reference Jason-JH.Lin
@ 2024-01-24  1:14 ` Jason-JH.Lin
  2024-01-24  8:57   ` AngeloGioacchino Del Regno
  2024-01-24  1:14 ` [PATCH v4 2/3] dt-bindings: media: mediatek: mdp: Change mediatek,gce-events to reference Jason-JH.Lin
  2024-01-24  1:14 ` [PATCH v4 3/3] dt-bindings: soc: mediatek: Change mediatek,gce-events to refernece Jason-JH.Lin
  2 siblings, 1 reply; 13+ messages in thread
From: Jason-JH.Lin @ 2024-01-24  1:14 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
	AngeloGioacchino Del Regno, Chun-Kuang Hu
  Cc: devicetree, linux-kernel, linux-arm-kernel, linux-mediatek,
	dri-devel, linux-media, linaro-mm-sig, Jason-ch Chen,
	Johnson Wang, Jason-JH . Lin, Singo Chang, Nancy Lin, Shawn Sung,
	Project_Global_Chrome_Upstream_Group, Fei Shao

Add mediatek,gce-props.yaml for common GCE properties that is used for
both mailbox providers and consumers. We place the common property
"mediatek,gce-events" in this binding currently.

The property "mediatek,gce-events" is used for GCE event ID corresponding
to a hardware event signal sent by the hardware or a software driver.
If the mailbox providers or consumers want to manipulate the value of
the event ID, they need to know the specific event ID.

Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
---
 .../bindings/mailbox/mediatek,gce-props.yaml  | 52 +++++++++++++++++++
 1 file changed, 52 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mailbox/mediatek,gce-props.yaml

diff --git a/Documentation/devicetree/bindings/mailbox/mediatek,gce-props.yaml b/Documentation/devicetree/bindings/mailbox/mediatek,gce-props.yaml
new file mode 100644
index 000000000000..c25eed4606fe
--- /dev/null
+++ b/Documentation/devicetree/bindings/mailbox/mediatek,gce-props.yaml
@@ -0,0 +1,52 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mailbox/mediatek,gce-props.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: MediaTek Global Command Engine Common Properties
+
+maintainers:
+  - Houlong Wei <houlong.wei@mediatek.com>
+
+description:
+  The Global Command Engine (GCE) is an instruction based, multi-threaded,
+  single-core command dispatcher for MediaTek hardware. The Command Queue
+  (CMDQ) mailbox driver is a driver for GCE, implemented using the Linux
+  mailbox framework. It is used to receive messages from mailbox consumers
+  and configure GCE to execute the specified instruction set in the message.
+  We use mediatek,gce-mailbox.yaml to define the properties for CMDQ mailbox
+  driver. A device driver that uses the CMDQ driver to configure its hardware
+  registers is a mailbox consumer. The mailbox consumer can request a mailbox
+  channel corresponding to a GCE hardware thread to send a message, specifying
+  that the GCE thread to configure its hardware. The mailbox provider can also
+  reserve a mailbox channel to configure GCE hardware register by the specific
+  GCE thread. This binding defines the common GCE properties for both mailbox
+  provider and consumers.
+
+properties:
+  mediatek,gce-events:
+    description:
+      GCE has an event table in SRAM, consisting of 1024 event IDs (0~1023).
+      Each event ID has a boolean event value with the default value 0.
+      The property mediatek,gce-events is used to obtain the event IDs.
+      Some gce-events are hardware-bound and cannot be changed by software.
+      For instance, in MT8195, when VDO0_MUTEX is stream done, VDO_MUTEX will
+      send an event signal to GCE, setting the value of event ID 597 to 1.
+      Similarly, in MT8188, the value of event ID 574 will be set to 1 when
+      VOD0_MUTEX is stream done.
+      On the other hand, some gce-events are not hardware-bound and can be
+      changed by software. For example, in MT8188, we can set the value of
+      event ID 855, which is not bound to any hardware, to 1 when the driver
+      in the secure world completes a task. However, in MT8195, event ID 855
+      is already bound to VDEC_LAT1, so we need to select another event ID to
+      achieve the same purpose. This event ID can be any ID that is not bound
+      to any hardware and is not yet used in any software driver.
+      To determine if the event ID is bound to the hardware or used by a
+      software driver, refer to the GCE header
+      include/dt-bindings/gce/<chip>-gce.h of each chip.
+    $ref: /schemas/types.yaml#/definitions/uint32-array
+    minItems: 1
+    maxItems: 32
+
+additionalProperties: true
-- 
2.18.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH v4 2/3] dt-bindings: media: mediatek: mdp: Change mediatek,gce-events to reference
  2024-01-24  1:14 [PATCH v4 0/3] Add mediatek,gce-props.yaml for other bindings reference Jason-JH.Lin
  2024-01-24  1:14 ` [PATCH v4 1/3] dt-bindings: mailbox: Add mediatek,gce-props.yaml Jason-JH.Lin
@ 2024-01-24  1:14 ` Jason-JH.Lin
  2024-01-24  8:57   ` AngeloGioacchino Del Regno
  2024-07-11  1:35   ` Jason-JH Lin (林睿祥)
  2024-01-24  1:14 ` [PATCH v4 3/3] dt-bindings: soc: mediatek: Change mediatek,gce-events to refernece Jason-JH.Lin
  2 siblings, 2 replies; 13+ messages in thread
From: Jason-JH.Lin @ 2024-01-24  1:14 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
	AngeloGioacchino Del Regno, Chun-Kuang Hu
  Cc: devicetree, linux-kernel, linux-arm-kernel, linux-mediatek,
	dri-devel, linux-media, linaro-mm-sig, Jason-ch Chen,
	Johnson Wang, Jason-JH . Lin, Singo Chang, Nancy Lin, Shawn Sung,
	Project_Global_Chrome_Upstream_Group, Fei Shao

Change mediatek,gce-events property to reference mediatek,gce-props.yaml
instead of defining itself.

Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
---
 .../bindings/media/mediatek,mdp3-rdma.yaml           | 11 +++--------
 .../devicetree/bindings/media/mediatek,mdp3-rsz.yaml | 12 ++++--------
 .../bindings/media/mediatek,mdp3-wrot.yaml           | 12 ++++--------
 3 files changed, 11 insertions(+), 24 deletions(-)

diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml
index 59db8306485b..4a286d46c8ee 100644
--- a/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml
+++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml
@@ -44,13 +44,6 @@ properties:
       4 arguments defined in this property. Each GCE subsys id is mapping to
       a client defined in the header include/dt-bindings/gce/<chip>-gce.h.
 
-  mediatek,gce-events:
-    description:
-      The event id which is mapping to the specific hardware event signal
-      to gce. The event id is defined in the gce header
-      include/dt-bindings/gce/<chip>-gce.h of each chips.
-    $ref: /schemas/types.yaml#/definitions/uint32-array
-
   mediatek,scp:
     $ref: /schemas/types.yaml#/definitions/phandle
     description:
@@ -96,6 +89,8 @@ required:
   - '#dma-cells'
 
 allOf:
+  - $ref: /schemas/mailbox/mediatek,gce-props.yaml
+
   - if:
       properties:
         compatible:
@@ -142,7 +137,7 @@ allOf:
         clocks:
           maxItems: 1
 
-additionalProperties: false
+unevaluatedProperties: false
 
 examples:
   - |
diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-rsz.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-rsz.yaml
index f5676bec4326..4774fdde1a1b 100644
--- a/Documentation/devicetree/bindings/media/mediatek,mdp3-rsz.yaml
+++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-rsz.yaml
@@ -38,13 +38,6 @@ properties:
       4 arguments defined in this property. Each GCE subsys id is mapping to
       a client defined in the header include/dt-bindings/gce/<chip>-gce.h.
 
-  mediatek,gce-events:
-    description:
-      The event id which is mapping to the specific hardware event signal
-      to gce. The event id is defined in the gce header
-      include/dt-bindings/gce/<chip>-gce.h of each chips.
-    $ref: /schemas/types.yaml#/definitions/uint32-array
-
   clocks:
     minItems: 1
 
@@ -55,7 +48,10 @@ required:
   - mediatek,gce-events
   - clocks
 
-additionalProperties: false
+allOf:
+  - $ref: /schemas/mailbox/mediatek,gce-props.yaml
+
+unevaluatedProperties: false
 
 examples:
   - |
diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-wrot.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-wrot.yaml
index 53a679338402..a31f3f5aea96 100644
--- a/Documentation/devicetree/bindings/media/mediatek,mdp3-wrot.yaml
+++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-wrot.yaml
@@ -38,13 +38,6 @@ properties:
       4 arguments defined in this property. Each GCE subsys id is mapping to
       a client defined in the header include/dt-bindings/gce/<chip>-gce.h.
 
-  mediatek,gce-events:
-    description:
-      The event id which is mapping to the specific hardware event signal
-      to gce. The event id is defined in the gce header
-      include/dt-bindings/gce/<chip>-gce.h of each chips.
-    $ref: /schemas/types.yaml#/definitions/uint32-array
-
   power-domains:
     maxItems: 1
 
@@ -67,7 +60,10 @@ required:
   - iommus
   - '#dma-cells'
 
-additionalProperties: false
+allOf:
+  - $ref: /schemas/mailbox/mediatek,gce-props.yaml
+
+unevaluatedProperties: false
 
 examples:
   - |
-- 
2.18.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH v4 3/3] dt-bindings: soc: mediatek: Change mediatek,gce-events to refernece
  2024-01-24  1:14 [PATCH v4 0/3] Add mediatek,gce-props.yaml for other bindings reference Jason-JH.Lin
  2024-01-24  1:14 ` [PATCH v4 1/3] dt-bindings: mailbox: Add mediatek,gce-props.yaml Jason-JH.Lin
  2024-01-24  1:14 ` [PATCH v4 2/3] dt-bindings: media: mediatek: mdp: Change mediatek,gce-events to reference Jason-JH.Lin
@ 2024-01-24  1:14 ` Jason-JH.Lin
  2024-01-24  8:57   ` AngeloGioacchino Del Regno
  2 siblings, 1 reply; 13+ messages in thread
From: Jason-JH.Lin @ 2024-01-24  1:14 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
	AngeloGioacchino Del Regno, Chun-Kuang Hu
  Cc: devicetree, linux-kernel, linux-arm-kernel, linux-mediatek,
	dri-devel, linux-media, linaro-mm-sig, Jason-ch Chen,
	Johnson Wang, Jason-JH . Lin, Singo Chang, Nancy Lin, Shawn Sung,
	Project_Global_Chrome_Upstream_Group, Fei Shao

Change mediatek,gce-events property to reference mediatek,gce-props.yaml
instead of defining itself.

Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
---
 .../bindings/soc/mediatek/mediatek,ccorr.yaml        | 12 ++++--------
 .../bindings/soc/mediatek/mediatek,mutex.yaml        | 11 +++--------
 .../bindings/soc/mediatek/mediatek,wdma.yaml         | 12 ++++--------
 3 files changed, 11 insertions(+), 24 deletions(-)

diff --git a/Documentation/devicetree/bindings/soc/mediatek/mediatek,ccorr.yaml b/Documentation/devicetree/bindings/soc/mediatek/mediatek,ccorr.yaml
index 4380b98b0dfe..305f2cd9f865 100644
--- a/Documentation/devicetree/bindings/soc/mediatek/mediatek,ccorr.yaml
+++ b/Documentation/devicetree/bindings/soc/mediatek/mediatek,ccorr.yaml
@@ -34,13 +34,6 @@ properties:
       4 arguments defined in this property. Each GCE subsys id is mapping to
       a client defined in the header include/dt-bindings/gce/<chip>-gce.h.
 
-  mediatek,gce-events:
-    description:
-      The event id which is mapping to the specific hardware event signal
-      to gce. The event id is defined in the gce header
-      include/dt-bindings/gce/<chip>-gce.h of each chips.
-    $ref: /schemas/types.yaml#/definitions/uint32-array
-
   clocks:
     minItems: 1
 
@@ -51,7 +44,10 @@ required:
   - mediatek,gce-events
   - clocks
 
-additionalProperties: false
+allOf:
+  - $ref: /schemas/mailbox/mediatek,gce-props.yaml#
+
+unevaluatedProperties: false
 
 examples:
   - |
diff --git a/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml b/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml
index ba2014a8725c..61cf16ce8b0b 100644
--- a/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml
+++ b/Documentation/devicetree/bindings/soc/mediatek/mediatek,mutex.yaml
@@ -53,13 +53,6 @@ properties:
     items:
       - description: MUTEX Clock
 
-  mediatek,gce-events:
-    description:
-      The event id which is mapping to the specific hardware event signal
-      to gce. The event id is defined in the gce header
-      include/dt-bindings/gce/<chip>-gce.h of each chips.
-    $ref: /schemas/types.yaml#/definitions/uint32-array
-
   mediatek,gce-client-reg:
     $ref: /schemas/types.yaml#/definitions/phandle-array
     items:
@@ -73,6 +66,8 @@ properties:
       a client defined in the header include/dt-bindings/gce/<chip>-gce.h.
 
 allOf:
+  - $ref: /schemas/mailbox/mediatek,gce-props.yaml#
+
   - if:
       properties:
         compatible:
@@ -97,7 +92,7 @@ required:
   - interrupts
   - power-domains
 
-additionalProperties: false
+unevaluatedProperties: false
 
 examples:
   - |
diff --git a/Documentation/devicetree/bindings/soc/mediatek/mediatek,wdma.yaml b/Documentation/devicetree/bindings/soc/mediatek/mediatek,wdma.yaml
index 69afb329e5f4..d9dd4428c036 100644
--- a/Documentation/devicetree/bindings/soc/mediatek/mediatek,wdma.yaml
+++ b/Documentation/devicetree/bindings/soc/mediatek/mediatek,wdma.yaml
@@ -35,13 +35,6 @@ properties:
       4 arguments defined in this property. Each GCE subsys id is mapping to
       a client defined in the header include/dt-bindings/gce/<chip>-gce.h.
 
-  mediatek,gce-events:
-    description:
-      The event id which is mapping to the specific hardware event signal
-      to gce. The event id is defined in the gce header
-      include/dt-bindings/gce/<chip>-gce.h of each chips.
-    $ref: /schemas/types.yaml#/definitions/uint32-array
-
   power-domains:
     maxItems: 1
 
@@ -60,7 +53,10 @@ required:
   - clocks
   - iommus
 
-additionalProperties: false
+allOf:
+  - $ref: /schemas/mailbox/mediatek,gce-props.yaml#
+
+unevaluatedProperties: false
 
 examples:
   - |
-- 
2.18.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* Re: [PATCH v4 1/3] dt-bindings: mailbox: Add mediatek,gce-props.yaml
  2024-01-24  1:14 ` [PATCH v4 1/3] dt-bindings: mailbox: Add mediatek,gce-props.yaml Jason-JH.Lin
@ 2024-01-24  8:57   ` AngeloGioacchino Del Regno
  2024-05-26 15:04     ` Jason-JH Lin (林睿祥)
  0 siblings, 1 reply; 13+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-01-24  8:57 UTC (permalink / raw)
  To: Jason-JH.Lin, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Matthias Brugger, Chun-Kuang Hu
  Cc: devicetree, linux-kernel, linux-arm-kernel, linux-mediatek,
	dri-devel, linux-media, linaro-mm-sig, Jason-ch Chen,
	Johnson Wang, Singo Chang, Nancy Lin, Shawn Sung,
	Project_Global_Chrome_Upstream_Group, Fei Shao

Il 24/01/24 02:14, Jason-JH.Lin ha scritto:
> Add mediatek,gce-props.yaml for common GCE properties that is used for
> both mailbox providers and consumers. We place the common property
> "mediatek,gce-events" in this binding currently.
> 
> The property "mediatek,gce-events" is used for GCE event ID corresponding
> to a hardware event signal sent by the hardware or a software driver.
> If the mailbox providers or consumers want to manipulate the value of
> the event ID, they need to know the specific event ID.
> 
> Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v4 3/3] dt-bindings: soc: mediatek: Change mediatek,gce-events to refernece
  2024-01-24  1:14 ` [PATCH v4 3/3] dt-bindings: soc: mediatek: Change mediatek,gce-events to refernece Jason-JH.Lin
@ 2024-01-24  8:57   ` AngeloGioacchino Del Regno
  0 siblings, 0 replies; 13+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-01-24  8:57 UTC (permalink / raw)
  To: Jason-JH.Lin, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Matthias Brugger, Chun-Kuang Hu
  Cc: devicetree, linux-kernel, linux-arm-kernel, linux-mediatek,
	dri-devel, linux-media, linaro-mm-sig, Jason-ch Chen,
	Johnson Wang, Singo Chang, Nancy Lin, Shawn Sung,
	Project_Global_Chrome_Upstream_Group, Fei Shao

Il 24/01/24 02:14, Jason-JH.Lin ha scritto:
> Change mediatek,gce-events property to reference mediatek,gce-props.yaml
> instead of defining itself.
> 
> Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v4 2/3] dt-bindings: media: mediatek: mdp: Change mediatek,gce-events to reference
  2024-01-24  1:14 ` [PATCH v4 2/3] dt-bindings: media: mediatek: mdp: Change mediatek,gce-events to reference Jason-JH.Lin
@ 2024-01-24  8:57   ` AngeloGioacchino Del Regno
  2024-07-11  1:35   ` Jason-JH Lin (林睿祥)
  1 sibling, 0 replies; 13+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-01-24  8:57 UTC (permalink / raw)
  To: Jason-JH.Lin, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Matthias Brugger, Chun-Kuang Hu
  Cc: devicetree, linux-kernel, linux-arm-kernel, linux-mediatek,
	dri-devel, linux-media, linaro-mm-sig, Jason-ch Chen,
	Johnson Wang, Singo Chang, Nancy Lin, Shawn Sung,
	Project_Global_Chrome_Upstream_Group, Fei Shao

Il 24/01/24 02:14, Jason-JH.Lin ha scritto:
> Change mediatek,gce-events property to reference mediatek,gce-props.yaml
> instead of defining itself.
> 
> Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v4 1/3] dt-bindings: mailbox: Add mediatek,gce-props.yaml
  2024-01-24  8:57   ` AngeloGioacchino Del Regno
@ 2024-05-26 15:04     ` Jason-JH Lin (林睿祥)
  2024-05-28 10:26       ` AngeloGioacchino Del Regno
  2024-07-10 14:28       ` Jassi Brar
  0 siblings, 2 replies; 13+ messages in thread
From: Jason-JH Lin (林睿祥) @ 2024-05-26 15:04 UTC (permalink / raw)
  To: jassisinghbrar@gmail.com, matthias.bgg@gmail.com,
	chunkuang.hu@kernel.org, angelogioacchino.delregno@collabora.com,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org
  Cc: linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
	Singo Chang (張興國),
	Johnson Wang (王聖鑫),
	linaro-mm-sig@lists.linaro.org, linux-media@vger.kernel.org,
	devicetree@vger.kernel.org,
	Jason-ch Chen (陳建豪),
	Shawn Sung (宋孝謙),
	Nancy Lin (林欣螢),
	dri-devel@lists.freedesktop.org,
	Project_Global_Chrome_Upstream_Group,
	linux-arm-kernel@lists.infradead.org, fshao@chromium.org

Hi Angelo, Jassi,

Could you help me apply this series?
Thanks!

Regards,
Jason-JH.Lin

On Wed, 2024-01-24 at 09:57 +0100, AngeloGioacchino Del Regno wrote:
> Il 24/01/24 02:14, Jason-JH.Lin ha scritto:
> > Add mediatek,gce-props.yaml for common GCE properties that is used
> > for
> > both mailbox providers and consumers. We place the common property
> > "mediatek,gce-events" in this binding currently.
> > 
> > The property "mediatek,gce-events" is used for GCE event ID
> > corresponding
> > to a hardware event signal sent by the hardware or a software
> > driver.
> > If the mailbox providers or consumers want to manipulate the value
> > of
> > the event ID, they need to know the specific event ID.
> > 
> > Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
> > Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
> 
> Reviewed-by: AngeloGioacchino Del Regno <
> angelogioacchino.delregno@collabora.com>
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v4 1/3] dt-bindings: mailbox: Add mediatek,gce-props.yaml
  2024-05-26 15:04     ` Jason-JH Lin (林睿祥)
@ 2024-05-28 10:26       ` AngeloGioacchino Del Regno
  2024-07-10 14:28       ` Jassi Brar
  1 sibling, 0 replies; 13+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-05-28 10:26 UTC (permalink / raw)
  To: Jason-JH Lin (林睿祥), jassisinghbrar@gmail.com,
	matthias.bgg@gmail.com, chunkuang.hu@kernel.org,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org
  Cc: linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
	Singo Chang (張興國),
	Johnson Wang (王聖鑫),
	linaro-mm-sig@lists.linaro.org, linux-media@vger.kernel.org,
	devicetree@vger.kernel.org,
	Jason-ch Chen (陳建豪),
	Shawn Sung (宋孝謙),
	Nancy Lin (林欣螢),
	dri-devel@lists.freedesktop.org,
	Project_Global_Chrome_Upstream_Group,
	linux-arm-kernel@lists.infradead.org, fshao@chromium.org

Il 26/05/24 17:04, Jason-JH Lin (林睿祥) ha scritto:
> Hi Angelo, Jassi,
> 
> Could you help me apply this series?
> Thanks!
> 

That's not me, it's Jassi - green light from me, btw.

Cheers,
Angelo

> Regards,
> Jason-JH.Lin
> 
> On Wed, 2024-01-24 at 09:57 +0100, AngeloGioacchino Del Regno wrote:
>> Il 24/01/24 02:14, Jason-JH.Lin ha scritto:
>>> Add mediatek,gce-props.yaml for common GCE properties that is used
>>> for
>>> both mailbox providers and consumers. We place the common property
>>> "mediatek,gce-events" in this binding currently.
>>>
>>> The property "mediatek,gce-events" is used for GCE event ID
>>> corresponding
>>> to a hardware event signal sent by the hardware or a software
>>> driver.
>>> If the mailbox providers or consumers want to manipulate the value
>>> of
>>> the event ID, they need to know the specific event ID.
>>>
>>> Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
>>> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
>>
>> Reviewed-by: AngeloGioacchino Del Regno <
>> angelogioacchino.delregno@collabora.com>
>>
> 



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v4 1/3] dt-bindings: mailbox: Add mediatek,gce-props.yaml
  2024-05-26 15:04     ` Jason-JH Lin (林睿祥)
  2024-05-28 10:26       ` AngeloGioacchino Del Regno
@ 2024-07-10 14:28       ` Jassi Brar
  2024-07-10 16:22         ` Jassi Brar
  1 sibling, 1 reply; 13+ messages in thread
From: Jassi Brar @ 2024-07-10 14:28 UTC (permalink / raw)
  To: Jason-JH Lin (林睿祥)
  Cc: matthias.bgg@gmail.com, chunkuang.hu@kernel.org,
	angelogioacchino.delregno@collabora.com, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
	Singo Chang (張興國),
	Johnson Wang (王聖鑫),
	linaro-mm-sig@lists.linaro.org, linux-media@vger.kernel.org,
	devicetree@vger.kernel.org,
	Jason-ch Chen (陳建豪),
	Shawn Sung (宋孝謙),
	Nancy Lin (林欣螢),
	dri-devel@lists.freedesktop.org,
	Project_Global_Chrome_Upstream_Group,
	linux-arm-kernel@lists.infradead.org, fshao@chromium.org

On Sun, May 26, 2024 at 10:04 AM Jason-JH Lin (林睿祥)
<Jason-JH.Lin@mediatek.com> wrote:
>
> Hi Angelo, Jassi,
>
> Could you help me apply this series?
> Thanks!
>
Please get it reviewed by DT maintainers .... Rob or Krzysztof.

-Jassi


^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v4 1/3] dt-bindings: mailbox: Add mediatek,gce-props.yaml
  2024-07-10 14:28       ` Jassi Brar
@ 2024-07-10 16:22         ` Jassi Brar
  2024-07-11  1:14           ` Jason-JH Lin (林睿祥)
  0 siblings, 1 reply; 13+ messages in thread
From: Jassi Brar @ 2024-07-10 16:22 UTC (permalink / raw)
  To: Jason-JH Lin (林睿祥)
  Cc: matthias.bgg@gmail.com, chunkuang.hu@kernel.org,
	angelogioacchino.delregno@collabora.com, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
	Singo Chang (張興國),
	Johnson Wang (王聖鑫),
	linaro-mm-sig@lists.linaro.org, linux-media@vger.kernel.org,
	devicetree@vger.kernel.org,
	Jason-ch Chen (陳建豪),
	Shawn Sung (宋孝謙),
	Nancy Lin (林欣螢),
	dri-devel@lists.freedesktop.org,
	Project_Global_Chrome_Upstream_Group,
	linux-arm-kernel@lists.infradead.org, fshao@chromium.org

On Wed, Jul 10, 2024 at 9:28 AM Jassi Brar <jassisinghbrar@gmail.com> wrote:
>
> On Sun, May 26, 2024 at 10:04 AM Jason-JH Lin (林睿祥)
> <Jason-JH.Lin@mediatek.com> wrote:
> >
> > Hi Angelo, Jassi,
> >
> > Could you help me apply this series?
> > Thanks!
> >
> Please get it reviewed by DT maintainers .... Rob or Krzysztof.
>
I see Conor Dooley listed as another maintainer, so I am picking it up.
BTW, I was not CC'ed on the original patch.

-Jassi


^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v4 1/3] dt-bindings: mailbox: Add mediatek,gce-props.yaml
  2024-07-10 16:22         ` Jassi Brar
@ 2024-07-11  1:14           ` Jason-JH Lin (林睿祥)
  0 siblings, 0 replies; 13+ messages in thread
From: Jason-JH Lin (林睿祥) @ 2024-07-11  1:14 UTC (permalink / raw)
  To: jassisinghbrar@gmail.com
  Cc: linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
	robh+dt@kernel.org, Johnson Wang (王聖鑫),
	Singo Chang (張興國),
	linaro-mm-sig@lists.linaro.org, chunkuang.hu@kernel.org,
	devicetree@vger.kernel.org, linux-media@vger.kernel.org,
	Jason-ch Chen (陳建豪),
	Shawn Sung (宋孝謙),
	Nancy Lin (林欣螢), conor+dt@kernel.org,
	dri-devel@lists.freedesktop.org,
	Project_Global_Chrome_Upstream_Group,
	linux-arm-kernel@lists.infradead.org,
	krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com,
	fshao@chromium.org, angelogioacchino.delregno@collabora.com

On Wed, 2024-07-10 at 11:22 -0500, Jassi Brar wrote:
>  	 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>  On Wed, Jul 10, 2024 at 9:28 AM Jassi Brar <jassisinghbrar@gmail.com
> > wrote:
> >
> > On Sun, May 26, 2024 at 10:04 AM Jason-JH Lin (林睿祥)
> > <Jason-JH.Lin@mediatek.com> wrote:
> > >
> > > Hi Angelo, Jassi,
> > >
> > > Could you help me apply this series?
> > > Thanks!
> > >
> > Please get it reviewed by DT maintainers .... Rob or Krzysztof.
> >
> I see Conor Dooley listed as another maintainer, so I am picking it
> up.
> BTW, I was not CC'ed on the original patch.

Oh, I see..
I'll check it next time.
Thanks for noticing this patch.

Regards,
Jason-JH.Lin

> 
> -Jassi

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v4 2/3] dt-bindings: media: mediatek: mdp: Change mediatek,gce-events to reference
  2024-01-24  1:14 ` [PATCH v4 2/3] dt-bindings: media: mediatek: mdp: Change mediatek,gce-events to reference Jason-JH.Lin
  2024-01-24  8:57   ` AngeloGioacchino Del Regno
@ 2024-07-11  1:35   ` Jason-JH Lin (林睿祥)
  1 sibling, 0 replies; 13+ messages in thread
From: Jason-JH Lin (林睿祥) @ 2024-07-11  1:35 UTC (permalink / raw)
  To: matthias.bgg@gmail.com, mchehab@kernel.org,
	chunkuang.hu@kernel.org, conor+dt@kernel.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org,
	angelogioacchino.delregno@collabora.com
  Cc: linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
	Singo Chang (張興國),
	Johnson Wang (王聖鑫),
	linaro-mm-sig@lists.linaro.org, linux-media@vger.kernel.org,
	devicetree@vger.kernel.org,
	Jason-ch Chen (陳建豪),
	Shawn Sung (宋孝謙),
	Nancy Lin (林欣螢),
	dri-devel@lists.freedesktop.org,
	Project_Global_Chrome_Upstream_Group,
	linux-arm-kernel@lists.infradead.org, fshao@chromium.org

Hi Mauro,

Sorry for missing CC this patch to you.
Could you please take a look at this?
Thanks!

Regards,
Jason-JH.Lin

On Wed, 2024-01-24 at 09:14 +0800, Jason-JH.Lin wrote:
> Change mediatek,gce-events property to reference mediatek,gce-
> props.yaml
> instead of defining itself.
> 
> Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
> ---
>  .../bindings/media/mediatek,mdp3-rdma.yaml           | 11 +++-------
> -
>  .../devicetree/bindings/media/mediatek,mdp3-rsz.yaml | 12 ++++----
> ----
>  .../bindings/media/mediatek,mdp3-wrot.yaml           | 12 ++++----
> ----
>  3 files changed, 11 insertions(+), 24 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-
> rdma.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-
> rdma.yaml
> index 59db8306485b..4a286d46c8ee 100644
> --- a/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml
> +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml
> @@ -44,13 +44,6 @@ properties:
>        4 arguments defined in this property. Each GCE subsys id is
> mapping to
>        a client defined in the header include/dt-bindings/gce/<chip>-
> gce.h.
>  
> -  mediatek,gce-events:
> -    description:
> -      The event id which is mapping to the specific hardware event
> signal
> -      to gce. The event id is defined in the gce header
> -      include/dt-bindings/gce/<chip>-gce.h of each chips.
> -    $ref: /schemas/types.yaml#/definitions/uint32-array
> -
>    mediatek,scp:
>      $ref: /schemas/types.yaml#/definitions/phandle
>      description:
> @@ -96,6 +89,8 @@ required:
>    - '#dma-cells'
>  
>  allOf:
> +  - $ref: /schemas/mailbox/mediatek,gce-props.yaml
> +
>    - if:
>        properties:
>          compatible:
> @@ -142,7 +137,7 @@ allOf:
>          clocks:
>            maxItems: 1
>  
> -additionalProperties: false
> +unevaluatedProperties: false
>  
>  examples:
>    - |
> diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-
> rsz.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-
> rsz.yaml
> index f5676bec4326..4774fdde1a1b 100644
> --- a/Documentation/devicetree/bindings/media/mediatek,mdp3-rsz.yaml
> +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-rsz.yaml
> @@ -38,13 +38,6 @@ properties:
>        4 arguments defined in this property. Each GCE subsys id is
> mapping to
>        a client defined in the header include/dt-bindings/gce/<chip>-
> gce.h.
>  
> -  mediatek,gce-events:
> -    description:
> -      The event id which is mapping to the specific hardware event
> signal
> -      to gce. The event id is defined in the gce header
> -      include/dt-bindings/gce/<chip>-gce.h of each chips.
> -    $ref: /schemas/types.yaml#/definitions/uint32-array
> -
>    clocks:
>      minItems: 1
>  
> @@ -55,7 +48,10 @@ required:
>    - mediatek,gce-events
>    - clocks
>  
> -additionalProperties: false
> +allOf:
> +  - $ref: /schemas/mailbox/mediatek,gce-props.yaml
> +
> +unevaluatedProperties: false
>  
>  examples:
>    - |
> diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-
> wrot.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-
> wrot.yaml
> index 53a679338402..a31f3f5aea96 100644
> --- a/Documentation/devicetree/bindings/media/mediatek,mdp3-wrot.yaml
> +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-wrot.yaml
> @@ -38,13 +38,6 @@ properties:
>        4 arguments defined in this property. Each GCE subsys id is
> mapping to
>        a client defined in the header include/dt-bindings/gce/<chip>-
> gce.h.
>  
> -  mediatek,gce-events:
> -    description:
> -      The event id which is mapping to the specific hardware event
> signal
> -      to gce. The event id is defined in the gce header
> -      include/dt-bindings/gce/<chip>-gce.h of each chips.
> -    $ref: /schemas/types.yaml#/definitions/uint32-array
> -
>    power-domains:
>      maxItems: 1
>  
> @@ -67,7 +60,10 @@ required:
>    - iommus
>    - '#dma-cells'
>  
> -additionalProperties: false
> +allOf:
> +  - $ref: /schemas/mailbox/mediatek,gce-props.yaml
> +
> +unevaluatedProperties: false
>  
>  examples:
>    - |

^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2024-07-11  1:36 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-24  1:14 [PATCH v4 0/3] Add mediatek,gce-props.yaml for other bindings reference Jason-JH.Lin
2024-01-24  1:14 ` [PATCH v4 1/3] dt-bindings: mailbox: Add mediatek,gce-props.yaml Jason-JH.Lin
2024-01-24  8:57   ` AngeloGioacchino Del Regno
2024-05-26 15:04     ` Jason-JH Lin (林睿祥)
2024-05-28 10:26       ` AngeloGioacchino Del Regno
2024-07-10 14:28       ` Jassi Brar
2024-07-10 16:22         ` Jassi Brar
2024-07-11  1:14           ` Jason-JH Lin (林睿祥)
2024-01-24  1:14 ` [PATCH v4 2/3] dt-bindings: media: mediatek: mdp: Change mediatek,gce-events to reference Jason-JH.Lin
2024-01-24  8:57   ` AngeloGioacchino Del Regno
2024-07-11  1:35   ` Jason-JH Lin (林睿祥)
2024-01-24  1:14 ` [PATCH v4 3/3] dt-bindings: soc: mediatek: Change mediatek,gce-events to refernece Jason-JH.Lin
2024-01-24  8:57   ` AngeloGioacchino Del Regno

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).