From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38FCCC433E0 for ; Tue, 30 Jun 2020 10:24:37 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 00FE320760 for ; Tue, 30 Jun 2020 10:24:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="iAYnn7j3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 00FE320760 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pAFduDvIQlzG9+vGzT1jDS3MshKkPi3GUSqBR4kRc0Y=; b=iAYnn7j33krHtkVXBV7UPCTLW p3kfYRBReqhUiztAGV4tixSlvzc/ZrpT8qyYkMmoL391yOnGjAyWTDraAhhWB5TzkhF5XUschAOhL K6sbS79nQE597eirlZhJC6D7+QsqlMqiyAOOaN6sBGkMqgK5O6bU65ndJXJVBArczF4IiI/sB9XSd ZZ51WMPF6Aa2VdGCmzN0SXJ2WrZZ/pIg4pGvH+obQmVfZ9l/CawadAILgLoUMYLRbgptKseg38GEc gMjt1bI3Jjjpl/AZNrpLEbjIpLcH6CijsGkgUg8JoSZ+RGMyt+myq9YS6viidhcbpfhpRTg00i5yj 4N0wZIQ8g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqDQ2-0006Mh-1x; Tue, 30 Jun 2020 10:23:14 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqDPz-0006MP-Ev for linux-arm-kernel@lists.infradead.org; Tue, 30 Jun 2020 10:23:12 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9D98830E; Tue, 30 Jun 2020 03:23:07 -0700 (PDT) Received: from [10.37.12.67] (unknown [10.37.12.67]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B51ED3F68F; Tue, 30 Jun 2020 03:23:04 -0700 (PDT) Subject: Re: [PATCH 0/5] cpuidle: psci: Various improvements for PSCI PM domains To: Ulf Hansson References: <20200615152054.6819-1-ulf.hansson@linaro.org> From: Lukasz Luba Message-ID: Date: Tue, 30 Jun 2020 11:23:02 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20200615152054.6819-1-ulf.hansson@linaro.org> Content-Language: en-US X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lorenzo Pieralisi , Vincent Guittot , Benjamin Gaignard , Saravana Kannan , linux-pm@vger.kernel.org, Stephen Boyd , Daniel Lezcano , "Rafael J . Wysocki" , Lina Iyer , Bjorn Andersson , Sudeep Holla , linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Ulf, On 6/15/20 4:20 PM, Ulf Hansson wrote: > The main change in this series is done in patch 5/5, which implements support > to prevent domain idlestates until all PSCI PM domain consumers are ready for > it. To reach that point the corresponding code for cpuidle-psci and > cpuidle-psci-domain, needed to be converted into platform drivers, which is > done by the earlier changes in the series. > > Additionally, some improvements have been made to the error path, which becomes > easier when the code gets converted to platform drivers. > > Deployment for a Qcom SoC, which actually takes full benefit of these changes > are also in the pipe, but deferring then a bit until $subject series have been > discussed. > > Kind regards > Ulf Hansson > > Ulf Hansson (5): > cpuidle: psci: Fail cpuidle registration if set OSI mode failed > cpuidle: psci: Fix error path via converting to a platform driver > cpuidle: psci: Split into two separate build objects > cpuidle: psci: Convert PM domain to platform driver > cpuidle: psci: Prevent domain idlestates until consumers are ready > > drivers/cpuidle/Kconfig.arm | 10 ++ > drivers/cpuidle/Makefile | 5 +- > drivers/cpuidle/cpuidle-psci-domain.c | 74 +++++++++----- > drivers/cpuidle/cpuidle-psci.c | 141 +++++++++++++++----------- > drivers/cpuidle/cpuidle-psci.h | 11 +- > 5 files changed, 150 insertions(+), 91 deletions(-) > Since I am interested in some CPU idle statistics (residency, etc), I would like to help you and Sudeep in reviewing the patch set. Could you clarify some bit below? 1. There is Qcom SoC which has dependencies between PSCI PM domain consumers and this CPU idle - thus we cannot register and use CPU idle driver till related drivers fully setup. 2. The proposed solution is to use platform driver and plat. device for this CPU idle driver, to have access to deferred probe mechanism and wait for the consumer drivers fully probed state. 3. Do you have maybe some estimations how long it takes for these consumers to be fully probed? 4. Changing just this CPU idle driver registration point (to late_initcall()) phase in time is not a solution. Regards, Lukasz _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel